Re: 8028564: Concurrent calls to CHM.put can fail to add the key/value to the map

2013-12-06 Thread Paul Sandoz
On Dec 5, 2013, at 9:29 PM, Doug Lea d...@cs.oswego.edu wrote: On 12/05/2013 03:18 PM, Brent Christian wrote: I'm curious about why this was done: *** 4452,4462 public final boolean removeAll(Collection? c) { ! Objects.requireNonNull(c); boolean

Re: 8028564: Concurrent calls to CHM.put can fail to add the key/value to the map

2013-12-06 Thread Chris Hegarty
On 06/12/13 08:38, Paul Sandoz wrote: On Dec 5, 2013, at 9:29 PM, Doug Lea d...@cs.oswego.edu wrote: On 12/05/2013 03:18 PM, Brent Christian wrote: I'm curious about why this was done: *** 4452,4462 public final boolean removeAll(Collection? c) { !

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread Alan Bateman
On 05/12/2013 05:30, Sergey Lugovoy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~yan/8029451/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8029451 This patch cleanup tidy warnings for generated html documentation, and do not affect the appearance of the

Re: Poor Javadoc of Map default methods [Re: RFR: 8029055: Map.merge must refuse null values]

2013-12-06 Thread Stephen Colebourne
See https://bugs.openjdk.java.net/browse/JDK-8029676 Stephen On 26 November 2013 13:20, Stephen Colebourne scolebou...@joda.org wrote: I took a quick look, but jumped back in horror at the start of the Javadoc for the new methods in Map. A Javadoc description should start with the positive,

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread roger riggs
+1, It can be used with any tag (not just p, including h3, ul, li, br, etc.) On 12/6/2013 1:09 AM, Martin Buchholz wrote: In jsr166-land we recently started using p id=TAG, which I recommend, e.g. AbstractQueuedSynchronizer.java:122: * p id=bargingBecause checks in acquire are invoked

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread Michael McMahon
On 06/12/13 11:44, Alan Bateman wrote: On 05/12/2013 05:30, Sergey Lugovoy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~yan/8029451/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8029451 This patch cleanup tidy warnings for generated html documentation, and do

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread Joe Darcy
On 12/06/2013 09:20 AM, Martin Buchholz wrote: FYI: When I run javadoc on jsr166 CVS (it's not too hard for y'all to do this as well), I still see many warnings inherited from openjdk8 source: $ ant docs ... [javadoc] Constructing Javadoc information... [javadoc] Standard Doclet version

Re: 8028564: Concurrent calls to CHM.put can fail to add the key/value to the map

2013-12-06 Thread Mike Duigou
On Dec 6 2013, at 02:07 , Chris Hegarty chris.hega...@oracle.com wrote: On 06/12/13 08:38, Paul Sandoz wrote: On Dec 5, 2013, at 9:29 PM, Doug Lea d...@cs.oswego.edu wrote: On 12/05/2013 03:18 PM, Brent Christian wrote: I'm curious about why this was done: *** 4452,4462

hg: jdk8/tl/jdk: 8023471: Add compatibility note to AnnotatedElement

2013-12-06 Thread joe . darcy
Changeset: f8da1f34c65c Author:darcy Date: 2013-12-06 11:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8da1f34c65c 8023471: Add compatibility note to AnnotatedElement Reviewed-by: smarks, jfranck, abuckley ! src/share/classes/java/lang/annotation/Annotation.java !

RFR: 8029696 : (xs) Broken doc links to package-summary.html#NonInterference in java.util.stream

2013-12-06 Thread Mike Duigou
Hello all; https://bugs.openjdk.java.net/browse/JDK-8029696 Michael McMahon noticed that some links to the anchor #NonInterference were not using the correct name for the anchor. He prepared a patch which I reviewed, tested. I also checked to make sure there were no other broken instances.

hg: jdk8/tl/langtools: 8029504: Regression: TestDocRootLink test fails on Windows

2013-12-06 Thread kumar . x . srinivasan
Changeset: 2d0a0ae7fa9c Author:ksrini Date: 2013-12-06 09:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2d0a0ae7fa9c 8029504: Regression: TestDocRootLink test fails on Windows Reviewed-by: bpatel, jjg !

hg: jdk8/tl/jdk: 8007967: Infinite loop can happen in sun.security.provider.certpath.SunCertPathBuilder.depthFirstSearchForward()

2013-12-06 Thread jason . uh
Changeset: d6c4ae56c079 Author:juh Date: 2013-12-06 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6c4ae56c079 8007967: Infinite loop can happen in sun.security.provider.certpath.SunCertPathBuilder.depthFirstSearchForward() Reviewed-by: mullan !

Re: RFR: 8029055: Map.merge must refuse null values

2013-12-06 Thread Mike Duigou
Hello all. I have updated the webrev with a final correction from Brian Goetz, the @throws NPE didn't reflect that it was thrown unconditionally if value is null. http://cr.openjdk.java.net/~mduigou/JDK-8029055/2/webrev/ Mike On Nov 25 2013, at 20:32 , Mike Duigou mike.dui...@oracle.com