RFR 8043954: Fix behavior difference of connect() for AIX

Hello, Could I have following patch reviewed for bug 8034954 ? http://cr.openjdk.java.net/~luchsh/JDK-8043954/ The patch is to fix a behavior difference of connect() API for AIX platform, according to the documentation,

RFR (S): JDK-8039916: AnnotatedType.getType() of a Executable parameters may return wrong type

Hi Can I get a review for this small fix for https://bugs.openjdk.java.net/browse/JDK-8039916 Webrev here: http://cr.openjdk.java.net/~jfranck/8039916/webrev.01/ Since this is the second issue like this found recently I created a rather large test to see if there are any more lurking issues.

Re: RFR 8043954: Fix behavior difference of connect() for AIX

Hi Jonathan, thanks for fixing this! I've looked at the change and it looks good to me (but I'm not a reviewer). The only minor flaw I found is that you declare the helper variable 'int rc = -1' but never assign it. Instead you could just return '-1' directly where you currently return 'rc' and

Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

Staffan, David, Returning back to our WaitForMultipleObjects()/WAIT_ABANDONED discussions: Thank you for your comments and remarks. I can't disagree with motivation that it's better to have a fatal error during the incorrect mutex handling then data corruption (the consequence of the previous

Re: RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

Hi Martin, Glad to know you are the original author and thank you to rewrite the test using modern way. I have some concerns about the limit of elapsed time (DELAY_MS / 2 = 5ms) which is much higher than the old value (500ms). The reason is that i checked the nightly failure histories,

RFR 8044647: sun/tools/jrunscript/jrunscriptTest.sh start failing: Output of jrunscript -l nashorn differ from expected output

Hi, Please review http://cr.openjdk.java.net/~sundar/8044647/ Thanks, -Sundar

Re: RFR 8044647: sun/tools/jrunscript/jrunscriptTest.sh start failing: Output of jrunscript -l nashorn differ from expected output

+1 On Jun 3, 2014, at 12:26 PM, A. Sundararajan sundararajan.athijegannat...@oracle.com wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8044647/ Thanks, -Sundar

Re: RFR 8044647: sun/tools/jrunscript/jrunscriptTest.sh start failing: Output of jrunscript -l nashorn differ from expected output

Looks good. Kumar On 6/3/2014 8:26 AM, A. Sundararajan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8044647/ Thanks, -Sundar

Re: RFR 8044647: sun/tools/jrunscript/jrunscriptTest.sh start failing: Output of jrunscript -l nashorn differ from expected output

don't forget to mark the bug with noreg-self. Kumar On 6/3/2014 8:49 AM, Kumar Srinivasan wrote: Looks good. Kumar On 6/3/2014 8:26 AM, A. Sundararajan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8044647/ Thanks, -Sundar

Re: RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

Hi Martin, Is it possible that the main thread takes too long to go from y3.await() to the t.cancel() that the fixed rate timer (y3) gets called again? It seems unlikely, but with the printf, its not just compute time. Canceling the timer before the printf would likely reduce the failures.

RFR: JDK-8044725: Bug in zlib 1.2.5 prevents inflation of some gzipped files

Hi, Please help review the change to upgrade the zlib bundled with jdk/jre from 1.2.5 to 1.2.8. This is mainly to address the bug fix mentioned in 1.2.8's release at zlib.net. Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately...

RE: RFR: JDK-8044725: Bug in zlib 1.2.5 prevents inflation of some gzipped files

Hi, Sherman. http://cr.openjdk.java.net/~sherman/8044725/webrev I took a look at the legal notices in the new files and they all seem fine to me. Thanks, iris -Original Message- From: Xueming Shen Sent: Tuesday, June 03, 2014 3:34 PM To: core-libs-dev Subject: RFR: JDK-8044725: Bug

Re: RFR for bug JDK-8004807: java/util/Timer/Args.java failing intermittently in HS testing

Hi Martin, To sleep(1000) is not enough to reproduce the failure, because it is much lower than the period DELAY_MS (10*1000) of the repeated task created by scheduleAtFixedRate(t, counter(y3), past, DELAY_MS). Try sleep(DELAY_MS), the failure can be reproduced. Thanks, Eric On 2014/6/4

RFR: 8044740: Convert all JDK versions used in @since tag to 1.n[.n] in jdk repo

Hi, In an effort to determine APIs availability in a given version, it became obvious that a consistent way to express @since tag would be beneficial. So started with the most obvious ones, where we have various expression for JDK version, this webrev make sure we use @since 1.n[.n] for JDK

Re: RFR: 8044740: Convert all JDK versions used in @since tag to 1.n[.n] in jdk repo

You will need to include awt-dev and security-dev since this patch touches those areas as well. Other impacted groups I missed? I would like to see this all go back in one changeset to dev repo though as it would be a lot cleaner that way. I am concerned a bit that if we retain standard names

Re: RFR: 8044740: Convert all JDK versions used in @since tag to 1.n[.n] in jdk repo

I like seeing JDK as well... primarily because IDEs have the ability to show javadoc snippets when hovering over an element. It's good to see what product the version comes relates to. Yet, on the other hand, these Oracle APIs are not published under JDK branding but under the title Java SE.