Thank you Pavel!
Pushed.
On 3/27/20 5:09 AM, Pavel Rappo wrote:
140 a successful * query to a constant will always remain successful.
Made me pause and read a bit of the surrounding context
to make sure there's no "*" type of query.
Looks good to me. Thanks for doing this.
-Pavel
On
Hi Joe,
Overall this looks quite good. Thanks for being thorough about this; I certainly
would have forgotten about StrictMath. :-) Since this is integer arithmetic, is
it true that the StrictMath versions are identical to the Math versions?
I have only a couple editorial quibbles.
+ *
Hello,
Please review the initial proposed wording of the spec for
JDK-8241374: add Math.absExact
The eventual wording needs to be replicated four times
(Math.absExact(int), Math.absExact(long), StrictMath.absExact(int),
StrictMath.absExact(long)) so I want to get the wording agreed to
Hi all,
it's a little bit OT even if the JDK itself as a dependency on ASM.
I'm proud to announce that ASM 8 (nicknamed the Quarantine Edition) was
released today !
It fully supports Java 14 (the Record attribute) and even support sealed types
(the attribute PermittedSubtypes) as an
On 3/28/2020 9:43 AM, Andy Herrick wrote:
On 3/27/2020 5:18 PM, Alexander Matveev wrote:
Hi Andy,
http://cr.openjdk.java.net/~herrick/8237490/webrev.05/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java.frames.html
Line 819,857,902 - Looks
double "the"
899 * the format specified in section {@jvms 4.7.9} of the
900 * The Java Virtual Machine Specification,
Otherwise OK,
-- Jon
On 3/27/20 9:53 PM, Joe Darcy wrote:
Hello,
As noticed during the CSR review of JDK-8238359, not all the citations
of JVMS and JLS are done
On 3/27/2020 5:18 PM, Alexander Matveev wrote:
Hi Andy,
http://cr.openjdk.java.net/~herrick/8237490/webrev.05/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java.frames.html
Line 819,857,902 - Looks like temp debug log message. Remove it or
