Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

OK, I agree with David gettimeofday is an improvement than 1, so we can go ahead with the patch. Not sure if the caveat should be disclosed or not, I don’t think it’s important enough, just a known fact probably worth to leave a trace(perhaps a comment in code or the bug entry). As whether to

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

Hi Andy, Looks good. Thanks, Alexander On 3/30/20 3:44 PM, Alexey Semenyuk wrote: Looks good. - Alexey On 3/30/2020 1:19 PM, Andy Herrick wrote: revised with minor fixes as per below - webrev at [3] [3] http://cr.openjdk.java.net/~herrick/8237490/webrev.06/ /Andy On 3/28/2020 9:43 AM,

Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

Hello! Speaking about implementation, how about this? return (a < 0) ? negateExact(a) : a; This would require only one branch for positive numbers and also will utilize already intrinsified negateExact. The cost is a less verbose message ("integer overflow" or "long overflow"). However, when

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

Hi David, Henry, Alan, Thanks a lot for your review. I have considered use clock_gettime() first, but I seached the code and found there is a marco SUPPORTS_CLOCK_MONOTONIC guard the usage of it. Which makes me think it may not be available under specific situation. So I choosed

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set

On 31/03/2020 4:08 am, Henry Jen wrote: Based on my understanding to gethrtime(), the main benefit is not to be affected by settimeofday or adjtime. I think it is probably better to use clock_gettime(CLOCK_MONOTONIC_RAW, ts); which I checked seems to be available on both Linux and Mac.

Re: RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

+1 Good catch Naoto > On Mar 30, 2020, at 6:44 PM, Joe Wang wrote: > > > On 3/30/20 3:12 PM, naoto.s...@oracle.com wrote: >> Hi Joe, >> >> Much better and cleaner! One nit is that you could remove "docLocator != >> null &&" as instanceof checks null. > > Indeed, null check is removed: >

Re: RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

Looks good. Thanks for the update. Naoto On 3/30/20 3:44 PM, Joe Wang wrote: On 3/30/20 3:12 PM, naoto.s...@oracle.com wrote: Hi Joe, Much better and cleaner! One nit is that you could remove "docLocator != null &&" as instanceof checks null. Indeed, null check is removed:

Re: RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

On 3/30/20 3:12 PM, naoto.s...@oracle.com wrote: Hi Joe, Much better and cleaner! One nit is that you could remove "docLocator != null &&" as instanceof checks null. Indeed, null check is removed: http://cr.openjdk.java.net/~joehw/jdk15/8238183/webrev_03/ Thanks, Joe Naoto On 3/30/20

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

Looks good. - Alexey On 3/30/2020 1:19 PM, Andy Herrick wrote: revised with minor fixes as per below - webrev at [3] [3] http://cr.openjdk.java.net/~herrick/8237490/webrev.06/ /Andy On 3/28/2020 9:43 AM, Andy Herrick wrote: On 3/27/2020 5:18 PM, Alexander Matveev wrote: Hi Andy,

Re: RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

Hi Joe, Much better and cleaner! One nit is that you could remove "docLocator != null &&" as instanceof checks null. Naoto On 3/30/20 2:56 PM, Joe Wang wrote: Hi Naoto, Thanks for the review! I refactored the code around getting the XML version and encoding from the locator to get rid of

Re: RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

HI Joe, This version looks OK Best Lance > On Mar 30, 2020, at 5:56 PM, Joe Wang wrote: > > Hi Naoto, > > Thanks for the review! > > I refactored the code around getting the XML version and encoding from the > locator to get rid of the CCE. The impls with EventWriter and StreamWriter >

Re: RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

Hi Naoto, Thanks for the review! I refactored the code around getting the XML version and encoding from the locator to get rid of the CCE. The impls with EventWriter and StreamWriter share a base class. All three classes are therefore refactored. No material change to the EventWriter impl.

Re: 6202130: Need to handle UTF-8 values and break up lines longer than 72 bytes

Hi Philipp, Sorry for the delay. On 3/25/20 11:52 AM, Philipp Kunz wrote: Hi Naoto, See another patch attached with Locale.ROOT for the BreakIterator. I will be glad to hear of any feedback. I wonder how your change affects the performance, as it will do String.getBytes(UTF-8) per each

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

This is the patch to keep the JDK 14 behavior if target release to 14 (thanks to Jan for helping making change in javac to get the tests working) http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-javac-target-release-14/ Mandy On 3/27/20 9:29 AM, Mandy Chung wrote: Hi Jan,

Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

> On 30 Mar 2020, at 18:53, Joe Darcy wrote: > > Hello, > > Updated webrev at: > > http://cr.openjdk.java.net/~darcy/8241374.1/ > LGTM. -Chris.

Re: RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

Hi Joe, Can writeStartDocument() be simplified by checking "docLocator instanceof Locator2"? This way it won't need to catch CCE and issue no-arg version. Otherwise looks good to me. Naoto On 3/30/20 11:02 AM, Joe Wang wrote: Hi, Please review a fix for the StAXResult impl. The issue was

Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

+1 Brian > On Mar 30, 2020, at 10:53 AM, Joe Darcy wrote: > > Updated webrev at: > > http://cr.openjdk.java.net/~darcy/8241374.1/ > > One of the four pieces of the update to discuss below. A few comments, I > added links from the abs

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set

Based on my understanding to gethrtime(), the main benefit is not to be affected by settimeofday or adjtime. I think it is probably better to use clock_gettime(CLOCK_MONOTONIC_RAW, ts); which I checked seems to be available on both Linux and Mac. Haven’t test it though. Cheers, Henry > On

RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

Hi, Please review a fix for the StAXResult impl. The issue was that it output comment prior to the declaration, resulting in an invalid XML document. The patch focuses on fixing this issue, but it does not cover other issues the StAXResult impl may have (e.g. JDK-8241711). JBS:

Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

Hello, Updated webrev at:     http://cr.openjdk.java.net/~darcy/8241374.1/ One of the four pieces of the update to discuss below. A few comments, I added links from the abs methods to its sibling absExact method along with an additional note on referring the differing absExact behavior on a

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

revised with minor fixes as per below - webrev at [3] [3] http://cr.openjdk.java.net/~herrick/8237490/webrev.06/ /Andy On 3/28/2020 9:43 AM, Andy Herrick wrote: On 3/27/2020 5:18 PM, Alexander Matveev wrote: Hi Andy,

Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

Hi Brian and Chris, I was considering adding such as JLS link myself; I'll work one in and post a revised webrev. Thanks, -Joe On 3/30/2020 9:29 AM, Brian Burkhalter wrote: Hi Joe, On Mar 30, 2020, at 6:31 AM, Chris Hegarty > wrote: Full webrev for

Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

Hi Joe, > On Mar 30, 2020, at 6:31 AM, Chris Hegarty wrote: > >> Full webrev for review include including tests: >> >>http://cr.openjdk.java.net/~darcy/8241374.0/ >> >> >> and the companion CSR: >> >>

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 3/30/20 02:30, serguei.spit...@oracle.com wrote: Hi Mandy, I have just one comment so far. http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp.frames.html  356   void add_classes(LoadedClassInfo*

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 3/30/20 5:54 AM, David Holmes wrote: Sorry to jump in on this but it caught my eye though I may be missing a larger context ... On 30/03/2020 7:30 pm, serguei.spit...@oracle.com wrote: Hi Mandy, I have just one comment so far.

Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

Joe, > On 29 Mar 2020, at 20:03, Joe Darcy wrote: > > Hi Stuart, > > Full webrev for review include including tests: > > http://cr.openjdk.java.net/~darcy/8241374.0/ > > and the companion CSR: > > https://bugs.openjdk.java.net/browse/JDK-8241805 Looks good to me. I do like the

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Sorry to jump in on this but it caught my eye though I may be missing a larger context ... On 30/03/2020 7:30 pm, serguei.spit...@oracle.com wrote: Hi Mandy, I have just one comment so far.

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Hi Mandy, I have just one comment so far. http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp.frames.html  356   void add_classes(LoadedClassInfo* first_class, int num_classes, bool has_class_mirror_holder) {  

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set

On 30/03/2020 03:41, linzang(臧琳) wrote: Dear All, May I ask your help to reivew this tiny patch? Thanks. BRs, Lin From: "linzang(臧琳)" Date: Thursday, March 26, 2020 at 3:13 PM To: "core-libs-dev@openjdk.java.net" Subject: RFR(S): 8241638: launcher time metrics alway report 1 on Linux

Re: [PING] RFR(s): 8176894 Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute, merge in TreeMap

Ok, I will remove the periods. They are also absent in the corresponding methods in HashMap. On Mon, Mar 30, 2020 at 4:33 AM Roger Riggs wrote: > > Hi, > > Usually the @throws, @param, @return, etc clauses are not complete > sentences. > Only complete sentences need a period. > And most of