On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin wrote:
>> Marked as reviewed by kvn (Reviewer).
>
> Have you run the JFR tests in test/jdk/jdk/jfr?
@marschall Please do not force-push anything as it breaks the commit history in
the PR and renders previous
reviews/comments obsolete. There is no
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the
good catch Chris, thanks for the patch,
Vicente
On 9/22/20 5:51 AM, Chris Hegarty wrote:
On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote:
Hi Vicente,
Please file a separate subtask for the javax.lang.model changes. This helps
with the JSR 269 MR paperwork.
Thanks,
-Joe
note: I have
> These changes update the jlink plugin command line documentation to tidy them
> up into a more canonical form.
>
> The output generated by jlink from this change appears as follows:
>
>> build/macosx-x64/images/jdk/bin/jlink --list-plugins
>
> List of available plugins:
> --strip-debug
On Wed, 23 Sep 2020 00:37:18 GMT, Mandy Chung wrote:
>> These changes update the jlink plugin command line documentation to tidy
>> them up into a more canonical form.
>>
>> The output generated by jlink from this change appears as follows:
>>
>>> build/macosx-x64/images/jdk/bin/jlink
> On Sep 22, 2020, at 7:35 PM, alexander.matv...@oracle.com wrote:
>
> Hi Michael,
>
> For file association you will need to create property file and pass it to
> jpackage via --file-associations.
Thanks for the detailed reply. I will look closer at it later. I had found the
test class. I
On Tue, 22 Sep 2020 17:52:00 GMT, Ian Graves wrote:
> These changes update the jlink plugin command line documentation to tidy them
> up into a more canonical form.
>
> The output generated by jlink from this change appears as follows:
>
>> build/macosx-x64/images/jdk/bin/jlink --list-plugins
Hi Michael,
For file association you will need to create property file and pass it
to jpackage via --file-associations.
Example property file:
mime-type=text/plain
extension=txt
description=Text file
See following documentation:
On Sun, 20 Sep 2020 21:23:17 GMT, Andy Herrick wrote:
> 8253149: Building an installer from invalid app image fails on Windows and
> Linux
> When jpackage builds a package from an app-image that was not generated by
> jpackage, the tool should give user a
> warning message, and then complete
On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
This pull request has now been integrated.
Changeset: bddb8225
Author:Naoto Sato
URL:
On Tue, 22 Sep 2020 11:53:14 GMT, Andy Herrick wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and
>> Linux
>> When jpackage builds a package from an app-image that was not generated by
>> jpackage, the tool should give user a
>> warning message, and then
On Tue, 22 Sep 2020 11:53:14 GMT, Andy Herrick wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and
>> Linux
>> When jpackage builds a package from an app-image that was not generated by
>> jpackage, the tool should give user a
>> warning message, and then
Hi Martin,
Overall it seems reasonable to replace the \x{HH} construct with a simpler escape
sequence. I'm a bit surprised to see the performance impact, but you noticed it, so
I'll buy that it's significant.
// These must be literalized to avoid collision with regex
//
Hello,
Per the spec
https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/Math.html#exp(double)
the result of exp has to be within one ulp of the exact result and the
value of e^(10_000) is (much) larger than Double.MAX_VALUE so positive
infinity is the correct answer.
On Wed, 16 Sep 2020 18:02:42 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the fix to the issue wrt missing hashCode() javadoc, which was
>> recently discussed in core-libs ml.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 22 Sep 2020 07:28:42 GMT, Alan Bateman wrote:
> Given that the offset handling is buggy then I think the test should at least
> cover the cases where the offset is 0 or
> out of bounds. No problem separating out further test coverage for the other
> setDictionary methods into a
> Hi all,
>
> Please review the fix for JDK-8252739 which addresses an issue introduced by
> https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored
> the offset specified by
> Deflater.setDictionary. Mach5 jdk-tier1, jdk-tier2, jdk-tier3 runs cleanly
> as well as the
On Tue, 22 Sep 2020 15:36:24 GMT, Daniel Fuchs wrote:
>> No, It is not used.
>> However, I'd like to leave it as is (it is mentioned in the documentation as
>> unsupported value).
>> Otherwise, TlsChannelBindingType enum will have one element only and should
>> be simplified/removed in all
> Hi,
>
> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
> for Java GSS/Kerberos.
> Initial review is available at core-devs:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html
> This version removes "tls-unique" CB type from the list of
On Tue, 22 Sep 2020 15:11:57 GMT, Weijun Wang wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8245527: version.01
>
> src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java
> line
On Tue, 22 Sep 2020 19:48:33 GMT, Ioi Lam wrote:
> Please review this BACKOUT for tier-1 failures. I have tested all CDS tests
> locally on Linux-x64, including the failed
> DeterministicDump.java.
> I would like to apply for the "trivial" rule since this is a simple backout
> for tier-1
On Tue, 22 Sep 2020 19:48:33 GMT, Ioi Lam wrote:
> Please review this BACKOUT for tier-1 failures. I have tested all CDS tests
> locally on Linux-x64, including the failed
> DeterministicDump.java.
> I would like to apply for the "trivial" rule since this is a simple backout
> for tier-1
On Tue, 22 Sep 2020 19:48:33 GMT, Ioi Lam wrote:
> Please review this BACKOUT for tier-1 failures. I have tested all CDS tests
> locally on Linux-x64, including the failed
> DeterministicDump.java.
> I would like to apply for the "trivial" rule since this is a simple backout
> for tier-1
Please review this BACKOUT for tier-1 failures. I have tested all CDS tests
locally on Linux-x64, including the failed
DeterministicDump.java.
I would like to apply for the "trivial" rule since this is a simple backout for
tier-1 failures.
I executed the command:
git revert
> # JDK-8252523: Add ASN.1 Formatter to work with test utility HexPrinter
>
> Debugging functions that utilize ASN.1, DER, and BER encoded streams is
> difficult without test utilities to show the contents.
> The ASN.1 formatter reads a stream and produces annotated output of the
> tags, values,
Dear all,
Thank you for your great job about the openjdk.
I have an idea about a new container, Sieve(I give it the name).
The java file is something like this:
package com.heyifei.studyandshare.utils;
/**
* @author: ??(heyifei)
* @email: heyife...@foxmail.com
* @address: zhangjiang,
> On Sep 22, 2020, at 1:47 PM, Andy Herrick wrote:
>
> Alexander:
>
> Can you explain the mechanism by which a macosx application is expected to
> retrieve the path to the selected file when the app is invoked via a file
> association ?
>
> On mac, the path to the associated file is not
Alexander:
Can you explain the mechanism by which a macosx application is expected
to retrieve the path to the selected file when the app is invoked via a
file association ?
On mac, the path to the associated file is not passed as an argument (as
it is on Linux and Windows).
/Andy
On
On Tue, 22 Sep 2020 18:24:02 GMT, Gilles Duboscq wrote:
> Thanks @mlchung. Do I need a second review?
No need. You can integrate once you run the regression tests (I usually run
tier1-tier3).
-
PR: https://git.openjdk.java.net/jdk/pull/93
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled
On Tue, 22 Sep 2020 18:17:49 GMT, Mandy Chung wrote:
>> Gilles Duboscq has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains six new
On Tue, 22 Sep 2020 18:06:40 GMT, Yumin Qi wrote:
> In patch for jdk-8253208, a comma missed after copyright year in
> src/java.base/share/classes/jdk/internal/math/FDBigInteger.java. Also changed
> "@return" to "Returns" in the comment for
> CDS.getRandomSeedForDumping to keep consistent with
On Tue, 22 Sep 2020 18:03:37 GMT, Gilles Duboscq wrote:
>> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced
>> the
>> jdk.internal.lambda.disableEagerInitialization system property to be able to
>> disable eager initialization of lambda
>> classes. This was necessary
On Tue, 22 Sep 2020 18:06:40 GMT, Yumin Qi wrote:
> In patch for jdk-8253208, a comma missed after copyright year in
> src/java.base/share/classes/jdk/internal/math/FDBigInteger.java. Also changed
> "@return" to "Returns" in the comment for
> CDS.getRandomSeedForDumping to keep consistent with
In patch for jdk-8253208, a comma missed after copyright year in
src/java.base/share/classes/jdk/internal/math/FDBigInteger.java. Also changed
"@return" to "Returns" in the comment for
CDS.getRandomSeedForDumping to keep consistent with others.
-
Commit messages:
- 8253492: Miss
> [JDK-8232806](https://bugs.openjdk.java.net/browse/JDK-8232806) introduced the
> jdk.internal.lambda.disableEagerInitialization system property to be able to
> disable eager initialization of lambda
> classes. This was necessary to prevent side effects of class initializers
> triggered by such
These changes update the jlink plugin command line documentation to tidy them
up into a more canonical form.
The output generated by jlink from this change appears as follows:
> build/macosx-x64/images/jdk/bin/jlink --list-plugins
List of available plugins:
--strip-debug Strip
On Mon, 21 Sep 2020 10:47:40 GMT, Hannes Wallnöfer wrote:
>> This pull request is identical with the RFR previously sent for the
>> Mercurial repository:
>>
>> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>>
>> I'm copy-pasting the comments from the original RFR
On Tue, 22 Sep 2020 17:24:19 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge pull request #1 from lahodaj/JDK-8216497
>>
>>Automatically generate the elements-list data
On Mon, 21 Sep 2020 07:10:47 GMT, Bernhard Urban-Forster
wrote:
>> I assume you need the rest of the PATH on Windows.
>
>> I assume you need the rest of the PATH on Windows.
>
> Doesn't look like it actually. I've reverted it, thanks for catching it.
Thanks, I tried the updated patch and it
On Tue, 22 Sep 2020 03:34:37 GMT, Vladimir Kozlov wrote:
> @jatin-bhateja Can you put summary of performance improvement into JBS?
Yes, I have added the summary to JBS
-
PR: https://git.openjdk.java.net/jdk/pull/61
On Tue, 22 Sep 2020 03:34:37 GMT, Vladimir Kozlov wrote:
> @jatin-bhateja Can you put summary of performance improvement into JBS?
yes, I have added the summary in JBS.
-
PR: https://git.openjdk.java.net/jdk/pull/61
On Fri, 18 Sep 2020 23:47:56 GMT, Yumin Qi wrote:
> With more CDS related code added to VM, it is time to move CDS code to a
> separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4
This pull request has now been integrated.
Changeset: c1df13b8
Author:Yumin Qi
On Mon, 21 Sep 2020 22:24:15 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
>
Please review this small change to remove "--memory 200m" option from
TestUseContainerSupport.java. This can cause
test failures on systems where swap accounting is disabled.
-
Commit messages:
- 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap
limit
> Summary:
>
> 1) New AVX3 optimized stubs for both conjoint and disjoint arraycopy.
> 2) Special instruction sequence blocks for copy sizes b/w 32-192 bytes.
> 3) Block copy operation above 192 bytes is performed using destination
> address aligned PRE-MAIN-POST loop. Main loop
> copies 192
> Summary:
>
> 1) New AVX3 optimized stubs for both conjoint and disjoint arraycopy.
> 2) Special instruction sequence blocks for copy sizes b/w 32-192 bytes.
> 3) Block copy operation above 192 bytes is performed using destination
> address aligned PRE-MAIN-POST loop. Main loop
> copies 192
On Mon, 21 Sep 2020 08:19:28 GMT, Alexey Bakhtin wrote:
> Hi,
>
> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
> for Java GSS/Kerberos.
> Initial review is available at core-devs:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html
>
On Tue, 22 Sep 2020 15:17:23 GMT, Alexey Bakhtin wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java
>> line 63:
>>
>>> 61: * Channel binding on the basis of TLS Finished message
>>> 62: */
>>> 63: TLS_UNIQUE("tls-unique"),
>>
>> Is
On Mon, 21 Sep 2020 12:45:55 GMT, Jason Tatton
wrote:
>> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1
>> byte encoded Strings). It is provided for
>> x86 and ARM64. The implementation is greatly inspired by the indexOf(char)
>> intrinsic for StringUTF16. To
On Fri, 18 Sep 2020 11:56:09 GMT, Jason Tatton
wrote:
>> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1
>> byte encoded Strings). It is provided for
>> x86 and ARM64. The implementation is greatly inspired by the indexOf(char)
>> intrinsic for StringUTF16. To
On Tue, 22 Sep 2020 14:47:35 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
>> for Java GSS/Kerberos.
>> Initial review is available at core-devs:
>>
On Tue, 22 Sep 2020 14:41:57 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
>> for Java GSS/Kerberos.
>> Initial review is available at core-devs:
>>
On Mon, 21 Sep 2020 08:19:28 GMT, Alexey Bakhtin wrote:
> Hi,
>
> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
> for Java GSS/Kerberos.
> Initial review is available at core-devs:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html
>
On Tue, 22 Sep 2020 02:49:50 GMT, Alexander Matveev
wrote:
>
>
> > How about testing of other jpackage command line options in two phase mode?
> > Like "--name", "--version"? Any plans to
> > add them?
>
> Plan was to file separate bugs for any additional options. I do not think we
>
On Mon, 21 Sep 2020 08:19:28 GMT, Alexey Bakhtin wrote:
> Hi,
>
> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
> for Java GSS/Kerberos.
> Initial review is available at core-devs:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html
>
On Tue, 22 Sep 2020 12:30:47 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please help to review
>> [JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which
>> helps to improve LDAP
>> tests stability. The list of changes: 1. Usages of wildcard address have
>> been replaced with
On Fri, 18 Sep 2020 12:59:07 GMT, Aleksei Efimov wrote:
> Hi,
>
> Please help to review
> [JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which
> helps to improve LDAP
> tests stability. The list of changes: 1. Usages of wildcard address have been
> replaced with loopback
> 8253149: Building an installer from invalid app image fails on Windows and
> Linux
> When jpackage builds a package from an app-image that was not generated by
> jpackage, the tool should give user a
> warning message, and then complete the package anyway.
Andy Herrick has updated the pull
Hi!
According to a bug report at AdoptOpenJDK [1] Math.exp(10_000.0) yields
different results on 32 bit systems than on 64 bit systems.
public class Test {
public static void main(String[] args) {
System.out.println(Math.exp(10_000.0));
}
}
On 64 bit systems the
On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote:
>> Hi Vicente,
>> Please file a separate subtask for the javax.lang.model changes. This helps
>> with the JSR 269 MR paperwork.
>> Thanks,
>> -Joe
>
> note: I have removed from the original patch the code related to
> javax.lang.model, I
> https://bugs.openjdk.java.net/browse/JDK-8231591
>
> - Added MultiLauncherTwoPhaseTest which uses predefine app image with
> multiple launcher and tests to make sure installer
> will create shortcuts for all launchers.
> - Fixed Linux DesktopIntegration to create shortcuts for additional
On Tue, 22 Sep 2020 02:31:14 GMT, Vladimir Kozlov wrote:
>>> >Can you explain where this restricted effect is documented?
>>
>>> Certainly! I’ve found that determining the capability of the CPU and
>>> whether to enable AVX2 support if the chip
>>> supports it is mostly controlled in:
On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote:
>> Philippe Marschall has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR. The pull request contains one
On Mon, 21 Sep 2020 19:06:44 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the fix for JDK-8252739 which addresses an issue introduced by
>> https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored
>> the offset specified by
>> Deflater.setDictionary. Mach5
On Tue, 22 Sep 2020 01:25:16 GMT, Ian Graves wrote:
>> Related to [JDK-8252730 jlink does not create reproducible builds on
>> different
>> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces
>> ordering based on `Archive` module names to
>> ensure stable files (and file
On Tue, 22 Sep 2020 01:22:03 GMT, Ian Graves wrote:
>> Whatever is easiest but 2 x copy tree would be simpler and the result should
>> be two identical JDKs as reported in
>> JDK-8252730.
>
> I misunderstood what you meant when I read it earlier today, apologies! The
> new changes should
Hi Philippe,
On 22/09/2020 3:57 pm, Philippe Marschall wrote:
Hello
I am looking for a sponsor for JDK-8138732 [1]. The ready to integrate
PR is here [2].
Sorry I can't volunteer to sponsor this.
Changes between the current code and the reviewed code:
- I removed the jdk.internal export
Hello
I am looking for a sponsor for JDK-8138732 [1]. The ready to integrate
PR is here [2].
Changes between the current code and the reviewed code:
- I removed the jdk.internal export to jdk.jfr, that was a review comment.
- I had to rebase and resolve a merge conflict with JDK-8243066.
[1]
70 matches
Mail list logo
