On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Marked as reviewed by scolebourne (Author).
-
PR: https://git.openjdk.java.net/jdk/pull/6321
On Wed, 10 Nov 2021 03:31:11 GMT, Ichiroh Takiguchi
wrote:
> I tested your code on my CentOS7 x86_64. I saw following exception.
This doesn't surprise me. It would be be useful if you could do the same
experiment with main line and JDK 17 too. There have been several reports of
NPE when
On Tue, 9 Nov 2021 19:38:46 GMT, Naoto Sato wrote:
>>> If this issue is not a part of JEP-400, I think UTF_8 may not be only
>>> solution for sun/nio/fs/Util.java.
>>> Please explain why UTF_8 is better than ISO_8859_1.
>>
>> Just to add to Naoto's comment. When the JDK starts in
On Tue, 9 Nov 2021 15:48:22 GMT, Roger Riggs wrote:
> When set on the command line `jdk.serialFilter` to an invalid value, the
> invalid value is logged but the application is allowed to start without
> setting the filter.
> This leaves the application without the protections of the serial
Please review this PR to update the TimeZoneNames files. @naotoj @coffeys
Some short name changes are not integrated to the JDK. It was detected by the
change made in JDK-8275766.
- Africa/Juba change was done by 2017c
- Africa/Windhoek changes were done by 2018e
- Antarctica/Macquarie
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6321
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
CSR also Reviewed.
-
Marked as reviewed by iris (Reviewer).
PR:
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Absolutely. Will file a CSR.
-
PR: https://git.openjdk.java.net/jdk/pull/6321
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Hi Naoto,
I would probably file a CSR to track this minor update
-
PR:
Simple doc clarification where the `toString()` output only conforms to ISO
8601 if the seconds in the offset are zero.
-
Commit messages:
- 8276775: ZonedDateTime/OffsetDateTime.toString return invalid ISO-8601 for
years <= 1893
Changes:
On Tue, 9 Nov 2021 19:38:01 GMT, Naoto Sato wrote:
>> Please review the subject fix. In light of JEP400, Java runtime can/should
>> start in UTF-8 charset if the underlying native encoding is not supported.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit
On Tue, 9 Nov 2021 19:34:50 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc clarification for setFeature and setProperty
>
> src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line
> Add setProperty/getProperty methods to the XPath API so that properties can
> be supported in the future.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Update as commented
-
Changes:
- all:
On Tue, 9 Nov 2021 16:05:52 GMT, Roger Riggs wrote:
> The java/lang/RuntimeTests/exec/ExecWithDir test forks 500 subprocesses
> hoping to trigger an intermittent problem fixed in 2002.
>
> The test can be removed, it does not exercise the condition it was created
> for.
This pull request has
On Tue, 9 Nov 2021 19:38:01 GMT, Naoto Sato wrote:
>> Please review the subject fix. In light of JEP400, Java runtime can/should
>> start in UTF-8 charset if the underlying native encoding is not supported.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit
On Mon, 8 Nov 2021 09:44:34 GMT, Alan Bateman wrote:
> There may be an argument that the JDK should emit a warning at startup.
Updated to emit a warning, if `sun.jnu.encoding` is not supported.
-
PR: https://git.openjdk.java.net/jdk/pull/6282
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Emit a warning on unsupported
On Tue, 9 Nov 2021 06:31:06 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> javadoc
On Tue, 9 Nov 2021 16:05:52 GMT, Roger Riggs wrote:
> The java/lang/RuntimeTests/exec/ExecWithDir test forks 500 subprocesses
> hoping to trigger an intermittent problem fixed in 2002.
>
> The test can be removed, it does not exercise the condition it was created
> for.
Marked as reviewed by
The java/lang/RuntimeTests/exec/ExecWithDir test forks 500 subprocesses hoping
to trigger an intermittent problem fixed in 2002.
The test can be removed, it does not exercise the condition it was created for.
-
Commit messages:
- 8276880: Remove
When set on the command line `jdk.serialFilter` to an invalid value, the
invalid value is logged but the application is allowed to start without setting
the filter.
This leaves the application without the protections of the serial filter.
The specification should be clarify that an
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote:
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
LGTM
-
Marked as reviewed by mamadal...@github.com (no known OpenJDK
On Fri, 22 Oct 2021 08:03:34 GMT, Hendrik Schreiber
wrote:
> Trivial improvement.
>
> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
> Repeat (again) in the code example that the `State` `Runnable `should be
> implemented as static class and not reference the
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Wed, 3 Nov 2021 22:55:23 GMT, Claes Redestad wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove accidentally committed experimental @Stable (no effect on micros)
>
> Thanks, Naoto!
@cl4es For
On Tue, 9 Nov 2021 08:59:32 GMT, Hendrik Schreiber
wrote:
>> The new example Cleaner instance _is_ shared, though on a pretty small scale
>> (just among instances of CleaningExample). A demonstration of larger scale
>> sharing of a Cleaner instance would be out of scope for this example.
>
>
On Tue, 9 Nov 2021 00:31:36 GMT, Brent Christian wrote:
>> A cleaner can/should be shared within some scope and purpose, in this case
>> the example class .
>> Each cleaner has a dedicated Thread so its not a lightweight object and
>> should not be proliferated.
>> (Loom may be able to use
27 matches
Mail list logo
