Re: RFR: patch to reduce use of many temporary objects in java.util.UUID

2013-11-11 Thread Andreas Rieber
On 11.11.2013 19:39, Steven Schlansker wrote: On Nov 6, 2013, at 4:19 PM, Robert Stupp sn...@gmx.de wrote: Hi, the current implementation of java.util.UUID.fromName() and java.util.UUID.toString() unnecessarily produce a lot of temporary objects. Especially the fromName() method creates

Re: Expose elementType of EnumSet and EnumMap

2013-09-21 Thread Andreas Rieber
Hi Marcin, your issue is here: https://bugs.openjdk.java.net/browse/JDK-8024037 try the new JDK bug system ;-) Andreas On 21.09.2013 17:27, Marcin Wiśnicki wrote: Third party serialization libraries and other tools need to know the type of EnumSet elementType. Currently this field is

Review request for 8011697: ScriptEngine js randomly means either rhino or nashorn, but should instead select one

2013-09-19 Thread Andreas Rieber
Hi, the HashSet used for the script engine factories caused the random behaviour. Bug: https://bugs.openjdk.java.net/browse/JDK-8011697 Webrev: http://cr.openjdk.java.net/~arieber/8011697/webrev.01/ Please review and sponsor required... thanks Andreas On 19.09.2013 08:55, Andreas Rieber

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-28 Thread Andreas Rieber
...@oracle.com wrote: Fix on the way. This exposed another piece that was missing from the original change. But mea culpa for not doing an OPENJDK build. Sorry about that. Thanks, David On 21/08/2013 6:31 PM, Andreas Rieber wrote: Hi David, On 21.08.13 09:53, David Holmes wrote: Hi Andreas

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-21 Thread Andreas Rieber
Hi David, your change causes build problems with ubuntu 12.04. Result is: make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles' make[2]: *** No rule to make target `/usr/local/src/jdk8tl/build/linux-x86-normal-server-release/images/lib/jfr.jar', needed by `all'. Stop. make[2]:

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-21 Thread Andreas Rieber
Hi David, On 21.08.13 09:53, David Holmes wrote: Hi Andreas, On 21/08/2013 4:44 PM, Andreas Rieber wrote: Hi David, your change causes build problems with ubuntu 12.04. Result is: make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles' make[2]: *** No rule to make target `/usr

Re: RFR JDK 8 - Another round of doclint fixes in java.util.jar

2013-07-25 Thread Andreas Rieber
minor one, the year in header needs also update ;-) On 25.07.13 09:11, Joe Darcy wrote: On 07/25/2013 12:09 AM, David Holmes wrote: On 25/07/2013 4:47 PM, Joe Darcy wrote: Hello, Please review this change below to fix another small batch of doclint problem in java.util.jar. Thanks, -Joe

Re: Invalid self-closing element not allowed JavaDoc error

2013-07-25 Thread Andreas Rieber
Hi, the documents are HTML 4. I checked a sample with w3c validator and there i get only a warning (not an error). Warning Line 180, Column 4: NET-enabling start-tag requires SHORTTAG YES br/ ✉ The sequence FOO / can be interpreted in at least two different ways, depending on the DOCTYPE