On Tue, 14 Jun 2022 02:32:54 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Tue, 14 Jun 2022 02:32:54 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Fri, 10 Jun 2022 11:31:06 GMT, Andrey Turbanov wrote:
>> https://github.com/openjdk/jdk/blob/bc28baeba9360991e9b7575e1fbe178d873ccfc1/src/java.base/share/classes/jdk/internal/misc/Signal.java#L177-L178
>>
>> Instead of separate Hashtable.get/remove calls we can just use value
>> returned by
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Tue, 7 Jun 2022 21:19:02 GMT, Brent Christian wrote:
> > The commented out printf/println's should be removed before committing.
>
> Do you mean the pre-existing `println`s in LdapSearchEnumeration.java?
Usually, I would mean any that were added for this issue.
The changes in indentation (as
On Mon, 6 Jun 2022 21:59:56 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
Vote: Yes
On 6/6/22 8:52 PM, Stuart Marks wrote:
I hereby nominate Naoto Sato [1] to membership in the Core Libraries
Group [2].
On Sun, 5 Jun 2022 14:00:09 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in
> -Xcomp.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9033
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung wrote:
> This reapplies JDK-8287384 and adjust the number of GCs for negative case,
> i.e. the condition is never met that is used to verify a reference is not
> GC'ed.
Marked as reviewed by rriggs (Reviewer).
-
PR:
On Fri, 27 May 2022 22:09:22 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
On Fri, 27 May 2022 22:09:22 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
On Fri, 27 May 2022 22:09:22 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
On Wed, 1 Jun 2022 07:50:58 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
On Tue, 31 May 2022 19:30:07 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
On Tue, 31 May 2022 19:30:07 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
On Tue, 31 May 2022 17:41:08 GMT, Mandy Chung wrote:
> Hmm... one benefit of Cleaner is the ease of use to avoid the need of
> managing the reference queue. If the performance of the Cleaner API is a
> concern, perhaps we should look into reducing its overhead?
The code using a Cleaner here
On Fri, 27 May 2022 20:21:12 GMT, Mandy Chung wrote:
> With the `AccessFlag` API, what is the role of the `Modifier` API going
> forward? [Value Objects JEP](https://openjdk.java.net/jeps/8277163) defines
> the new `identity` and `value` modifiers. [PR
>
On Sun, 29 May 2022 21:57:46 GMT, Andrey Turbanov wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance.
> There are some code that still uses StringBuffer in java.naming which could
> be migrated
On Tue, 31 May 2022 07:40:56 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
On Sun, 29 May 2022 14:00:20 GMT, Andrey Turbanov wrote:
> `String.contains` was introduced in Java 5.
> Some code in java.naming still uses old approach with `String.indexOf` to
> check if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Wed, 25 May 2022 23:08:38 GMT, Brian Burkhalter wrote:
> If only a leftover `char` remains in the stream, do not add `-1` to the
> return value in `lockedRead()`.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8895
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
ok, the updates look fine.
-
Marked as reviewed by rriggs
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
Even using a Cleaner is a more overhead than necessary.
I would have
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Fri, 20 May 2022 22:18:42 GMT, liach wrote:
>> Simplify opcode handling, use `final` in `PrimitiveTypeInfo`, and replace
>> the hash map with a simple lookup, similar to what's done in
>> [JDK-8284880](https://bugs.openjdk.java.net/browse/JDK-8284880) (#8242)
>
> liach has updated the pull
On Sat, 30 Apr 2022 17:10:55 GMT, Andrey Turbanov wrote:
> No need to separately perform `HashMap.containsKey` before `HashMap.remove`
> call. If key is present - it will be removed anyway. If it's not present,
> nothing will be deleted.
Marked as reviewed by rriggs (Reviewer).
-
On Mon, 23 May 2022 18:58:34 GMT, Mark Powers wrote:
>> JDK-6725221 Standardize obtaining boolean properties with defaults
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Alan and Jamil comments
On Tue, 10 May 2022 19:24:24 GMT, Mark Powers wrote:
>> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777:
>>
>>> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) {
>>> 776: printStackWhenAccessFails = GetBooleanAction.
>>> 777:
On Wed, 20 Apr 2022 16:52:31 GMT, XenoAmess wrote:
>> @jmehrens what about this then?
>> I think it safe now(actually this mechanism is learned from Reader)
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add documents
On Fri, 20 May 2022 04:55:37 GMT, liach wrote:
> Simplify opcode handling, use `final` in `PrimitiveTypeInfo`, and replace the
> hash map with a simple lookup, similar to what's done in
> [JDK-8284880](https://bugs.openjdk.java.net/browse/JDK-8284880) (#8242)
On Fri, 20 May 2022 18:22:47 GMT, liach wrote:
>> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of
>> `Class.forName(String)`. `make test
>> TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new
>> `LazyInitializationTest` failing the eager initialization
On Tue, 17 May 2022 23:40:04 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Sat, 30 Apr 2022 17:00:03 GMT, Andrey Turbanov wrote:
> Instead of pair `HashMap.containsKey`/`HashMap.get` method calls, we can use
> single call `HashMap.getOrDefault`.
> It's faster and clearer.
Marked as reviewed by rriggs (Reviewer).
-
PR:
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
On Tue, 17 May 2022 01:19:30 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same
On Wed, 18 May 2022 16:28:02 GMT, Naoto Sato wrote:
> This is to incorporate the latest language subtag registry definition
> (version 2022-03-02) into JDK19.
Looks fine.
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8776
On Mon, 16 May 2022 15:54:25 GMT, Raffaello Giulietti
wrote:
>> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8286810: Use public
On Mon, 16 May 2022 14:48:43 GMT, Raffaello Giulietti
wrote:
> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
src/java.base/share/classes/jdk/internal/math/DoubleConsts.java line 28:
> 26: package jdk.internal.math;
> 27:
> 28: import static java.lang.Double.*;
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote:
> Applied required casts for the upcoming warning. Verified by cherry-picking
> Adam's patch.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8706
On Tue, 3 May 2022 21:35:48 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conve
On Fri, 13 May 2022 05:54:15 GMT, Alan Bateman wrote:
>> src/java.base/linux/classes/sun/nio/ch/EPollSelectorImpl.java line 128:
>>
>>> 126: // timed poll interrupted so need to adjust timeout
>>> 127: long adjust = System.nanoTime() - startTime;
>>> 128:
On Thu, 12 May 2022 16:01:50 GMT, Brian Burkhalter wrote:
>> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
>> indicate that `-1` is returned at the EOF of the last stream even if `len`
>> is zero.
>
> Brian Burkhalter has updated the pull request incrementally with
Updates to modules java.rmi and java.smartcardio to remove warnings about
lossy-conversions introduced by PR#8599.
Explicit casts are inserted where implicit casts occur.
8286393: Address possibly lossy conversions in java.rmi
8286388: Address possibly lossy conversions in java.smartcardio
On Tue, 10 May 2022 21:32:10 GMT, Roger Riggs wrote:
> PR#8599 8244681: proposes to add compiler warnings for possible lossy
> conversions
> From the CSR:
>
> "If the type of the right-hand operand of a compound assignment is not
> assignment compatible with the type
On Mon, 9 May 2022 12:30:19 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same
nd suggestions will inform similar updates to other OpenJDK modules).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Updated copyrights
Fixed cast style to add a space after cast, (where consistent with file style)
Improved code per
On Wed, 11 May 2022 15:52:59 GMT, Naoto Sato wrote:
>> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter
>> replaces on malformed/unmappable characters with replacements. However,
>> there was a code path that lacked to set the `CodingErrorAction.REPLACE` on
>> the
On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote:
>> That's good to know. I think the tricky part is mostly about keeping track
>> of all these disabled warnings, so they are not kept around longer than
>> necessary. And that needs coordination with all the subtasks of the umbrella
>>
nd suggestions will inform similar updates to other OpenJDK modules).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
remove stray file
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8642/files
- new: https://g
PR#8599 8244681: proposes to add compiler warnings for possible lossy
conversions
>From the CSR:
"If the type of the right-hand operand of a compound assignment is not
assignment compatible with the type of the variable, a cast is implied and
possible lossy conversion may silently occur. While
On Fri, 6 May 2022 20:03:35 GMT, Naoto Sato wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
>
On Fri, 6 May 2022 06:41:31 GMT, Matthias Baesken wrote:
>> The isMusl method had to be handled in
>> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java .
>> Additionally, the vm.musl predicate seem not to be available in the
>> langtools tests.
>
> Matthias Baesken has
On Wed, 4 May 2022 03:01:19 GMT, Ichiroh Takiguchi
wrote:
>> Do we need to verify the intermediate byte encoding? Could we simply compare
>> the text given to environ.put() in Start process and System.getenv() in
>> Verify process match?
>
> Hello @naotoj .
> I think if 2nd process' encoder
On Fri, 6 May 2022 14:23:00 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same
On Thu, 5 May 2022 15:30:15 GMT, Roger Riggs wrote:
> Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.
This pull request has now been integrated.
Changeset: 2f995c8d
Author: Roger Riggs
URL:
https://git.openjdk.java.net/jdk/com
On Thu, 5 May 2022 19:56:36 GMT, Roger Riggs wrote:
>> Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated cha
On Tue, 3 May 2022 16:17:00 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Default to UTF-8 if malloc fails
>
> src/java.base/windows/native/libjava/java_
On Thu, 5 May 2022 19:23:53 GMT, Daniel D. Daugherty wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
> Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains th
On Tue, 3 May 2022 18:55:52 GMT, Naoto Sato wrote:
>> Java runtime has been detecting the Windows system locale encoding using
>> `GetLocaleInfo(GetSystemDefaultLCID(), LOCALE_IDEFAULTANSICODEPAGE, ...)`,
>> but it returns the *legacy* ANSI code page value, e.g, 1252 for US-English.
>> In
On Thu, 5 May 2022 15:30:15 GMT, Roger Riggs wrote:
> Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/8557
On Thu, 5 May 2022 15:30:15 GMT, Roger Riggs wrote:
> Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.
The PR is not needed, the issue will be fixed by PR#8556.
-
PR: https://git.openjdk.java.net/jdk/pull/8557
On Thu, 5 May 2022 15:21:23 GMT, Matthias Baesken wrote:
> The isMusl method had to be handled in
> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java .
> Additionally, the vm.musl predicate seem not to be available in the langtools
> tests.
LGTM
-
Marked as
On Thu, 5 May 2022 15:41:44 GMT, Naoto Sato wrote:
>> Hello @naotoj .
>> If I just use `System.getProperty("sun.jnu.encoding")`, following testcases
>> were failed.
>>
>> java/lang/ProcessBuilder/SecurityManagerClinit.java
>> java/lang/ProcessHandle/PermissionTest.java
>>
>> Please give me
Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191.
-
Commit messages:
- 8286199: ProblemList jdk/jshell/ExternalEditorTest.java
- 8286195: ProblemList
test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
Changes:
On Thu, 5 May 2022 14:47:22 GMT, Roger Riggs wrote:
>> Hi Alan, thanks for the advice; do you think we can put it into the IGNORED
>> group ?
>> https://github.com/openjdk/jdk/blob/master/test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java#L53
>
> It
On Thu, 5 May 2022 14:15:30 GMT, Matthias Baesken wrote:
>> test/lib/jdk/test/lib/Platform.java line 192:
>>
>>> 190: }
>>> 191:
>>> 192: public static boolean isMusl() {
>>
>> I think this will need test/lib/TestMutuallyExclusivePlatformPredicates.java
>> to be updated too.
>
> Hi
On Thu, 5 May 2022 14:33:51 GMT, Roger Riggs wrote:
> Add a failing test library test to the ProblemList.
>
> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
This pull request has now been integrated.
Changeset: 7022543f
Author: Roger Riggs
URL:
Add a failing test library test to the ProblemList.
test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
-
Commit messages:
- 8286195: ProblemList
test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
Changes:
On Wed, 4 May 2022 11:37:09 GMT, Matthias Baesken wrote:
> There is one TestLibrary.bomb call in
> sun/rmi/runtime/Log/checkLogging/CheckLogging.java that is not passing the
> exception to bomb, that should be improved.
Marked as reviewed by rriggs (Reviewer).
-
PR:
On Wed, 27 Apr 2022 20:23:32 GMT, Naoto Sato wrote:
> Java runtime has been detecting the Windows system locale encoding using
> `GetLocaleInfo(GetSystemDefaultLCID(), LOCALE_IDEFAULTANSICODEPAGE, ...)`,
> but it returns the *legacy* ANSI code page value, e.g, 1252 for US-English.
> In order
On Fri, 29 Apr 2022 06:31:22 GMT, Andrey Turbanov wrote:
> `Map.containsKey` call is sometimes unnecessary, when it's known that Map
> doesn't contain `null` values.
> Instead we can just use Map.get and compare result with `null`.
> I found one of such place, where Map.containsKey calls could
On Sun, 1 May 2022 04:51:17 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same
On Fri, 29 Apr 2022 06:31:22 GMT, Andrey Turbanov wrote:
> `Map.containsKey` call is sometimes unnecessary, when it's known that Map
> doesn't contain `null` values.
> Instead we can just use Map.get and compare result with `null`.
> I found one of such place, where Map.containsKey calls could
On Tue, 26 Apr 2022 00:32:48 GMT, Naoto Sato wrote:
> This was caused by incorporating CLDR v39, which switched the Norwegian
> locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources
> from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly
>
On Sun, 24 Apr 2022 09:18:54 GMT, Ichiroh Takiguchi
wrote:
> On JDK19 with Linux ja_JP.eucjp locale,
> System.getenv() returns unexpected value if environment variable has Japanese
> EUC characters.
> It seems this issue happens because of JEP 400.
> Arguments for ProcessBuilder have same kind
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes
> where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like
> every second change would be a
On Wed, 27 Apr 2022 10:11:15 GMT, Kim Barrett wrote:
>> Please review this fix to test/jdk/java/lang/ref/ReferenceClone.java. It was
>> passing if CloneableReference::clone were to throw
>> CloneNotSupportedException.
>> That should be a failure.
>>
>> Testing:
>> Locally (linux-x64) verified
On Fri, 22 Apr 2022 14:35:14 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update FileUtils.java
Please change the
On Fri, 22 Apr 2022 14:35:14 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update FileUtils.java
If it is just for
On Fri, 22 Apr 2022 14:35:14 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update FileUtils.java
Can you elaborate
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote:
> This PR fixes a typo.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6942
On Wed, 20 Apr 2022 21:08:19 GMT, XenoAmess wrote:
>> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
>> https://github.com/openjdk/jdk/pull/8292/
>>
>> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
>> continue;
>>
On Wed, 20 Apr 2022 20:09:06 GMT, XenoAmess wrote:
>> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
>> https://github.com/openjdk/jdk/pull/8292/
>>
>> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
>> continue;
>>
On Wed, 20 Apr 2022 00:32:25 GMT, Brent Christian wrote:
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a
On Wed, 20 Apr 2022 00:32:25 GMT, Brent Christian wrote:
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a
On Tue, 19 Apr 2022 21:15:29 GMT, XenoAmess wrote:
> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
> https://github.com/openjdk/jdk/pull/8292/
>
> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
> continue;
> }
On Tue, 19 Apr 2022 21:15:29 GMT, XenoAmess wrote:
> some thoughts after watching 8285001: Simplify StringLatin1.regionMatches
> https://github.com/openjdk/jdk/pull/8292/
>
> if (Character.toLowerCase(u1) == Character.toLowerCase(u2)) {
> continue;
> }
On Wed, 20 Apr 2022 11:56:20 GMT, Jaikiran Pai wrote:
> I wonder if it should be removed from InputStream at the same time.
I took the presence of synchronized on those empty methods as a hint to
subclasses that they too should be synchronized.
-
PR:
On Tue, 19 Apr 2022 17:43:21 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
On Mon, 7 Mar 2022 18:47:17 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/time/chrono/IsoChronology.java line 689:
>>
>>> 687: */
>>> 688: @Override
>>> 689: public boolean isIsoBased() {
>>
>> Is this meant to be 'default'? The CSR indicated adding default methods.
On Fri, 15 Apr 2022 18:47:53 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Tue, 19 Apr 2022 08:50:09 GMT, Claes Redestad wrote:
> There is no pair of character values in the latin1 range (0-255) that will
> make the condition at line 401 in `StringLatin1.java` true, so this test can
> be removed.
>
> Added a test and a microbenchmark (which as expected sees a few
On Fri, 4 Mar 2022 23:20:21 GMT, Roger Riggs wrote:
> Quoting related changes in https://bugs.openjdk.java.net/browse/JDK-8250568
> modified the way that
> process builder recognized argument strings, causing some arguments to be
> doubly quoted and malformed.
>
> Proc
On Tue, 5 Apr 2022 16:39:33 GMT, Roger Riggs wrote:
>> Quoting related changes in https://bugs.openjdk.java.net/browse/JDK-8250568
>> modified the way that
>> process builder recognized argument strings, causing some arguments to be
>> doubly quoted and malformed.
>&
On Thu, 14 Apr 2022 18:29:21 GMT, Thomas Stuefe wrote:
>> ProcessHandle/OnExitTest is vulnerable to misconfigured systems that do not
>> reap zombies in a timely fashion.
>> [JDK-8284282](https://bugs.openjdk.java.net/browse/JDK-8284282) describes
>> this problem in detail.
>>
>> Until we
1 - 100 of 3175 matches
Mail list logo
