Re: JDK 15 RFR of JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations

2020-04-09 Thread Joe Darcy
Hi Pavel, On 4/9/2020 3:46 AM, Pavel Rappo wrote: http://cr.openjdk.java.net/~darcy/8225540.1/ I'm not an expert in this area, but AFAIK this looks good. A couple of nits. 1. The newly added text in the top-level doc comment for AnnotatedElement is missing some tags. It looks nice in

Re: JDK 15 RFR of JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations

2020-04-09 Thread Pavel Rappo
> http://cr.openjdk.java.net/~darcy/8225540.1/ I'm not an expert in this area, but AFAIK this looks good. A couple of nits. 1. The newly added text in the top-level doc comment for AnnotatedElement is missing some tags. It looks nice in source, but it won't be like that in the output. (For

JDK 15 RFR of JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations

2020-04-06 Thread Joe Darcy
Hello, Please review the changes to fix     JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations     http://cr.openjdk.java.net/~darcy/8225540.1/ This is a sibling fix to JDK-8225495 already done over in javax.lang.model. In brief, the