Re: Missing @since tags

2013-02-08 Thread Martin Buchholz
On Thu, Feb 7, 2013 at 9:58 PM, Joe Darcy joe.da...@oracle.com wrote: Hi Martin, IIRC, your @since checker was based on parsing javadoc output. If so, it (like BlenderRev) might have been rendered unusable out of the box due to the changes in javadoc output made since those tools were

Re: Missing @since tags

2013-02-07 Thread Chris Hegarty
and resurrect the script I wrote many years ago to find missing @since tags in a semi-automated fashion, and fix all of the jdk8 javadocs. On Wed, Feb 6, 2013 at 2:10 PM, Paul Benedict pbened...@apache.org wrote: This is very minor. Browsing the jdk8b75 javadoc, I noticed these classes are missing

Re: Missing @since tags

2013-02-07 Thread Martin Buchholz
On Thu, Feb 7, 2013 at 8:49 AM, Chris Hegarty chris.hega...@oracle.comwrote: Martin, I have finally located the script, findMissingSince ;-) I will run it once I have a clean, up to date, jdk8 build. I think it may be a candidate to propose to add to the common scripts in the top-level repo.

Re: Missing @since tags

2013-02-07 Thread Martin Buchholz
On Thu, Feb 7, 2013 at 9:49 AM, Alan Bateman alan.bate...@oracle.comwrote: On 07/02/2013 17:40, Martin Buchholz wrote: Alternatively, maybe this is a job for an annotation processor. IIRC, we considered that 6 years ago. It might be possible, but consider that you need to diff multiple jdk

Re: Missing @since tags

2013-02-07 Thread Martin Buchholz
JDiff hasn't been updated since 2008. I would be surprised if you could get it to work on jdk8 vs. jdk7 without significant work. But the key thing is to use a tool, any tool, since history has shown it is very easy for engineers to forget to add the necessary @since tags. On Thu, Feb 7, 2013

Re: Missing @since tags

2013-02-07 Thread Joe Darcy
Hi Martin, On 02/07/2013 10:29 AM, Martin Buchholz wrote: On Thu, Feb 7, 2013 at 9:49 AM, Alan Bateman alan.bate...@oracle.comwrote: On 07/02/2013 17:40, Martin Buchholz wrote: Alternatively, maybe this is a job for an annotation processor. IIRC, we considered that 6 years ago. It might

Missing @since tags

2013-02-06 Thread Paul Benedict
This is very minor. Browsing the jdk8b75 javadoc, I noticed these classes are missing their @since tags. ProcessBuilder.Redirect.Type Formatter.BigDecimalLayoutForm Paul

Re: Missing @since tags

2013-02-06 Thread Martin Buchholz
Please find and resurrect the script I wrote many years ago to find missing @since tags in a semi-automated fashion, and fix all of the jdk8 javadocs. On Wed, Feb 6, 2013 at 2:10 PM, Paul Benedict pbened...@apache.org wrote: This is very minor. Browsing the jdk8b75 javadoc, I noticed