Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

That’d be fine. Mandy > On Sep 22, 2016, at 11:43 AM, Sean Coffey wrote: > > Thanks Mandy. I pushed this change earlier today. If BasicImageReader.java is > being edited again in the near future, we might be able to make your > suggested edits then. > > regards, >

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Thanks Mandy. I pushed this change earlier today. If BasicImageReader.java is being edited again in the near future, we might be able to make your suggested edits then. regards, Sean. On 22/09/2016 19:23, Mandy Chung wrote: On Sep 21, 2016, at 8:56 AM, Seán Coffey

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

> On Sep 21, 2016, at 8:56 AM, Seán Coffey wrote: > > Resurrecting this old review thread. After some internal discussion, I've > dropped the minor edit that was made in StackTraceElementCompositeData. It > could be noisy data for exception purposes. I've corrected the

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

On 22/09/2016 14:14, Alan Bateman wrote: This looks okay to me. You may want to change the bug message to drop "thrown by jigsaw code" as most of the changed files are jimage or other areas. Thanks Alan - Yes - will correct that before I push then. regards, Sean.

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

On 21/09/2016 08:56, Seán Coffey wrote: Resurrecting this old review thread. After some internal discussion, I've dropped the minor edit that was made in StackTraceElementCompositeData. It could be noisy data for exception purposes. I've corrected the other issues raised by Alan and Jim has

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Resurrecting this old review thread. After some internal discussion, I've dropped the minor edit that was made in StackTraceElementCompositeData. It could be noisy data for exception purposes. I've corrected the other issues raised by Alan and Jim has long pushed the changes mentioned below.

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

On 01/06/16 10:21, Alan Bateman wrote: On 31/05/2016 18:57, Seán Coffey wrote: new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832.v2/webrev/ Also in JprtPath.checkPath then I assume path.getClass() is enough as the toString is specified to return a useful string. In

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

On 31/05/2016 18:57, Seán Coffey wrote: new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832.v2/webrev/ Also in JprtPath.checkPath then I assume path.getClass() is enough as the toString is specified to return a useful string. In JrtPath then "nul" has been renamed to "null".

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Thanks Paul. Best to have consistent formatting. Webrev updated in place. On the beginning quote observation, I wasn't too such myself. Presumably a typo. I've removed for now. Regards, Sean. On 31/05/2016 19:48, Paul Benedict wrote: Hi Sean, I just have a few minor comments. Nearly all

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Hi Sean, I just have a few minor comments. Nearly all the new messages follow the message/colon/space/details format. There are a few missing the space between the colon and details: *) ImageHeader: "jimage header not the correct size:" *) JrtPath throw new ProviderMismatchException("path

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

I've gone ahead with a trimmed down webrev as per Alan's request. new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832.v2/webrev/ Regards, Sean. On 16/05/2016 15:10, Alan Bateman wrote: On 16/05/2016 14:45, Seán Coffey wrote: On 16/05/16 13:51, Alan Bateman wrote: On

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

On 16/05/2016 14:45, Seán Coffey wrote: On 16/05/16 13:51, Alan Bateman wrote: On 16/05/2016 13:44, Seán Coffey wrote: Some extra capturing of context in exception handling. I've re-based the original suggested patch and added some minor edits.

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

On 16/05/16 13:51, Alan Bateman wrote: On 16/05/2016 13:44, Seán Coffey wrote: Some extra capturing of context in exception handling. I've re-based the original suggested patch and added some minor edits. https://bugs.openjdk.java.net/browse/JDK-8151832 webrev :

Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

On 16/05/2016 13:44, Seán Coffey wrote: Some extra capturing of context in exception handling. I've re-based the original suggested patch and added some minor edits. https://bugs.openjdk.java.net/browse/JDK-8151832 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832/webrev/index.html

RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Some extra capturing of context in exception handling. I've re-based the original suggested patch and added some minor edits. https://bugs.openjdk.java.net/browse/JDK-8151832 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832/webrev/index.html -- Regards, Sean.