Hi Kumar,
So long as those nashorn tests (jtreg tests under
$jdk/test/javax/script, $jdk/sun/tools/jrunscript, $nashorn/test and
nashorn ant tests - $nashorn/make - ant test) run fine, we've no
objections from nashorn team.
Thanks
-Sundar
On Tuesday 30 April 2013 03:55 AM, Kumar Srinivasan
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to implement Iterator
directly.
It looks the SmallSet needs more discussion.. barring that anyone else
have any other
concerns
On Apr 26, 2013, at 1:26 AM, Kumar Srinivasan kumar.x.sriniva...@oracle.com
wrote:
On 4/25/2013 3:53 PM, Mike Duigou wrote:
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to
On 04/26/2013 01:43 PM, Paul Sandoz wrote:
On Apr 26, 2013, at 1:26 AM, Kumar Srinivasan kumar.x.sriniva...@oracle.com
wrote:
On 4/25/2013 3:53 PM, Mike Duigou wrote:
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see
On Apr 26, 2013, at 3:25 PM, Remi Forax fo...@univ-mlv.fr wrote:
On 04/26/2013 01:43 PM, Paul Sandoz wrote:
On Apr 26, 2013, at 1:26 AM, Kumar Srinivasan
kumar.x.sriniva...@oracle.com wrote:
On 4/25/2013 3:53 PM, Mike Duigou wrote:
The restyling changes obfustucated things a bit but I
How many years ago was this done? Hasn't the hardware reality changed since
then? What might have been a justifiable crime then may just be a crime now.
On Apr 26, 2013, at 10:12 AM, Paul Sandoz wrote:
On Apr 26, 2013, at 3:25 PM, Remi Forax fo...@univ-mlv.fr wrote:
On 04/26/2013
Brian
For any individual case, there is always an argument that adding a couple of
extra classes won't matter, but if that is the answer to every question, the
result is something slow and bloated. Also, what frequently happens is that
hardware advances are used to deliver lower cost rather
Hello,
Please review changes which essentially contains asm5_future in asm's
mainline
repository, I have tested this patch with Nashorn (so has Sundar), as
well as Lambda's
usage.
Fixes that I know of:
1. supports v52.0 class files and JSR 308/Type Annotations changes
Thanks to Remi
2.
Here is the webrev:
http://cr.openjdk.java.net/~ksrini/8013225/webrev.0/
Thanks
Kumar
Hello,
Please review changes which essentially contains asm5_future in asm's
mainline
repository, I have tested this patch with Nashorn (so has Sundar), as
well as Lambda's
usage.
Fixes that I know of:
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to implement Iterator
directly.
Looks OK. The testing, which you have done, is the important qualifier for this
change.
Mike
On Apr
On 4/25/2013 3:53 PM, Mike Duigou wrote:
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to implement Iterator
directly.
Remi, Paul and Brian discussed that and struck a deal,
11 matches
Mail list logo
