Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-26 Thread Alan Bateman
On 25/04/2013 21:53, Lance Andersen - Oracle wrote: http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that were pointed out and also fixes a couple javadoc warnings This looks okay to me. One small suggestion for DriverAction and the first statement where it reads

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-26 Thread Lance Andersen - Oracle
On Apr 26, 2013, at 8:35 AM, Alan Bateman wrote: On 25/04/2013 21:53, Lance Andersen - Oracle wrote: http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that were pointed out and also fixes a couple javadoc warnings This looks okay to me. One small suggestion for

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-25 Thread Lance Andersen - Oracle
http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that were pointed out and also fixes a couple javadoc warnings Best, Lance On Apr 22, 2013, at 11:17 AM, Lance Andersen - Oracle wrote: On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote: On 21/04/2013 12:45, Lance

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-22 Thread Alan Bateman
On 21/04/2013 12:45, Lance Andersen - Oracle wrote: : DriverManager - one point that isn't covered in the spec is whether the DriverAction's deregister is invoked before or after it is deregistered. This distinction is probably only interesting for the case that the deregister method fails

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-22 Thread Lance Andersen - Oracle
On Apr 21, 2013, at 11:09 AM, Ulf Zibis wrote: Minor nits: DriverManager line 349: I would break the line right after the opening parenthesis. I did not change this as other methods break after the 1st parameter (getConnection is one example) so I would prefer to keep it consistent (or as

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-22 Thread Lance Andersen - Oracle
On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote: On 21/04/2013 12:45, Lance Andersen - Oracle wrote: : DriverManager - one point that isn't covered in the spec is whether the DriverAction's deregister is invoked before or after it is deregistered. This distinction is probably only

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-21 Thread Lance Andersen - Oracle
Thank you for the feedback Alan, Please see below and the webrev http://cr.openjdk.java.net/~lancea/8010416/webrev.02/ On Apr 21, 2013, at 4:34 AM, Alan Bateman wrote: On 19/04/2013 18:34, Lance Andersen - Oracle wrote: Hi, We have been asked by a few JDBC driver vendors to allow a JDBC

review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-19 Thread Lance Andersen - Oracle
Hi, We have been asked by a few JDBC driver vendors to allow a JDBC driver to be notified when/if it was deregistered via DriverManager.deregisterDriver if desired. The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.01 Best Lance Lance Andersen| Principal