The build change looks fine. The new build will not need any changes.
/Erik
On 2013-02-06 04:51, Henry Jen wrote:
Hi,
This is an update on previous reviewed version, there are two new method
introduced for Comparators to convert a Comparator into a BinaryOperator
and corresponding test cases.
I don't think Thread belongs in there. ;-)
David
On 6/02/2013 8:16 AM, Joe Darcy wrote:
Hello,
As a follow-up to adding the FunctionalInterface annotation type to the
platform, the time has come to annotate JDK classes with the annotation.
I ran an annotation processor over the sources in
On 05/02/2013 22:16, Joe Darcy wrote:
:
Webrev:
http://cr.openjdk.java.net/~darcy/8005623.0/
This review is both to cover the addition of @FunctionalInterface to
the types above and also to query if the annotation should be included
in any of the other types below under the same bug.
On 5 February 2013 22:16, Joe Darcy joe.da...@oracle.com wrote:
This review is both to cover the addition of @FunctionalInterface to the
types above and also to query if the annotation should be included in any of
the other types below under the same bug. The sub-areas I have not
annotated
Not Thread itself, but the UncaughtExceptionHandler interface declared
inside thread :-) (I wasn't positive this was meaningfully a functional
interface though.)
-Joe
On 2/6/2013 12:42 AM, David Holmes wrote:
I don't think Thread belongs in there. ;-)
David
On 6/02/2013 8:16 AM, Joe Darcy
Hi John,
On 6/02/2013 9:49 AM, John Zavgren wrote:
Greetings:
I modified the code in
src/windows/native/java/io/WinNTFileSystem_md.c
so that it checks the return value of realloc() and frees memory when there is
an error.
The webrev image of this change is visible at:
PS.
if(resultTemp == NULL) {
Need space after if
David
On 6/02/2013 9:49 AM, John Zavgren wrote:
Greetings:
I modified the code in
src/windows/native/java/io/WinNTFileSystem_md.c
so that it checks the return value of realloc() and frees memory when there is
an error.
The webrev image of
Thank for the review. comments inline...
On 06/02/2013 01:53, David Holmes wrote:
204 # Terminate with exit 0 only if all subprocesses were successful
205 ec=0
206 if [ -d ${tmp} ]; then
207 for rc in `ls ${tmp}/*.pid.rc` ; do
I don't think you need to subshell an invocation of ls, simply do
On 05/02/2013 23:49, John Zavgren wrote:
Greetings:
I modified the code in
src/windows/native/java/io/WinNTFileSystem_md.c
so that it checks the return value of realloc() and frees memory when there is
an error.
The webrev image of this change is visible at:
Thanks Chris. I missed a couple of obvious things there. :(
One thing related to the repo name in the $(rc) variable. Somewhere the
repo name gets mangled:
+ echo jdk/src/closed
+ sed -e s@./@@ -e s@/@_@g
+ repopidfile=jdsrc_closed
the / to _ doesn't work for the first / (not part of your
On 6/02/2013 8:18 PM, Alan Bateman wrote:
On 05/02/2013 23:49, John Zavgren wrote:
Greetings:
I modified the code in
src/windows/native/java/io/WinNTFileSystem_md.c
so that it checks the return value of realloc() and frees memory when
there is an error.
The webrev image of this change is
On 06/02/2013 10:24, David Holmes wrote:
Thanks Chris. I missed a couple of obvious things there. :(
One thing related to the repo name in the $(rc) variable. Somewhere the
repo name gets mangled:
+ echo jdk/src/closed
+ sed -e s@./@@ -e s@/@_@g
+ repopidfile=jdsrc_closed
the / to _ doesn't
Changeset: 8dd61906da5f
Author:chegar
Date: 2013-02-06 11:36 +
URL: http://hg.openjdk.java.net/jdk8/tl/rev/8dd61906da5f
8007625: race with nested repos in /common/bin/hgforest.sh
Reviewed-by: dholmes, ohair, ohrstrom
! common/bin/hgforest.sh
! get_source.sh
On 06/02/2013 09:20, Joe Darcy wrote:
Not Thread itself,
This was my first reaction too :-)
but the UncaughtExceptionHandler interface declared
inside thread :-) (I wasn't positive this was meaningfully a functional
interface though.)
Maybe, but is does fit the description of a functional
Thank you again for the feedback Ulf
On Feb 5, 2013, at 7:22 PM, Ulf Zibis wrote:
Am 06.02.2013 00:54, schrieb Lance Andersen - Oracle:
I can change that text and will do so before i put back.
fine!
I am going to change the message from
readObject not implemented
to method
Changeset: 0e7d5dd84fdf
Author:dsamersoff
Date: 2013-02-06 16:53 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e7d5dd84fdf
8007277: JDK-8002048 testcase fails to compile
Summary: sun.* classes is not included to ct.sym file and symbol file have to
be ignored
Reviewed-by:
Changeset: 1df20330f6bd
Author:mcimadamore
Date: 2013-02-06 14:03 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1df20330f6bd
8007463: Cleanup inference related classes
Summary: Make Infer.InferenceContext an inner class; adjust bound replacement
logic in
Am 06.02.2013 13:15, schrieb Lance Andersen - Oracle:
I am going to change the message from
readObject not implemented
to method readObject(ClassT) not implemented
There is 1 % missing to be perfect: method T T readObject(ClassT type) not
implemented ;-)
I was also thinking about this 100
Alan:
I like your change, but I think the free(result) statement would need to be
eliminated, otherwise the block a few lines later:
/* Unable to get final path. */
if(len == 0 result != NULL) {
free(result);
result = NULL;
}
would cause result to be freed twice.
br- Original
Alan:
I apologize... I read the code again and I don't see any issues with your
change.
John
- Original Message -
From: john.zavg...@oracle.com
To: alan.bate...@oracle.com
Cc: core-libs-dev@openjdk.java.net
Sent: Wednesday, February 6, 2013 9:57:03 AM GMT -05:00 US/Canada Eastern
On 06/02/2013 14:57, John Zavgren wrote:
Alan: I like your change, but I think the free(result) statement would
need to be eliminated, otherwise the block a few lines later: /*
Unable to get final path. */ if(len == 0 result != NULL) {
free(result); result = NULL; } would cause result to be
On Feb 6, 2013, at 9:26 AM, Ulf Zibis wrote:
Am 06.02.2013 13:15, schrieb Lance Andersen - Oracle:
I am going to change the message from
readObject not implemented
to method readObject(ClassT) not implemented
There is 1 % missing to be perfect: method T T readObject(ClassT type)
On 05/02/2013 20:10, Mike Duigou wrote:
On Feb 4 2013, at 08:33 , Alan Bateman wrote:
On 04/02/2013 16:02, Mike Duigou wrote:
:
If so then I think we have to careful because -concurrency means a lot of
virtual memory and I'm not convinced that we limit it via -vmoption in
jdk/test/Makefile
Alan,
thanks for the review!
// Katja
On 02/05/2013 12:54 PM, Alan Bateman wrote:
On 05/02/2013 10:51, Yekaterina Kantserova wrote:
On 02/04/2013 02:18 PM, Alan Bateman wrote:
On 04/02/2013 11:03, Yekaterina Kantserova wrote:
But JDKToolFinder.getJDKTool is used even for finding java,
Changeset: 153d20d0cac5
Author:jjg
Date: 2013-02-06 07:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/153d20d0cac5
8007566: DocLint too aggressive with not allowed here: p
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/doclint/Checker.java
+
On 02/04/2013 10:51 AM, Alan Bateman wrote:
On 04/02/2013 06:38, Weijun Wang wrote:
Need an equivalence of the geteuid() function that returns the
effective user ID of the calling process.
There isn't an API for this.
And Hotspot really shouldn't be used from processes with EUID != UID.
On Feb 6, 10:04am, chris.hega...@oracle.com (Chris Hegarty) wrote:
-- Subject: Re: RFR: race with nested repos in hgforest.sh
| Yes this is better, but the quotes are incorrect. It should simply be
|for rc in ${tmp}/*.pid.rc ; do
This will break if there is no match.
christos
fwiw, I've always found the attempts by hg_forest to process things in
parallel cause me more pain than it's worth.
Marching through the repo locations serially in order might take a few
moments longer elapsed time, but creates instantly understandable
status / output / log and points for
Neil,
I think a wider discussion needs to be had around how this script should
operate, but I didn't want this specific issue to get side tracked by that.
The hgforest script already clones/pulls in parallel, the problem here
is that it just doesn't work with older versions of hg. And worse
On 6 Feb 2013, at 16:26, chris...@zoulas.com wrote:
On Feb 6, 10:04am, chris.hega...@oracle.com (Chris Hegarty) wrote:
-- Subject: Re: RFR: race with nested repos in hgforest.sh
| Yes this is better, but the quotes are incorrect. It should simply be
|for rc in ${tmp}/*.pid.rc ; do
Changeset: 168dd033604a
Author:mduigou
Date: 2013-02-06 11:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/168dd033604a
8004726: Link bug ids to jbs rather than monaco.
Reviewed-by: ohair, chegar, katleman
! make/scripts/webrev.ksh
Changeset: 1574fa3df1c0
Author:lancea
Date: 2013-02-06 14:15 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1574fa3df1c0
8006505: additional changes for JSR 310 support
Reviewed-by: naoto, ulfzibis
! src/share/classes/java/sql/JDBCType.java
!
On 2/6/2013 12:54 AM, Alan Bateman wrote:
On 05/02/2013 22:16, Joe Darcy wrote:
:
Webrev:
http://cr.openjdk.java.net/~darcy/8005623.0/
This review is both to cover the addition of @FunctionalInterface to
the types above and also to query if the annotation should be
included in any of
This is very minor. Browsing the jdk8b75 javadoc, I noticed these classes
are missing their @since tags.
ProcessBuilder.Redirect.Type
Formatter.BigDecimalLayoutForm
Paul
Please find and resurrect the script I wrote many years ago to find missing
@since tags in a semi-automated fashion, and fix all of the jdk8 javadocs.
On Wed, Feb 6, 2013 at 2:10 PM, Paul Benedict pbened...@apache.org wrote:
This is very minor. Browsing the jdk8b75 javadoc, I noticed these
On 5 February 2013 09:09, Paul Sandoz paul.san...@oracle.com wrote:
This is one of those unfortunate cases where a bug can become a feature.
I *really* don't see how.
The method name is absolutely clear about its purpose. Strip trailing
zeros. Anyone relying on it not stripping zeroes for zero
Following up, please review the backward compatiblitiy support in:
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/useZip64For64kEntries/
(ideally users would have even more control via the API, but I ain't gonna
try to touch that)
Pushed into tl8. Thanks for the reviews!
On Mon, Jan 28, 2013 at 3:36 AM, Alan Bateman alan.bate...@oracle.comwrote:
On 26/01/2013 17:14, Martin Buchholz wrote:
:
Following up on this, I have a simple webrev:
Changeset: 2f1505c49e79
Author:martin
Date: 2013-02-06 17:59 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f1505c49e79
8006995: java launcher fails to open executable JAR 2GB
Summary: Use O_LARGEFILE consistently when opening jar files
Reviewed-by: alanb, sherman
!
On 02/06/2013 11:19 AM, Joe Darcy wrote:
On 2/6/2013 12:54 AM, Alan Bateman wrote:
On 05/02/2013 22:16, Joe Darcy wrote:
:
Webrev:
http://cr.openjdk.java.net/~darcy/8005623.0/
This review is both to cover the addition of @FunctionalInterface to
the types above and also to query if the
Hi Eric,
The code changes look okay, but some tests for isImplicit should be
written as soon as there is compiler support for the feature.
Cheers,
-Joe
On 02/05/2013 12:40 PM, Eric McCorkle wrote:
Clarification here: the issue's title is a bit more narrow than the
scope of the fix. It
Stephen, In your case(s) would the workaround fail to work if the bug
was fixed?
Working around a bug is quite different to taking advantage of the buggy
behaviour. If fixing the bug would break code that works around it that
can be seen as a problem, while breaking code that relies on the
42 matches
Mail list logo
