Changeset: ea000904db62
Author:alundblad
Date: 2013-10-08 15:33 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea000904db62
8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees
Summary: Fixed precedence and associativity issues with pretty printing of
On 10/08/2013 08:08 PM, Mike Duigou wrote:
This seems to contradict the main documentation for these methods.
The general guidance is still valid, bug we want to allow algorithms
with better worst-case behavior than simple summation.
(I didn't think it would be helpful for most readers to
On 10/9/13 2:39 AM, Mandy Chung wrote:
This fixes Level.parse to return the custom Level instance.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8026027/webrev.00/
When a custom Level is created, a mirrored level instance (containing
the same value as the custom Level) is created
Alan, Rob, Martin,
Would you please help review the backport? I see that you were the
reviewers for the master fix.
I need a review for the backport, since the patch couldn't get applied
cleanly.
Here are the changes I had to make:
- I had to manually replace
Alan Bateman wrote:
On 25/05/2013 12:35, Alan Bateman wrote:
On 24/05/2013 19:14, Martin Buchholz wrote:
:
Alan, you're telling everyone there's no need for Thread.stop, but
you are replacing usages in tests with calls to Unsafe, which is not
available to normal code. So you have a kind of
On 10/09/2013 12:05 AM, Brian Burkhalter wrote:
Based on previous comments by Aleksey and Paul I created this test
http://cr.openjdk.java.net/~bpb/7189139/PrimeTest.java
and ran it with the list of primes supplied by Aleksey, N=6000, and
certainty=100. This is the output:
---
Hello all!
The MemLeakTest had been added with the fix for 8022584.
Since that, the test was reported to fail intermittently, even though
the leak was eliminated.
I couldn't ever reproduce the failure even on the machines where the
failure was detected.
Here are the changes I propose:
-
On 10/8/2013 1:06 PM, Alan Bateman wrote:
On 08/10/2013 18:19, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8024704: Improve API documentation of ClassLoader and ServiceLoader
with respect to enumeration of resources.
https://bugs.openjdk.java.net/browse/JDK-8024704
This is
This looks like one for the net-dev list.
On 09/10/2013 09:10, Ivan Gerasimov wrote:
Hello all!
The MemLeakTest had been added with the fix for 8022584.
Since that, the test was reported to fail intermittently, even though
the leak was eliminated.
I couldn't ever reproduce the failure even
Changeset: 2ea162b2ff55
Author:alanb
Date: 2013-10-09 09:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55
8008662: Add @jdk.Exported to JDK-specific/exported APIs
Reviewed-by: chegar, vinnie, dfuchs, mchung, mullan, darcy
!
Yes, right, thanks!
Just resend it to the right list
On 09.10.2013 12:22, Alan Bateman wrote:
This looks like one for the net-dev list.
On 09/10/2013 09:10, Ivan Gerasimov wrote:
Hello all!
The MemLeakTest had been added with the fix for 8022584.
Since that, the test was reported to fail
This latest webrev looks good to me. If you haven't already got a
sponsor, then I would be happy to sponsor this for you.
Since there are minor spec clarifications, to document long standing
behavior, then a CCC request will need to be submitted, and approved,
before integration.
-Chris.
On 08/10/2013 21:50, Brian Burkhalter wrote:
http://cr.openjdk.java.net/~bpb/8016252/webrev.3/
This looks good to me.
If you haven't already got a sponsor, then I would be happy to sponsor
this for you.
-Chris.
Hi,
Thank you all for the nice valuable feedback!
I have updated the webrev with Alan's correction.
The ClassLoader api note now reads:
When overriding this method it is recommended that an
implementation ensures that ...
(and also fixed indentation)
Hi Henry,
On 10/8/2013 10:57 PM, Henry Jen wrote:
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
ProxyClassesDumper looks simpler after moving the path validation to the
static factory method.
One minor comment:
ProxyClassesDumper.getInstance
On 08/10/2013 20:55, Brent Christian wrote:
I've beefed up the test case, as suggested by Alan and Paul. It tries
removing at the start, middle, and end of the iteration.
FWIW, all but one of the test scenarios pass even without the fix.
The failing case is:
checkDescItrRmMid(m.keySet(),
Daniel,
Thanks for the review.
On 10/9/2013 12:38 AM, Daniel Fuchs wrote:
This looks good - but I think you could move the changes line 554-562 and
put them back inside the KnownLevel constructor where they were before.
This would allow you to keep mirroredLevel final.
That's right. I
On 08/10/2013 21:50, Brian Burkhalter wrote:
I have updated the webrev accordingly
http://cr.openjdk.java.net/~bpb/8016252/webrev.3/
http://cr.openjdk.java.net/%7Ebpb/8016252/webrev.3/
This looks good, I think this gets us to where we wanted to be.
:
I skimmed over the test but it doesn't
See
https://bugs.openjdk.java.net/browse/JDK-8026127
https://bugs.openjdk.java.net/browse/JDK-8026128
Stephen
On 8 October 2013 21:33, Xueming Shen xueming.s...@oracle.com wrote:
The 100 in sample really means a big enough buffer here for simple use
case, not
necessarily means a fixed size'
Hi Mandy,
This looks good!
(not a reviewer)
-- daniel
On 10/9/13 12:29 PM, Mandy Chung wrote:
Daniel,
Thanks for the review.
On 10/9/2013 12:38 AM, Daniel Fuchs wrote:
This looks good - but I think you could move the changes line 554-562 and
put them back inside the KnownLevel constructor
On 09/10/2013 10:44, Daniel Fuchs wrote:
Hi,
Thank you all for the nice valuable feedback!
I have updated the webrev with Alan's correction.
The ClassLoader api note now reads:
When overriding this method it is recommended that an
implementation ensures that ...
(and also fixed
Changeset: 91a752e3d50b
Author:vinnie
Date: 2013-10-09 10:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91a752e3d50b
8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class
Reviewed-by: mullan, weijun
+
On 09/10/2013 08:47, Dr Heinz M. Kabutz wrote:
I noticed the other day when using Java 8 that Thread.stop(Throwable)
was throwing an UOE. Unfortunately I missed the discussion in May
amongst the thousands of other important JDK emails. Thus I presume
that nothing I might have to say on the
On 09/10/2013 04:38, Mike Duigou wrote:
Hello all;
Based upon feedback from the JavaOne Hands-On-Lab and other sources the 335 EG
has decided to rename the two substream methods in the Streams interfaces to
skip and slice.
Webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8025910/0/webrev/
Changeset: 0be3f1820e8b
Author:jlahoda
Date: 2013-10-09 13:06 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0be3f1820e8b
8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...)
Summary: Should not generate non-public $assertionsDisabled field into
This test has been failing (very intermittently) for some time. It was
assumed to be a HotSpot issue on SPARC but more recently it has been
duplicated on Linux x64 too. David Simms has notes in the bug [1] from
this instrumentation and analysis, and Doug has pushed a fix to his CVS
that
On Oct 8, 2013, at 10:05 PM, Brian Burkhalter brian.burkhal...@oracle.com
wrote:
On Oct 4, 2013, at 1:33 AM, Paul Sandoz wrote:
On Oct 4, 2013, at 9:18 AM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 10/04/2013 03:34 AM, Brian Burkhalter wrote:
Here is an alternative
On Oct 9, 2013, at 5:38 AM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
Based upon feedback from the JavaOne Hands-On-Lab and other sources the 335
EG has decided to rename the two substream methods in the Streams interfaces
to skip and slice.
Webrev:
On 09/10/2013 11:41, Daniel Fuchs wrote:
Hi Mandy,
This looks good!
+1
-Chris.
(not a reviewer)
-- daniel
On 10/9/13 12:29 PM, Mandy Chung wrote:
Daniel,
Thanks for the review.
On 10/9/2013 12:38 AM, Daniel Fuchs wrote:
This looks good - but I think you could move the changes line
Changeset: 8d29733ad609
Author:sundar
Date: 2013-10-09 10:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d29733ad609
8026112: Function(with(x ? 1e81 : (x2.constructor = 0.1)){}) throws
AssertionError: double is not compatible with object
Reviewed-by: lagergren,
Changeset: 1cd20806fd5c
Author:psandoz
Date: 2013-10-09 15:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1cd20806fd5c
8020061: Clarify reporting characteristics between splits
Reviewed-by: alanb, chegar
! src/share/classes/java/util/Spliterator.java
Changeset: cf6e39cfdf50
Author:mchung
Date: 2013-10-09 06:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf6e39cfdf50
8026027: Level.parse should return the custom Level instance instead of the
mirrored Level
Reviewed-by: dfuchs, chegar
!
Please Review a locale sensitive test correction:
The API under test is based on Locale.getDefault(Locale.Category.FORMAT)
and the test data should be using the same Locale.
The failure was seen in locale: ar_EG with Locale.Category.FORMAT=ar_SA
webrev:
Ping... any Reviewer...
Thanks
On 10/4/2013 3:37 PM, roger riggs wrote:
Hi,
Please review these small improvements in messages resulting from
parsing date and time errors and corresponding tests.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-better-msg-8025718/
JBS:
+1
On Oct 9, 2013, at 10:36 AM, roger riggs wrote:
Please Review a locale sensitive test correction:
The API under test is based on Locale.getDefault(Locale.Category.FORMAT)
and the test data should be using the same Locale.
The failure was seen in locale: ar_EG with
+1
On Oct 9, 2013, at 10:38 AM, roger riggs wrote:
Ping... any Reviewer...
Thanks
On 10/4/2013 3:37 PM, roger riggs wrote:
Hi,
Please review these small improvements in messages resulting from
parsing date and time errors and corresponding tests.
Webrev:
Changeset: e3b70e601c1c
Author:rriggs
Date: 2013-10-09 11:02 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3b70e601c1c
8024612: java/time/tck/java/time/format/TCKDateTimeFormatters.java failed
Summary: The test should be using the Locale.Category.FORMAT to verify the test
Changeset: c070001c4f60
Author:henryjen
Date: 2013-10-09 09:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c070001c4f60
8023524: Mechanism to dump generated lambda classes / log lambda code generation
Reviewed-by: plevart, mchung, forax, jjb
Contributed-by:
I noticed recently that the JDK8 JVM was very slow starting on systems where
the JRE is on a high-latency, remote file system. I tracked this down to the
reading of tzdb.dat. In java/time/zone/TzdbZoneRulesProvider.java and
sun/util/calendar/ZoneInfoFile.java the tzdb.dat file is read using a
Thanks Mandy, and all others have reviewed and commented.
Cheers,
Henry
On 10/09/2013 02:47 AM, Mandy Chung wrote:
Hi Henry,
On 10/8/2013 10:57 PM, Henry Jen wrote:
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
ProxyClassesDumper looks
On 10/9/13 3:12 AM, Alan Bateman wrote:
On 08/10/2013 20:55, Brent Christian wrote:
I've beefed up the test case
Thanks for the update and expanding the test. I skimmed over the new
test cases and they looks good.
Thanks.
There are a few commented out cases and
it's not clear why this
Hi,
These resource bundles in JAXP were refactored due to request by WPTG.
Now that the WPTG tool has been approved to support the original format,
I'm reverting the previous change back to the original format:
http://cr.openjdk.java.net/~joehw/jdk8/8003262/webrev/
Thanks,
Joe
Hi Thomas,
Thanks for the report and suggestion, I filed an issue for it.
https://bugs.openjdk.java.net/browse/JDK-8026198
Roger
On 10/9/2013 1:08 PM, Salter, Thomas A wrote:
I noticed recently that the JDK8 JVM was very slow starting on systems where
the JRE is on a high-latency, remote
Hi Joe,
I don't know what was the original format but these changes
look reasonable.
best regards,
-- daniel (not a reviewer)
On 10/9/13 7:35 PM, huizhe wang wrote:
Hi,
These resource bundles in JAXP were refactored due to request by WPTG.
Now that the WPTG tool has been approved to support
+1
On Oct 9, 2013, at 1:35 PM, huizhe wang wrote:
Hi,
These resource bundles in JAXP were refactored due to request by WPTG. Now
that the WPTG tool has been approved to support the original format, I'm
reverting the previous change back to the original format:
May I suggest rather:
try (
File file = new File(libDir, tzdb.dat);
FileInputStream fis = new FileInputStream(file);
BufferedInputStream bis = new BufferedInputStream(fis, 32000);
DataInputStream dis = new DataInputStream(bis);
) {
...
That way, the resources are closed in
On Oct 9 2013, at 10:33 , Brent Christian wrote:
On 10/9/13 3:12 AM, Alan Bateman wrote:
On 08/10/2013 20:55, Brent Christian wrote:
I've beefed up the test case
Thanks for the update and expanding the test. I skimmed over the new
test cases and they looks good.
Thanks.
There are
On Oct 8, 2013, at 2:43 AM, Alan Bateman wrote:
Thanks for the previous comments. My feeling at this point is to do one of
two things:
A) defer to something after JDK 8, or
B) on EAI_AGAIN do not retry but set the cause of the UAE to new
SomeException(gai_strerror(error)) where
Hi
Please review this spec update and test for getting array classes and
instances of more dimensions than the class file can express or the VM
can handle.
Array.newInstance have a test for arrays of more dimensions than 255,
this patch adds a test for Class.forName as well.
Also the javadoc
On Oct 9, 2013, at 3:56 AM, Joe Darcy joe.da...@oracle.com wrote:
Hello,
Please review the patch below which addresses
JDK-8024354 Explicitly permit DoubleStream.sum()/average()
implementations to use higher precision summation
Thanks,
The note feels more like an api note
Changeset: d42fe440bda8
Author:rriggs
Date: 2013-10-09 13:34 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d42fe440bda8
8024076: Incorrect 2 - 4 year parsing and resolution in DateTimeFormatter
Summary: Add appendValueReduced method based on a ChronoLocalDate to provide
bug: https://bugs.openjdk.java.net/browse/JDK-8022718
webrev: http://cr.openjdk.java.net/~drchase/8022718/webrev.00/
Problem: Needed implementation for change to the spec for JVM behavior (from
the bug report):
JSR 335 spec, chapter 15.28.2 Run-time Evaluation of Method References
contains
Changeset: b86e6700266e
Author:bpb
Date: 2013-10-09 11:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b86e6700266e
8016252: More defensive HashSet.readObject
Summary: Add data validation checks in readObject().
Reviewed-by: alanb, mduigou, chegar
Contributed-by: Brian
Hi All,
This fix is to solve the memory leak issue in ParseLocale() function of
jdk/src/solaris/native/java/lang/java_props_md.c. Because the locale,
lc, is copied into temp, it is not necessary to do the strdup(), which
leads to the memery leak. The fix simply removes the line of strdup
On Oct 9, 2013, at 3:41 AM, Alan Bateman wrote:
On 08/10/2013 21:50, Brian Burkhalter wrote:
I have updated the webrev accordingly
http://cr.openjdk.java.net/~bpb/8016252/webrev.3/
This looks good, I think this gets us to where we wanted to be.
Pushed:
On 09/10/2013 19:00, Dr Heinz M. Kabutz wrote:
That way, the resources are closed in the reverse order in which they
are opened and an exception in the middle of the creation chain does not
prevent the earlier resources from being closed.
But there is only one resource.
File tzdb = new
On Oct 9, 2013, at 1:56 AM, Chris Hegarty wrote:
This latest webrev looks good to me. If you haven't already got a sponsor,
then I would be happy to sponsor this for you.
Thanks.
Since there are minor spec clarifications, to document long standing
behavior, then a CCC request will need to
On Oct 9, 2013, at 11:49 AM, David Chase david.r.ch...@oracle.com wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8022718
webrev: http://cr.openjdk.java.net/~drchase/8022718/webrev.00/
Problem: Needed implementation for change to the spec for JVM behavior (from
the bug report):
Looks good to me.
Naoto
On 10/9/13 11:51 AM, Dan Xu wrote:
Hi All,
This fix is to solve the memory leak issue in ParseLocale() function of
jdk/src/solaris/native/java/lang/java_props_md.c. Because the locale,
lc, is copied into temp, it is not necessary to do the strdup(), which
leads to the
On Oct 9, 2013, at 3:06 AM, Michael McMahon wrote:
If I read the code correctly then the long standing behavior of
URLClassLoader.getPermissions(null) was to throw a NPE, now it is changed to
return the empty collection in order to match the super type
(SecureClassLoader). I can't think of
How about this one?
http://cr.openjdk.java.net/~drchase/8022718/webrev.01/
This version tests both versions of the modifiers for public --
ref.getModifiers apparently sets public in some cases where the other one does
not.
Not 100% sure what those cases are, I suspect arrays from the cryptic
Changeset: 1597066b58ee
Author:valeriep
Date: 2013-10-08 11:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1597066b58ee
7196382: PKCS11 provider should support 2048-bit DH
Summary: Query and enforce range checking using the values from native PKCS11
library.
Reviewed-by:
Tom Hawtin wrote:
On 09/10/2013 19:00, Dr Heinz M. Kabutz wrote:
That way, the resources are closed in the reverse order in which they
are opened and an exception in the middle of the creation chain does not
prevent the earlier resources from being closed.
But there is only one resource.
On 10/09/2013 11:36 AM, Paul Sandoz wrote:
On Oct 9, 2013, at 3:56 AM, Joe Darcy joe.da...@oracle.com wrote:
Hello,
Please review the patch below which addresses
JDK-8024354 Explicitly permit DoubleStream.sum()/average()
implementations to use higher precision summation
Thanks,
Please review:
webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
Summary:
Reflection generates code dynamically to speed up reflection processing after
startup. The first
15 runs of a reflection call use the vm code path, after
On 10/08/2013 08:08 PM, Mike Duigou wrote:
This seems to contradict the main documentation for these methods. Perhaps instead we
should remove the The average returned can vary depending upon the order in which
values are recorded. This is due to accumulated rounding error in addition of
Big improvement. This looks like the right direction. DoubleStream.average()
needs the same treatment for completeness.
Mike
On Oct 9 2013, at 16:38 , Joe Darcy wrote:
On 10/08/2013 08:08 PM, Mike Duigou wrote:
This seems to contradict the main documentation for these methods. Perhaps
On Oct 9, 2013, at 11:16 AM, Brian Burkhalter wrote:
For Windows I added a similar NET_ ThrowUnknownHostExceptionWithGaiError and
modified Inet{4,6} to mimic the Unix case. Note that the Windows code has not
yet been compiled pending comments.
Since compiled successfully on Windows but
Changeset: 673f8045311e
Author:bpb
Date: 2013-10-09 17:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/673f8045311e
7189139: BigInteger's staticRandom field can be a source of bottlenecks.
Summary: Use ThreadLocalRandom instead of SecureRandom.
Reviewed-by: shade, psandoz
On Oct 9, 2013, at 5:33 AM, Paul Sandoz wrote:
Nice!
Perhaps as a separate bug you could place that code in the JDK test area as a
non-jtreg test?
Please see:
https://bugs.openjdk.java.net/browse/JDK-8026236
The file of primes would need to be hosted elsewhere than the repository given
On 10/09/2013 04:47 PM, Mike Duigou wrote:
Big improvement. This looks like the right direction. DoubleStream.average()
needs the same treatment for completeness.
Thanks Mike. Next iteration incorporating this feedback (and some other
off-list feedback):
For consistency I would move the this is a terminal operation paragraph to
just before the @apiNote. I would suggest after the @apiNote but there's no
mechanism for ending a javadoc tag other than starting another tag and we don't
want the terminal text in the apiNote.
Other than that it looks
I'll pushed with the terminal op reordering you've suggested; thanks for
the reviews,
-Joe
On 10/9/2013 6:17 PM, Mike Duigou wrote:
For consistency I would move the this is a terminal operation paragraph to
just before the @apiNote. I would suggest after the @apiNote but there's no mechanism
Changeset: eab3c09745b6
Author:bchristi
Date: 2013-10-09 12:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab3c09745b6
8024709: TreeMap.DescendingKeyIterator 'remove' confuses iterator position
Summary: Override remove() method in DescendingKeyIterator
Reviewed-by:
Changeset: c13309f658e1
Author:darcy
Date: 2013-10-09 18:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1
8024354: Explicitly permit DoubleStream.sum()/average() implementations to use
higher precision summation
Reviewed-by: mduigou, briangoetz
!
Hi Joel,
The code changes look fine, but I'd like to see some refactoring to the
tests. In particular, please put the logic in
81 try {
82 Class? c256 = Class.forName(name256);
83 error++;
84 System.err.println(ERROR: could create + c256);
Hi Brian,
In the text:
* @exception NullPointerException if {@code urls} or any of its elements
* is {@code null}
I'm unsure if it should be is null or are null given the initial
subject is singular and latter subject is plural. Existing similar
phrases seem to be split
On Oct 8 2013, at 01:27 , Paul Sandoz wrote:
Hi Mike,
I am probably going over old ground here...
Given that there is ConcurrentMap is there any point in having the defaults
on Map detect concurrent modification and barf, or retry, or neither of the
previous two e.g. putIfAbsent,
On Oct 9, 2013, at 8:32 PM, David Holmes david.hol...@oracle.com wrote:
I'm unsure if it should be is null or are null given the initial subject
is singular and latter subject is plural.
The English major in me surfaces briefly to note that any can be either
singular or plural: Pick a
On 9/10/2013 9:55 PM, Alan Bateman wrote:
This test has been failing (very intermittently) for some time. It was
assumed to be a HotSpot issue on SPARC but more recently it has been
duplicated on Linux x64 too. David Simms has notes in the bug [1] from
this instrumentation and analysis, and
80 matches
Mail list logo
