Changeset: 658e121bda42
Author:sherman
Date: 2013-10-17 23:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/658e121bda42
8025971: Remove ZoneId.OLD_SHORT_IDS
8026197: Slow reading tzdb.dat if the JRE is on a high-latency, remote file
system
Summary: removed the
On 18.10.2013 10:13, Martin Buchholz wrote:
The latest webrev is missing the test case that was present in earlier
revisions.
Yes, I removed it from the webrev, following the suggestion posted earlier.
I'm going to replace it with an instruction for QA about how to verify
the fix.
On Oct 17, 2013, at 9:13 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
Thank you Alan!
Yes, I missed that fact that reading from the recycled file descriptor is
actually a problem by itself.
Same here.
Would you please take a look at another updated webrev?
It contains
Just installed Ubuntu 13.10 and see this build failure
/space/repos/jdk8/tl/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c:
In function 'Java_sun_nio_ch_sctp_SctpChannelImpl_initIDs':
/space/repos/jdk8/tl/jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c:86:24:
error: unused
On Oct 9, 2013, at 2:57 AM, Joe Darcy joe.da...@oracle.com wrote:
On 10/04/2013 10:30 AM, mark.reinh...@oracle.com wrote:
2013/10/3 16:43 -0700, joe.da...@oracle.com:
Per previous discussions on the mailing list, we've decided to rename
the annotation type jdk.Supported to jdk.Exported.
On 17/10/2013 20:13, Ivan Gerasimov wrote:
Thank you Alan!
Yes, I missed that fact that reading from the recycled file descriptor
is actually a problem by itself.
Would you please take a look at another updated webrev?
It contains another implementation suggested by Paul Sandoz with some
On 17/10/2013 20:25, Andrew wrote:
:
Is the intention for these 'exported' APIs to be eventually replaced by proper
parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea
of encouraging the use of APIs that are only in this implementation of the JDK.
Just to add to
On 17/10/2013 15:59, Dmitry Nadezhin wrote:
Another solution may be to exclude the SymmetricRangeTests from
automatic test runs,
and to keep this file somewhere for manual tests runs only.
What do you think about this ?
Yes, this make sense. Also we have other examples of long-running or
On 18/10/2013 00:10, Dmitry Samersoff wrote:
Brian,
Looks good for me (not a reviewer).
-Dmitry
I'm okay with it too (apologies we didn't catch it in the 10-iteration
first round, I'm sure it slipped in during one of those iterations).
-Alan.
On 17/10/2013 04:41, Ivan Gerasimov wrote:
Hello everybody!
When I proposed a fix for 8023431 I messed up with verifying the fix
somehow, and the test started to fail right after pushing the fix.
I'm sorry about that.
The reason of the failure is that when GZIPStream is closed, it also
Looks good!
Thanks,
/Staffan
On 16 okt 2013, at 14:04, Mikael Auno mikael.a...@oracle.com wrote:
This bug got a bit lost from my radar after vacation, but I've picked it
again now. I've moved Arrays.asList() as suggested. In further testing of the
fix though, I found that the include list
Hi,
Please review this patch, which modifies
java.time.temporal.TemporalQueries so it compiles after last changes to
javac lambda flow analysis.
The webrev is here:
http://cr.openjdk.java.net/~vromero/8026854/webrev_01/
The bug report is here:
Changeset: 8479a48d9fd4
Author:sla
Date: 2013-10-18 11:52 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8479a48d9fd4
8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()
Reviewed-by: alanb, sspitsyn
! src/share/back/outStream.c
+
On 10/17/13 8:12 PM, Mandy Chung wrote:
Daniel,
Have you considered to revert to the previous version and simply iterate
props.keySet rather than adding a new entry point just for
jdk.internal.util.xml.PropertiesDefaultHandler to use?
Yes - that would be simpler. Here is the new webrev:
On Oct 18, 2013, at 1:15 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
On 10/17/13 8:12 PM, Mandy Chung wrote:
Daniel,
Have you considered to revert to the previous version and simply iterate
props.keySet rather than adding a new entry point just for
Hello everybody!
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8024521/3/webrev/
http://cr.openjdk.java.net/%7Eigerasim/8024521/3/webrev/
I put the regression test back with some slight modifications.
Now, when run in automatic mode, it uses the default time gap of 2
On 18/10/2013 12:15, Daniel Fuchs wrote:
Yes - that would be simpler. Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8016344/webrev.01/
-- daniel
I agree to, this is so much simpler.
Just on the name, TestStoreToXML makes it sound like a general test for
storeToXML but
Thank you Alan for review and offering the sponsor's help.
Here's the exported patch.
http://cr.openjdk.java.net/~igerasim/2commit/8026756-jdk8-GZIPInZip-fails.patch
Sincerely yours,
Ivan
On 18.10.2013 14:43, Alan Bateman wrote:
On 17/10/2013 04:41, Ivan Gerasimov wrote:
Hello everybody!
On 18/10/13 13:00, Paul Sandoz wrote:
On Oct 18, 2013, at 12:58 PM, Vicente-Arturo Romero-Zaldivar
vicente.rom...@oracle.com wrote:
Hi,
Please review this patch, which modifies java.time.temporal.TemporalQueries so
it compiles after last changes to javac lambda flow analysis.
The webrev is
On 10/18/13 1:38 PM, Paul Sandoz wrote:
On Oct 18, 2013, at 1:15 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
On 10/17/13 8:12 PM, Mandy Chung wrote:
Daniel,
Have you considered to revert to the previous version and simply iterate
props.keySet rather than adding a new entry point just
On 10/18/13 2:08 PM, Alan Bateman wrote:
On 18/10/2013 12:15, Daniel Fuchs wrote:
Yes - that would be simpler. Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8016344/webrev.01/
-- daniel
I agree to, this is so much simpler.
Just on the name, TestStoreToXML makes it sound
Changeset: da695008417f
Author:alanb
Date: 2013-10-18 13:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da695008417f
8026859: (fs) test/java/nio/file/Files/StreamTest.java fails to compile
intermittently
Reviewed-by: psandoz
! test/java/nio/file/Files/StreamTest.java
On 18/10/2013 14:38, Daniel Fuchs wrote:
I could remove the storeToXML subdir that I have added and rename the
new test into:
java/util/properties/LoadAndStoreXMLWithDefaults.java
The new test presents some similarities with LoadAndStoreXML, in the
sense that it also stores in a BAOS and
The question around a manual test is interesting. I've never seen a
precedent for this. I think it should be relatively simple to include a
manual test in the repo and make sure it doesn't get run by jtreg, (by
altering the regular jtreg directives) but I wasn't aware that it was an
option.
Changeset: 4161f17dfe2b
Author:sjiang
Date: 2013-10-18 16:15 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4161f17dfe2b
8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package
Reviewed-by: psandoz, dfuchs
!
Hi,
could somebody please review and sponsor (i.e. push) the following small fix:
http://cr.openjdk.java.net/~simonis/webrevs/8026874/
https://bugs.openjdk.java.net/browse/JDK-8026874
During the JAXWS build the newly built JAXP classes should be in the
bootclasspath because the JAXWS build
Hello Volker,
Looks good to me. I can sponsor the change.
/Erik
On 2013-10-18 16:41, Volker Simonis wrote:
Hi,
could somebody please review and sponsor (i.e. push) the following small fix:
http://cr.openjdk.java.net/~simonis/webrevs/8026874/
https://bugs.openjdk.java.net/browse/JDK-8026874
Changeset: b01a10c7c7c2
Author:attila
Date: 2013-10-17 12:38 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b01a10c7c7c2
8026161: Don't narrow floating-point literals in the lexer
Reviewed-by: hannesw, jlaskey
! src/jdk/nashorn/internal/parser/Lexer.java
!
Martin/Miroslav,
Are you aware of this dependency?
-Alan.
On 18/10/2013 15:41, Volker Simonis wrote:
Hi,
could somebody please review and sponsor (i.e. push) the following small fix:
http://cr.openjdk.java.net/~simonis/webrevs/8026874/
https://bugs.openjdk.java.net/browse/JDK-8026874
Changeset: 602aa6fa46c6
Author:alanb
Date: 2013-10-18 15:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/602aa6fa46c6
8026876: (fs) Build issue with
src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java
Reviewed-by: psandoz
!
That would be great. Thanks!
Volker
On Fri, Oct 18, 2013 at 4:54 PM, Erik Joelsson erik.joels...@oracle.com wrote:
Hello Volker,
Looks good to me. I can sponsor the change.
/Erik
On 2013-10-18 16:41, Volker Simonis wrote:
Hi,
could somebody please review and sponsor (i.e. push) the
2013/10/17 15:45 -0700, joe.da...@oracle.com:
Following up on the earlier feedback, please review the patch below with
proposed clarifications to jdk.Exported.
Looks good to me. Thanks for adding this guidance.
- Mark
Hi,
So here is the new webrev with the test renamed...
http://cr.openjdk.java.net/~dfuchs/webrev_8016344/webrev.03/
-- daniel
On 10/18/13 3:45 PM, Alan Bateman wrote:
On 18/10/2013 14:38, Daniel Fuchs wrote:
I could remove the storeToXML subdir that I have added and rename the
new test
Changeset: 8d1d5a5aeb41
Author:robm
Date: 2013-10-18 16:28 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d1d5a5aeb41
8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log
open in fastdebug builds
Reviewed-by: alanb
Contributed-by:
On 10/17/13 7:16 PM, Mandy Chung wrote:
On 10/16/13 5:35 AM, Daniel Fuchs wrote:
Hi,
Please find below the new revision:
http://cr.openjdk.java.net/~dfuchs/webrev_8026499/webrev.01/
Looks good.
As for the test, LoggingSupport.getLogger is just a layer to support the
PlatformLogger be
Hello Volker,
Building without a -bootclasspath results in the following warning which
is likely why it was added in the first place:
warning: [options] bootstrap class path not set in conjunction with
-source 1.7
Note that we are using the bootstrap javac, so it's not the one bundled
On 10/18/2013 8:27 AM, Daniel Fuchs wrote:
So here is the new webrev with the test renamed...
http://cr.openjdk.java.net/~dfuchs/webrev_8016344/webrev.03/
Looks much simpler. Thanks for doing that.
Mandy
Thank you Martin for the references.
I've implemented passing the limitation to the application in a similar
manner.
The timeout value is passed to the test through the CloseRaceTimeout
system property.
If the property wasn't set, the default value of 2 minutes is used.
When the application
The WebRev with @ignore in SymmetricRangeTests is here:
http://cr.openjdk.java.net/~bpb/6910473/webrev.3/
jtreg ignores the test with a message
test result: Error. Test ignored: hugeMemory
with default jtreg command-line;
jtreg runs it with additional switch -ignore:run.
On Fri, Oct 18, 2013
Hi Stephen,
As I said before that while I agree that these three short ids are kinda
of confusing
and understand the desire of removing them but I'm also concerned that
the fact
(1) these ids been in the available timezone ids from the j.u.TZ for a
long time
(2) these ids are defined in the
On 18/10/2013 17:24, Dmitry Nadezhin wrote:
The WebRev with @ignore in SymmetricRangeTests is here:
http://cr.openjdk.java.net/~bpb/6910473/webrev.3/
jtreg ignores the test with a message
test result: Error. Test ignored: hugeMemory
with default jtreg command-line;
jtreg runs it with additional
Updated webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8024688/3/webrev/
More notes below.
On Oct 16 2013, at 21:20 , David Holmes david.hol...@oracle.com wrote:
Hi Mike,
Map.java:
The implNote for computeIfAbsent should be modified to match the
implementation. Ditto for
On Oct 17 2013, at 07:36 , Paul Sandoz paul.san...@oracle.com wrote:
On Oct 17, 2013, at 1:52 AM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 16 2013, at 05:34 , Paul Sandoz paul.san...@oracle.com wrote:
On Oct 16, 2013, at 1:52 PM, David Holmes david.hol...@oracle.com wrote:
looks fine
On 10/15/2013 09:03 AM, roger riggs wrote:
Hi,
Spot fix for a date time parsing case witha reduced value field when the
chronology
is parsed after the reduced value field. The fix is to add a callback when the
chronology is set to recompute the value of the field with the new
On 18/10/2013 06:45, Joe Darcy wrote:
Hello,
Following up on the earlier feedback, please review the patch below
with proposed clarifications to jdk.Exported.
Thanks,
-Joe
I went through the proposed wording and it looks good to me too.
-Alan
Changeset: 88436832cfd0
Author:dsamersoff
Date: 2013-10-19 00:05 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88436832cfd0
8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields
Summary: Add some extra fileds to jdp packet
Reviewed-by: allwin,
I've emailed the ThreeTen lists to ensure everyone knows about this.
To balance the points below, it should be noted that
(1) they've been deprecated in TimeZone for a long time
(2) their meaning has changed over time
(3) they lead to user bugs, where someone finds EST exists and thus
assumes
Hello,
Please review the fix for a ppc failure, a simple ifdef
change to use the correct macro for big and little endian
switching.
Webrev
http://cr.openjdk.java.net/~ksrini/8026794/webrev/
Thanks
Kumar
Changeset: 7a947daa8f51
Author:rriggs
Date: 2013-10-18 16:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a947daa8f51
8025828: Late binding of Chronology to appendValueReduced
Summary: Add a listener to the parseContext called when the Chronology changes
Reviewed-by:
Changeset: 7de97abc4a5c
Author:jjg
Date: 2013-10-18 15:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c
8026749: Missing LV table in lambda bodies
Reviewed-by: vromero, jlahoda
! src/share/classes/com/sun/tools/javac/code/Flags.java
!
Looks good to me!
Thanks,
David
On 19/10/2013 7:30 AM, Kumar Srinivasan wrote:
Hello,
Please review the fix for a ppc failure, a simple ifdef
change to use the correct macro for big and little endian
switching.
Webrev
http://cr.openjdk.java.net/~ksrini/8026794/webrev/
Thanks
Kumar
Changeset: 130b8c0e570e
Author:bpatel
Date: 2013-10-18 16:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/130b8c0e570e
8026567: Use meaningful style names for strong and italic styles.
Reviewed-by: jjg
!
52 matches
Mail list logo
