Pretty much looks good.
However, I notice that the equals, hashCode and toString methods of
the 4 calendar specific date classes are inherited rather than
written. Without additional spec, I'm not sure that they can claim to
be value types. Adding the 12 Javadocs should be relatively easy.
Hi Stephen,
On 12/5/2013 6:04 AM, Stephen Colebourne wrote:
Pretty much looks good.
However, I notice that the equals, hashCode and toString methods of
the 4 calendar specific date classes are inherited rather than
written. Without additional spec, I'm not sure that they can claim to
be value
Following the lead of the notices added to Optional, the java.time value
based
classes should include the same notice.
Please review:
http://cr.openjdk.java.net/~rriggs/webrev-time-valuetype-8029551/
Thanks, Roger
On 12/04/2013 12:00 PM, roger riggs wrote:
Following the lead of the notices added to Optional, the java.time value based
classes should include the same notice.
Please review:
http://cr.openjdk.java.net/~rriggs/webrev-time-valuetype-8029551/
Thanks, Roger
Corrected.
Thanks, Roger
On 12/4/2013 3:42 PM, Xueming Shen wrote:
On 12/04/2013 12:00 PM, roger riggs wrote:
Following the lead of the notices added to Optional, the java.time
value based
classes should include the same notice.
Please review:
