On Wed, 15 Nov 2023 17:50:48 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improvements after feedback
Really nicely done.
On Thu, 16 Nov 2023 05:33:13 GMT, David Holmes wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread
On Wed, 15 Nov 2023 22:05:47 GMT, Srinivas Vamsi Parasa
wrote:
>> make/modules/java.base/Lib.gmk line 245:
>>
>>> 243: TOOLCHAIN := TOOLCHAIN_LINK_CXX, \
>>> 244: OPTIMIZATION := HIGH, \
>>> 245: CFLAGS := $(CFLAGS_JDKLIB) -std=c++17, \
>>
>> This makes me uneasy. We do not
On Tue, 7 Nov 2023 00:12:41 GMT, Srinivas Vamsi Parasa wrote:
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For
On Tue, 14 Nov 2023 17:25:42 GMT, Darragh Clarke wrote:
>> Currently the `IsAlive` test occasionally times out.
>>
>> This PR changes the timeout from `10` to `25` which I think is an adequate
>> increase based on the failures I've seen. Though I'd be happy to change it
>> to another value if
On Wed, 15 Nov 2023 17:03:38 GMT, Steve Dohrmann wrote:
>> Do you see any concerns while handling multithreaded case where writer is
>> busy copying 256 bytes block in loop and reader try to access a location
>> still not flushed out of write combining buffer.
>
> The results a concurrent
On Tue, 14 Nov 2023 07:59:22 GMT, Jatin Bhateja wrote:
>> Below is baseline data collected using a modified version of the
>> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
>> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake
>> i7-1185G7,
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Wed, 15 Nov 2023 19:26:06 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
On Wed, 15 Nov 2023 15:52:43 GMT, Jayathirth D V wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 142:
>
>> 140: private static final
On Wed, 15 Nov 2023 02:17:58 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather with high performance backend
On Wed, 15 Nov 2023 02:17:58 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather with high performance backend
On Wed, 15 Nov 2023 02:17:58 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather with high performance backend
On Mon, 6 Nov 2023 18:37:41 GMT, Sandhya Viswanathan
wrote:
>> match_rule_supported_vector called in the beginning will enforce these
>> checks.
>
> This method is match_rule_support_vector and it is not enforcing this check
> now. It was doing so before through fall through.
I will be more
On Tue, 7 Nov 2023 00:37:47 GMT, Phil Race wrote:
> > > So we have somewhere around a fixed 125ms startup cost for the FFM case -
> > > as measured on my Mac,
> > > but only 35-40ms of that is attributable to the specific needs of layout.
> >
> >
> > That looks unfortunate. I guess if we will
On Wed, 15 Nov 2023 17:50:48 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improvements after feedback
Elegantly and
On Tue, 14 Nov 2023 14:06:29 GMT, Alan Bateman wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733201186
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote:
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A
On Wed, 15 Nov 2023 02:39:56 GMT, Mandy Chung wrote:
>> This PR includes test fixes for the following issues:
>>
>> 8319567: Update java/lang/invoke tests to support vm flags
>> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> to accept vm flags
>> 8319672:
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote:
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A
On Wed, 15 Nov 2023 21:21:07 GMT, Severin Gehwolf wrote:
> Note that plugins like `--add-options` have been modified so that only the
> options passed at the current CLI will propagate to the final image. So in
> this case, `image1` would have property `com.foo.XYZ` set, but not `image2`.
>
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote:
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote:
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733121214
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Looks good; thanks for fixing this.
-
Marked as reviewed by darcy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733118262
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Looks fine
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733111801
On Wed, 15 Nov 2023 15:23:48 GMT, Raffaello Giulietti
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update PPC implementation of string_compress to return the index of the
>> non-latin1 char
>> Patch supplied
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
Hi Rob,
honestly I think this all looks ok (as in: I don't think you need to do
anything in particular). You are writing a library that will need to
create some downcall method handles and dereference some pointers. You
need unsafe access, so users of your library will need to pass your
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
HTML Tidy (`tidy -e`) output after 6cc6f8b66cf6819efd3a8c73701722ee8539257b:
Info: Document content looks like HTML5
No warnings or errors were found.
Generated HTML looks okay
Clean up HTML error due to nested anchor (``) elements.
-
Commit messages:
- 8320199: Fix HTML 5 errors in java.math.BigInteger
Changes: https://git.openjdk.org/jdk/pull/16679/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16679=00
Issue:
On Wed, 15 Nov 2023 15:15:37 GMT, Magnus Ihse Bursie wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX2 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
>>
On Tue, 14 Nov 2023 15:21:47 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>>
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err files reporting
>> JFR event
On Wed, 15 Nov 2023 20:13:15 GMT, Eirik Bjorsnos wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 581:
>>
>>> 579: if ((flag & 8) == 8) {
>>> 580: /* "Data Descriptor" present */
>>> 581: if (hasZip64Extra(e) ||
>>
>> You probably
On Tue, 14 Nov 2023 11:49:11 GMT, Lance Andersen wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a @bug reference in the test
>
> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 581:
>
>>
On Mon, 13 Nov 2023 19:02:28 GMT, Lance Andersen wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a @bug reference in the test
>
> test/jdk/java/util/zip/ZipInputStream/Zip64DataDescriptor.java line 57:
>
>>
> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
> number of compressed or uncompressed bytes read from the inflater is larger
> than the Zip64 magic value.
>
> While the ZIP format mandates that the data descriptor `SHOULD be stored in
> ZIP64 format (as 8 byte
> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
> number of compressed or uncompressed bytes read from the inflater is larger
> than the Zip64 magic value.
>
> While the ZIP format mandates that the data descriptor `SHOULD be stored in
> ZIP64 format (as 8 byte
On Wed, 15 Nov 2023 19:26:06 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size
On Mon, 13 Nov 2023 11:08:13 GMT, Maurizio Cimadamore
wrote:
> Silently ignoring exceptions seems bad, but something that is forced when
> using a Cleaner
I also don't like that Cleaner ignores exceptions.
One idea I have: [8305979 : UncaughtExceptionHandler for Cleaner
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested is the validation that the total CEN size fits in a Java
> byte array. Suggested rename: CenSizeTooLarge
On Wed, 15 Nov 2023 07:41:32 GMT, Jaikiran Pai wrote:
> Overall, this is a very good improvement to the test and looks good to me. I
> just a have a trivial comment about a typo in a code comment, which I've
> added inline.
Thanks for your review, Jaikiran! With these latest, comment-only
On Mon, 13 Nov 2023 23:35:11 GMT, Naoto Sato wrote:
> Correcting the explanation of the `DateFormat.SHORT` constant.
This pull request has now been integrated.
Changeset: 891d8cfa
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/891d8cfaf2fc0636bfe8f864cd010fb71266d723
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is primarily to provide a more informative String
On Tue, 14 Nov 2023 07:13:41 GMT, Alan Bateman wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review: change string value and drop spec
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 498:
>
On Thu, 29 Jun 2023 09:59:08 GMT, Chen Liang wrote:
> `LocalVariable` and `LocalVariableType` includes `writeTo(BufWriter)`, which
> should be implementation details.
>
> See
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html
> for context.
>
> This patch moves the
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Improvements after feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16420/files
-
On Wed, 15 Nov 2023 16:40:53 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unpacking the rethrown exceptions from Gatherers.mapConcurrent()
>
> test/jdk/java/util/stream/GathererAPITest.java
Hello all,
I'm working on a module that makes working with FFM easier; think of
something like JNA. For instance, it allows creating structures without
having to manually manage var handles etc.
My module uses restricted mehods like AddressLayout.withTargetLayout to
support pointers. Those
On Wed, 15 Nov 2023 01:44:56 GMT, Jatin Bhateja wrote:
>> Thanks, there is an store fence upon completion of the main loop for the
>> large size code:
>>
>> 
>
> Do you see any concerns while handling
On Tue, 14 Nov 2023 16:35:53 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Unpacking the rethrown exceptions from
On Tue, 14 Nov 2023 16:05:51 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Tue, 14 Nov 2023 13:35:46 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 25 Oct 2023 23:42:08 GMT, Phil Race wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> indentation
On Wed, 15 Nov 2023 15:32:54 GMT, Claes Redestad wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update PPC implementation of string_compress to return the index of the
>> non-latin1 char
>> Patch supplied by
On Sat, 11 Nov 2023 15:57:40 GMT, Jim Laskey wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up previous commit
>
> Things should be fine now.
@JimLaskey, I read JEP 463 but couldn't find any statements on
On Tue, 14 Nov 2023 16:05:51 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Wed, 15 Nov 2023 07:48:28 GMT, Eric Liu wrote:
> Vector API defines zero-extend operations [1], which are going to be
> intrinsified and generated to `VectorUCastNode` by C2. This patch adds
> backend implementation for `VectorUCastNode` on AArch64.
>
> The micro benchmark shows
On Tue, 7 Nov 2023 00:12:41 GMT, Srinivas Vamsi Parasa wrote:
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For
On Wed, 15 Nov 2023 08:18:31 GMT, Per Minborg wrote:
> This PR proposes to fix a failing test on big endian architectures like AIX.
This pull request has now been integrated.
Changeset: 4f4d00fa
Author:Per Minborg
URL:
On Wed, 15 Nov 2023 08:18:31 GMT, Per Minborg wrote:
> This PR proposes to fix a failing test on big endian architectures like AIX.
Thanks for fixing it so quickly! Looks correct and makes the test happy on AIX.
-
Marked as reviewed by mdoerr (Reviewer).
PR Review:
On Thu, 9 Nov 2023 09:22:45 GMT, suchismith1993 wrote:
> 1. use pragma directive to handle alignment.
>
> JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175)
Looks good. I had proposed this solution here:
https://github.com/openjdk/jdk/pull/16179#discussion_r1360709308
On Wed, 15 Nov 2023 09:27:45 GMT, Jaikiran Pai wrote:
>> This PR proposes to fix a failing test on big endian architectures like AIX.
>
> test/jdk/java/foreign/TestLayouts.java line 223:
>
>> 221: public void testSequenceLayoutWithZeroLength() {
>> 222: SequenceLayout layout =
On Wed, 15 Nov 2023 08:18:31 GMT, Per Minborg wrote:
> This PR proposes to fix a failing test on big endian architectures like AIX.
test/jdk/java/foreign/TestLayouts.java line 223:
> 221: public void testSequenceLayoutWithZeroLength() {
> 222: SequenceLayout layout =
Thank you for those references! The docs by Ben Manes look like a good
starting point to learn more about implementing a concurrent cache.
To elaborate on my motivation: I work as an educator explaining concepts
behind Java extensions in a corporate context. LRU caches seemed like an
interesting
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err files reporting
>> JFR event
This PR proposes to fix a failing test on big endian architectures like AIX.
-
Commit messages:
- Fix AIX test issue
Changes: https://git.openjdk.org/jdk/pull/16672/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16672=00
Issue: https://bugs.openjdk.org/browse/JDK-8319966
71 matches
Mail list logo
