On Mon, 6 Nov 2023 06:41:22 GMT, Chen Liang wrote:
> Discovered while writing a test for #16513 that
> `ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet
> [JVM
> Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100)
> requires it
On Wed, 7 Feb 2024 01:52:06 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>>
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have
On Tue, 6 Feb 2024 23:07:49 GMT, Roger Riggs wrote:
>> I agree, it was the existing design that caused for example,
>> CompactNumberFormat to not automatically be supported by MessageFormat. A
>> simple alternative would be storing the potential pre-defined NumberFormats
>> in some data
On Thu, 1 Feb 2024 01:32:42 GMT, Joe Darcy wrote:
> A double quote character doesn't need to be escaped when it is a char literal
> and single quote character doesn't need to be escaped when it is in a string.
> This change updates the toString() output of annotations to account for the
>
On Tue, 6 Feb 2024 22:31:32 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/MessageFormat.java line 681:
>>
>>> 679: if (fmt instanceof NumberFormat) {
>>> 680: // Add any instances returned from the NumberFormat
>>> factory methods
>>> 681: if
On Thu, 1 Feb 2024 01:32:42 GMT, Joe Darcy wrote:
> A double quote character doesn't need to be escaped when it is a char literal
> and single quote character doesn't need to be escaped when it is in a string.
> This change updates the toString() output of annotations to account for the
>
On Tue, 6 Feb 2024 14:59:22 GMT, Roger Riggs wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Apply spacing suggestions
>>
>>Co-authored-by: Andrey Turbanov
>> - add expected message to exception checking
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
> which adds MessageFormat pattern support for the following subformats:
> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
> intended to provide pattern support for the more recently added JDK
On Fri, 2 Feb 2024 00:38:51 GMT, Brian Burkhalter wrote:
> Modify the specification verbiage of `java.io.RandomAccessFile.setLength` to
> account for the effect of the method on the file offset as returned by
> `getFilePointer`.
This pull request has now been integrated.
Changeset: 4b1e367e
On Tue, 6 Feb 2024 18:29:17 GMT, Chen Liang wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits
> Currently, add is returning intern(e) == null which will always be false. The
> correct test is intern(e) == e , that is, true when element is newly added.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Update
On Tue, 6 Feb 2024 13:56:09 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request with a new target base due to a
On Tue, 6 Feb 2024 17:29:25 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/sun/net/www/MessageHeader.java line 53:
>>
>>> 51: }
>>> 52:
>>> 53: @SuppressWarnings("this-escape")
>>
>> An alternative here could be to make the class final. AFAICS it's not
>> subclassed anywhere.
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the
On Thu, 1 Feb 2024 23:12:46 GMT, Naoto Sato wrote:
> Implementing "loose matching" of space separators in both
> `java.time.format.DateTimeFormatter` and `java.text.DateFormat` on lenient
> parsing. This will effectively fix the NNBSP issues on parsing time with
> am/pm markers introduced
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the
On Tue, 6 Feb 2024 14:35:52 GMT, Daniel Fuchs wrote:
>> After the "this-escape" lint warning was added to javac (JDK-8015831), the
>> base module was not updated to be able to compile with this warning enabled.
>> This PR makes the necessary changes to allow the base module to build with
>>
On Mon, 5 Feb 2024 20:11:43 GMT, Mandy Chung wrote:
> Trivial fix. Call `PrintWriter::format` with null `Locale` to format with no
> localization.
>
> This PR also fixes JDK-8325262 to print `FindException` message without the
> stack trace to indicate clearer that the given module path is
On Mon, 5 Feb 2024 20:11:43 GMT, Mandy Chung wrote:
> Trivial fix. Call `PrintWriter::format` with null `Locale` to format with no
> localization.
>
> This PR also fixes JDK-8325262 to print `FindException` message without the
> stack trace to indicate clearer that the given module path is
This pull request contains a backport of commit
[1ae85138](https://github.com/openjdk/jdk/commit/1ae851387f881263ccc6aeace5afdd0f49d41d33)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Paul Sandoz on 2 Feb 2024 and was
reviewed by
On Fri, 2 Feb 2024 07:01:33 GMT, Sam James wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also fix fstatvfs on AIX
>
> make/modules/jdk.hotspot.agent/Lib.gmk line 31:
>
>> 29:
>> 30: ifeq ($(call
On Tue, 6 Feb 2024 13:56:09 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request with a new target base due to a
On Fri, 2 Feb 2024 22:24:49 GMT, Naoto Sato wrote:
>> We discussed this separately, but will go over again here in case others are
>> interested. Since DTF does not implement `equals()`, even if we implement
>> `equals()` for the `ClassicFormat`, we would basically still need to
>> implement
On Mon, 5 Feb 2024 23:51:00 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
>> which adds MessageFormat pattern support for the following subformats:
>> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
>> intended to
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the
On Tue, 6 Feb 2024 08:20:39 GMT, Magnus Ihse Bursie wrote:
> I'd just hate to see all this work go to waste.
Same here!
-
PR Comment: https://git.openjdk.org/jdk/pull/16234#issuecomment-1929780538
> Currently, add is returning intern(e) == null which will always be false. The
> correct test is intern(e) == e , that is, true when element is newly added.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated
On Tue, 6 Feb 2024 08:18:14 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request
On Sun, 21 Jan 2024 13:48:49 GMT, Shaojin Wen wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Tue, 6 Feb 2024 12:30:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>>
Currently, add is returning intern(e) == null which will always be false. The
correct test is intern(e) == e , that is, true when element is newly added.
-
Commit messages:
- Correct test
Changes: https://git.openjdk.org/jdk/pull/17732/files
Webrev:
On Thu, 7 Dec 2023 09:30:01 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Tue, 6 Feb 2024 12:30:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>>
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial
On Tue, 6 Feb 2024 10:31:06 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>>
On Wed, 31 Jan 2024 15:33:01 GMT, Jan Kratochvil
wrote:
>> It looks like this patch needs a bit more discussion. Generally, it would be
>> good to have the functionality, but I'm unsure about the proposed
>> implementation.
>>
>> Walking the directory hierarchy (**and** interface files) on
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have
Can I please get a review of this doc-only change which updates the javadoc of
several classes in `java.util.jar` and `java.util.zip` to specify their
behaviour when `null` arguments are passed to the constructor or methods of
those classes?
For these updated classes, I have individually
On Tue, 6 Feb 2024 10:05:52 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those
On Mon, 11 Dec 2023 18:25:09 GMT, Ludovic Henry wrote:
>> @theRealAph
>>> Or is there likely to be a plan to e.g. build Oracle's releases with SLEEF
>>> support?
>>
>> I can't say anything for sure, but I picked up some positive vibes from our
>> internal chat. I think the idea was that
On Thu, 7 Dec 2023 09:30:01 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last revision:
On Mon, 5 Feb 2024 14:06:21 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request
On Thu, 7 Dec 2023 09:30:01 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Fri, 8 Dec 2023 00:50:59 GMT, Xiaohong Gong wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix potential attribute issue
>
>> Build changes finally look good. Great, actually! Thanks for persisting,
>>
On Mon, 5 Feb 2024 14:15:44 GMT, Matthias Baesken wrote:
>
> Thanks for the AIX related effort ; I put it again into our internal
> build/test queue.
With the latest commit the build again fails on AIX with this error
/jdk/src/java.base/unix/native/libnio/ch/UnixFileDispatcherImpl.c:381:27:
52 matches
Mail list logo
