On Mon, 4 Mar 2024 23:44:14 GMT, Erik Joelsson wrote:
>> Executables and dynamic libraries on Linux can encode a search path that the
>> dynamic linker will use when looking up library dependencies, generally
>> referred to as an "rpath". In the JDK we use this with the $ORIGIN feature
>> to
On Mon, 4 Mar 2024 19:07:44 GMT, Naoto Sato wrote:
>> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The
>> `COMPAT` locale data was introduced for applications' migratory purposes
>> transitioning to `CLDR`. It is becoming a technical debt and now is the time
>> to
On Mon, 4 Mar 2024 09:55:09 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which suggests we remove the package-private,
> unused and deprecated method `java.util.jar.Manifest.make72Safe`.
>
> This method was marked deprecated after a cleanup/refactoring in
>
Hi Michael,
.DS_Store file contains information about icon position and other visual
information on how to display folder. Once osascript configures DMG, Finder
will store these setting in .DS_Store file. If it gets deleted from DMG, DMG
will look like osascript was never run. So, Alan is
I’m not following what the .DS_Store file has to do with anything, other than
being a Mac feature that’s occasionally a nuisance when the files end up in
zip’s or elsewhere where you don’t want them.
I’m also not sure if that was my explanation or Alexander’s you’re talking
about. Using the
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote:
> Fixing test cases. For bad test cases, only the first case was run, and the
> rest were ignored.
Looks fine; thanks for sending out the fix.
test/jdk/java/lang/Double/ParseDouble.java line 559:
> 557: private static void
Fixing test cases. For bad test cases, only the first case was run, and the
rest were ignored.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18113/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18113=00
Issue:
On Sun, 3 Mar 2024 05:00:36 GMT, Guoxiong Li wrote:
>> Please review this PR and corresponding CSR which prevents an
>> OutOfMemoryError by restricting the initial maximum fraction digits for an
>> empty pattern DecimalFormat.
>>
>> For an empty String pattern DecimalFormat, the maximum
On Mon, 4 Mar 2024 16:03:55 GMT, Roger Riggs wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>>
> Please review this PR and corresponding CSR which prevents an
> OutOfMemoryError by restricting the initial maximum fraction digits for an
> empty pattern DecimalFormat.
>
> For an empty String pattern DecimalFormat, the maximum fraction digits is
> initialized to `Integer.MAX_VALUE`. When
On Mon, 4 Mar 2024 23:23:04 GMT, Roger Riggs wrote:
>> This change is intended to address the segmentation fault issue that occurs
>> when jspawnhelper is called without arguments, and it includes an updated
>> test to verify the behavior in such cases.
>>
>> Existing tests passes since it
Thank you for the explanation.
It was not obvious to me that the configuration of the DMG appearance actually
means configuring the .DS_Store file in the DMG.
Alan
> On Mar 4, 2024, at 1:27 PM, Alexander Matveev
> wrote:
>
> Hi Alan,
>
> See below.
>
> From: core-libs-dev
> Executables and dynamic libraries on Linux can encode a search path that the
> dynamic linker will use when looking up library dependencies, generally
> referred to as an "rpath". In the JDK we use this with the $ORIGIN feature to
> set search paths relative to the location of the binary
On Mon, 4 Mar 2024 21:19:26 GMT, Elif Aslan wrote:
> This change is intended to address the segmentation fault issue that occurs
> when jspawnhelper is called without arguments, and it includes an updated
> test to verify the behavior in such cases.
>
> Existing tests passes since it does not
If I remember what I read correctly it was Apple’s intention that some services
require explicit user authorization.
So, the dialog.
You could probably hdiutil yourself but the AppleScript does have benefits.
Such as a background image, the drag to Application Folder option, layout
appearance
On Mon, 4 Mar 2024 21:19:26 GMT, Elif Aslan wrote:
> This change is intended to address the segmentation fault issue that occurs
> when jspawnhelper is called without arguments, and it includes an updated
> test to verify the behavior in such cases.
>
> Existing tests passes since it does not
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject differently. See the spec change in the `Subject.java` file
On Sat, 2 Mar 2024 00:34:32 GMT, Justin Lu wrote:
> Please review this PR and corresponding CSR which prevents an
> OutOfMemoryError by restricting the initial maximum fraction digits for an
> empty pattern DecimalFormat.
>
> For an empty String pattern DecimalFormat, the maximum fraction
Hi Alan,
See below.
From: core-libs-dev on behalf of Alan Snyder
Date: Sunday, March 3, 2024 at 7:09 PM
To: core-libs-dev@openjdk.org
Subject: jpackage requests permission via a dialog
I tried using jpackage on macOS to create a DMG (which I have not done before)
and was surprised when a
This change is intended to address the segmentation fault issue that occurs
when jspawnhelper is called without arguments, and it includes an updated test
to verify the behavior in such cases.
Existing tests passes since it does not check behavior without args.
After test update the test fails
On 3/3/2024 10:09 PM, Alan Snyder wrote:
I tried using jpackage on macOS to create a DMG (which I have not done before)
and was surprised when a system dialog was displayed requesting permission for
Terminal to control Finder.
I found this issue described in JDK-8231855, which was closed
On Mon, 4 Mar 2024 16:17:14 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix MBeanServerFileAccessController, more test in SM
>
> src/java.base/share/classes/javax/security/auth/Subject.java
On Mon, 4 Mar 2024 15:47:41 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix MBeanServerFileAccessController, more test in SM
>
> test/jdk/javax/security/auth/Subject/CallAsWithScopedValue.java
On Mon, 4 Mar 2024 15:15:54 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix MBeanServerFileAccessController, more test in SM
>
> test/jdk/javax/management/monitor/ThreadPoolAccTest.java line
On Mon, 4 Mar 2024 09:55:09 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which suggests we remove the package-private,
> unused and deprecated method `java.util.jar.Manifest.make72Safe`.
>
> This method was marked deprecated after a cleanup/refactoring in
>
On Mon, 4 Mar 2024 09:55:09 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which suggests we remove the package-private,
> unused and deprecated method `java.util.jar.Manifest.make72Safe`.
>
> This method was marked deprecated after a cleanup/refactoring in
>
On Mon, 4 Mar 2024 19:51:38 GMT, Weijun Wang wrote:
>> src/java.management/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java
>> line 309:
>>
>>> 307: final Subject s;
>>> 308: if (!SharedSecrets.getJavaLangAccess().allowSecurityManager())
>>> {
>>>
On Mon, 4 Mar 2024 15:28:28 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix MBeanServerFileAccessController, more test in SM
>
>
On Fri, 1 Mar 2024 07:37:22 GMT, Alan Bateman wrote:
> Would it be possible to expand a bit on what is going on here? Are you saying
> that in the course of upgrading a JDK that you somehow get into a state where
> jspawnhelper has been replaced with a version from a newer JDK? Is the real
>
> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The
> `COMPAT` locale data was introduced for applications' migratory purposes
> transitioning to `CLDR`. It is becoming a technical debt and now is the time
> to remove it (we've been emitting a warning at JVM startup
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote:
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where
> aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the
> in-house cache with WeakHashMap, and removed the Key class as it is no longer
> needed
On Mon, 4 Mar 2024 13:52:13 GMT, Jan Lahoda wrote:
> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
> automatically granted the native access. I am working on an upgrade of JLine
> inside the `jdk.internal.le` module, and I would like to replace the current
>
Hi all,
after moving our application to Java 21 (up from Java 17), we noticed a
class loader leak. A memory snapshot points to a ProtectionDomain object
held by a ForkJoinWorkerThread, the protection domain holds the class
loader and prevents GC.
To reproduce outside of our application, we use
On Mon, 4 Mar 2024 13:55:15 GMT, Claes Redestad wrote:
> [JDK-8325340](https://bugs.openjdk.org/browse/JDK-8325340) accidentally
> removed `final` from the `static final DataInputStream.readUTF` method. This
> has a minor compatibility impact (allows hiding the method in a subclass,
> while
On Mon, 4 Mar 2024 13:55:15 GMT, Claes Redestad wrote:
> [JDK-8325340](https://bugs.openjdk.org/browse/JDK-8325340) accidentally
> removed `final` from the `static final DataInputStream.readUTF` method. This
> has a minor compatibility impact (allows hiding the method in a subclass,
> while
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
On Fri, 23 Feb 2024 19:18:46 GMT, Christoph Langer wrote:
> The new test JmodExcludedFiles.java checks that no debug symbol files are
> contained in the jmod files. It does not take into account that with
> configure option --with-external-symbols-in-bundles=public we want to have
> stripped
On Fri, 23 Feb 2024 19:18:46 GMT, Christoph Langer wrote:
> The new test JmodExcludedFiles.java checks that no debug symbol files are
> contained in the jmod files. It does not take into account that with
> configure option --with-external-symbols-in-bundles=public we want to have
> stripped
On Sat, 2 Mar 2024 16:22:22 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather using hybrid algorithm which initially
>>
On Tue, 30 Jan 2024 21:58:28 GMT, Weijun Wang wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store the
>> current subject
On Sat, 2 Mar 2024 00:34:32 GMT, Justin Lu wrote:
> Please review this PR and corresponding CSR which prevents an
> OutOfMemoryError by restricting the initial maximum fraction digits for an
> empty pattern DecimalFormat.
>
> For an empty String pattern DecimalFormat, the maximum fraction
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Thank you,
> Adam
Adam
On Tue, 30 Jan 2024 21:58:28 GMT, Weijun Wang wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store the
>> current subject
On Mon, 4 Mar 2024 13:55:15 GMT, Claes Redestad wrote:
> [JDK-8325340](https://bugs.openjdk.org/browse/JDK-8325340) accidentally
> removed `final` from the `static final DataInputStream.readUTF` method. This
> has a minor compatibility impact (allows hiding the method in a subclass,
> while
On Tue, 30 Jan 2024 21:58:28 GMT, Weijun Wang wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store the
>> current subject
On Mon, 8 Jan 2024 13:38:16 GMT, Adam Sotona wrote:
> ClassFile API performance related improvements have been separated from
> #17121 into this PR.
>
> These improvements are important to minimize performance regression of
> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use
On Tue, 30 Jan 2024 21:58:28 GMT, Weijun Wang wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store the
>> current subject
On Fri, 23 Feb 2024 15:30:09 GMT, Aleksei Efimov wrote:
> Thanks for exploring the possibility of improving tracebility of test
> invocations to reported bugs.
>
> >
I've given this test change a second thought, maybe you can try to separate the
test into two separate test classes? One
On Mon, 4 Mar 2024 14:53:21 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/flags-cflags.m4 line 40:
>>
>>> 38: # Default works for linux, might work on other platforms as well.
>>> 39: SHARED_LIBRARY_FLAGS='-shared'
>>> 40: SET_EXECUTABLE_ORIGIN='-Wl,-rpath,\$$ORIGIN[$]1
>>>
On Sun, 3 Mar 2024 22:12:19 GMT, David Holmes wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use @requires in test
>
> make/autoconf/flags-cflags.m4 line 40:
>
>> 38: # Default works for linux, might work
On Mon, 4 Mar 2024 11:45:59 GMT, Julian Waters wrote:
> I do hope that dropping ccache support isn't something that's planned though
> :(
Not really. The benefit of dropping it is quite small, and there might be use
cases where it helps.
But I think we should perhaps be more explicit in the
On Mon, 4 Mar 2024 14:57:44 GMT, Erik Joelsson wrote:
>> Executables and dynamic libraries on Linux can encode a search path that the
>> dynamic linker will use when looking up library dependencies, generally
>> referred to as an "rpath". In the JDK we use this with the $ORIGIN feature
>> to
> Executables and dynamic libraries on Linux can encode a search path that the
> dynamic linker will use when looking up library dependencies, generally
> referred to as an "rpath". In the JDK we use this with the $ORIGIN feature to
> set search paths relative to the location of the binary
On Sun, 3 Mar 2024 22:09:51 GMT, David Holmes wrote:
> I find it somewhat odd that we seem to be add odds with the general
> programming community when it comes to this behaviour. Giving precedence to
> `LD_LIBRARY_PATH` is the new behaviour, enabled via `--enable-new-dtags`; and
> at some
On Mon, 4 Mar 2024 13:52:13 GMT, Jan Lahoda wrote:
> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
> automatically granted the native access. I am working on an upgrade of JLine
> inside the `jdk.internal.le` module, and I would like to replace the current
>
On Mon, 4 Mar 2024 13:52:13 GMT, Jan Lahoda wrote:
> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
> automatically granted the native access. I am working on an upgrade of JLine
> inside the `jdk.internal.le` module, and I would like to replace the current
>
[JDK-8325340](https://bugs.openjdk.org/browse/JDK-8325340) accidentally removed
`final` from the `static final DataInputStream.readUTF` method. This has a
minor compatibility impact (allows hiding the method in a subclass, while
before that would throw an exception at compile time) and since it
Currently, JDK modules load by the bootstrap and platform ClassLoaders are
automatically granted the native access. I am working on an upgrade of JLine
inside the `jdk.internal.le` module, and I would like to replace the current
native bindings with FFM-based bindings (which are now somewhat
On Mon, 4 Mar 2024 12:58:28 GMT, Claudio Nieder wrote:
> > Could I trouble you to mention what exactly was different?
>
> No trouble at all.
>
> `CCACHE_BASEDIR=/tmp/bceaed6d/jdk/`is completely missing. (The directory is
> where I checked out OpenJDK)
>
> `CCACHE_SLOPPINESS` has the value
On Mon, 4 Mar 2024 11:45:59 GMT, Julian Waters wrote:
> Could I trouble you to mention what exactly was different?
No trouble at all.
`CCACHE_BASEDIR=/tmp/bceaed6d/jdk/`is completely missing. (The directory is
where I checked out OpenJDK)
`CCACHE_SLOPPINESS` has the value
On Mon, 4 Mar 2024 12:00:18 GMT, Adam Sotona wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to
On Mon, 4 Mar 2024 10:08:27 GMT, Claes Redestad wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update
>> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecoder.java
>>
>> Co-authored-by:
> ClassFile API performance related improvements have been separated from
> #17121 into this PR.
>
> These improvements are important to minimize performance regression of
> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the
> Classfile API to generate proxy classes #17121
>
On Mon, 4 Mar 2024 11:28:02 GMT, Magnus Ihse Bursie wrote:
> > I wonder if it's the SetupToolchain changes that has caused this. ccache is
> > collapsed into CC and CXX to my knowledge
>
> Yeah, it must have been. Would you like to take a look at it? Otherwise I'll
> file a bug and fix it.
On Mon, 4 Mar 2024 06:42:30 GMT, Julian Waters wrote:
> I wonder if it's the SetupToolchain changes that has caused this. ccache is
> collapsed into CC and CXX to my knowledge
Yeah, it must have been. Would you like to take a look at it? Otherwise I'll
file a bug and fix it. Breaking ccache
On Mon, 15 Jan 2024 12:01:37 GMT, Adam Sotona wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to
Please review this cleanup PR which suggests we remove the package-private,
unused and deprecated method `java.util.jar.Manifest.make72Safe`.
This method was marked deprecated after a cleanup/refactoring in
[JDK-8066619](https://bugs.openjdk.org/browse/JDK-8066619) caused it to fall
out of
On Mon, 15 Jan 2024 12:01:37 GMT, Adam Sotona wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to
On Sat, 2 Mar 2024 16:22:22 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather using hybrid algorithm which initially
>>
69 matches
Mail list logo
