> The current BigDecimal(String) constructor calls String#toCharArray, which
> has a memory allocation.
>
>
> public BigDecimal(String val) {
> this(val.toCharArray(), 0, val.length()); // allocate char[]
> }
>
>
> When the length is greater than 18, create a char[]
>
>
> boolean
On Fri, 26 Apr 2024 02:04:38 GMT, Joe Darcy wrote:
>>> @cl4es @jddarcy All feedback has been fixed, can it be integrated?
>>
>> Hello @wenshao ,
>>
>> This change will need additional review from myself or others who maintain
>> BigDecimal before it can be integrated.
>
>> @jddarcy Sorry for
On Thu, 25 Apr 2024 19:53:46 GMT, Claes Redestad wrote:
>> Splitting out the ASM-based version from #18690 to push that first under the
>> JBS (to help backporting). Keeping #18690 open to rebase and follow-up on
>> this as a subtask. See discussion in that #18690 for more details,
>>
On Thu, 25 Apr 2024 19:53:46 GMT, Claes Redestad wrote:
>> Splitting out the ASM-based version from #18690 to push that first under the
>> JBS (to help backporting). Keeping #18690 open to rebase and follow-up on
>> this as a subtask. See discussion in that #18690 for more details,
>>
On Wed, 24 Apr 2024 19:13:43 GMT, Claes Redestad wrote:
>> This patch suggests a workaround to an issue with huge SCF MH expression
>> trees taking excessive JIT compilation resources by reviving (part of) the
>> simple bytecode-generating strategy that was originally available as an
>>
On Thu, 25 Apr 2024 19:53:46 GMT, Claes Redestad wrote:
>> Splitting out the ASM-based version from #18690 to push that first under the
>> JBS (to help backporting). Keeping #18690 open to rebase and follow-up on
>> this as a subtask. See discussion in that #18690 for more details,
>>
On Tue, 19 Mar 2024 19:32:10 GMT, Joe Darcy wrote:
>> I think splitting `CharArraySequence` into two versions is somewhat dubious
>> as more observable types at call sites may mean the performance gain in
>> targeted micros is lost. How much of an improvement did you observe from
>> this?
> Remove unnecessary setting of variable y, found by an IDE inspection noted in
> the bug report.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year.
-
Changes:
- all:
On Thu, 25 Apr 2024 23:24:07 GMT, Jonathan Gibbons wrote:
>> Please review the updates to support a proposed new
>> `-Xlint:dangling-doc-comments` option.
>>
>> The work can be thought of as in 3 parts:
>>
>> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
>> is
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
On Thu, 25 Apr 2024 08:25:39 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> package spec updates, mostly about reference queues and dequeueing
>
>
On Thu, 25 Apr 2024 22:26:04 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
On Thu, 25 Apr 2024 22:57:50 GMT, Florent Guillaume wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Calculate length precisely
>
> src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java line
>
On Thu, 25 Apr 2024 22:26:04 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote:
> Remove unnecessary setting of variable y, found by an IDE inspection noted in
> the bug report.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023708504
> When analyzing (startup) performance of the Classfile API I found this
> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>
> Performance improves across the board in existing microbenchmarks:
>
> Name
>
On Thu, 25 Apr 2024 13:34:50 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote:
> Remove unnecessary setting of variable y, found by an IDE inspection noted in
> the bug report.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023687212
Remove unnecessary setting of variable y, found by an IDE inspection noted in
the bug report.
-
Commit messages:
- JDK-8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute
Changes: https://git.openjdk.org/jdk/pull/18963/files
Webrev:
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote:
> Remove unnecessary setting of variable y, found by an IDE inspection noted in
> the bug report.
All Math and StrictMath regression tests pass with this change. Examining the
code, y does look to be overwritten on all the code paths where it
On Thu, Apr 25, 2024 at 2:09 PM Pavel Rappo wrote:
>
>
> > On 25 Apr 2024, at 19:41, David Lloyd wrote:
> >
> > The JDK contains a few collection- and array-oriented implementations of
> binary search. For the most part, they all work the same way: search the
> target "thing" by index using the
java.time.* already has the `until(ChronoLocalDate)` method on
LocalDate. It would be reasonable to add a similar method to various
other classes. This potentially gives you
Duration dur = start.until(end)
I'm wary of adding the opposite (given until() is already there). I'm
particularly wary
On Tue, 23 Apr 2024 11:56:41 GMT, Adam Sotona wrote:
> This patch adds missing `@throws` javadoc annotations to
> `java.lang.classfile.BufWriter`.
>
> Please review.
>
> Thank you,
> Adam
Marked as reviewed by psandoz (Reviewer).
-
PR Review:
On Thu, 25 Apr 2024 00:51:41 GMT, Adam Sotona wrote:
> Unfortunately it would have to be an expected tags list or an extra
> constructed bit mask, due to the multiple tags allowed for MemberRefEntry and
> it would slightly affect the performance.
Ah yes, i missed that. It could be two tags,
On Thu, 25 Apr 2024 16:46:25 GMT, Chen Liang wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove accidental use of java.lang.classfile
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java
> Splitting out the ASM-based version from #18690 to push that first under the
> JBS (to help backporting). Keeping #18690 open to rebase and follow-up on
> this as a subtask. See discussion in that #18690 for more details, discussion
> and motivation for this.
Claes Redestad has updated the
> On 25 Apr 2024, at 19:41, David Lloyd wrote:
>
> The JDK contains a few collection- and array-oriented implementations of
> binary search. For the most part, they all work the same way: search the
> target "thing" by index using the obvious bisection strategy, returning
> either /index/
Hi core-libs-dev,
The java.time API already supports subtracting two Instants (end - start)
via Duration.between(Temporal, Temporal), but we've found the parameter
ordering (which requires a bit of "mental gymnastics") and API location to
be a bit unnatural.
Parameter Ordering
We very often see
The JDK contains a few collection- and array-oriented implementations of
binary search. For the most part, they all work the same way: search the
target "thing" by index using the obvious bisection strategy, returning
either /index/ or /-index-1/ depending on whether it was found at the end
of the
On 4/24/24 4:24 AM, Magnus Ihse Bursie wrote:
That is a good question. libiconv is used only on macOS and AIX, for a
few libraries, as you say. I just tried removing -liconv from the
macOS dependencies and recompiled, just to see what would happen.
There were three instances for macOS:
On Thu, 25 Apr 2024 14:15:56 GMT, Claes Redestad wrote:
> Splitting out the ASM-based version from #18690 to push that first under the
> JBS (to help backporting). Keeping #18690 open to rebase and follow-up on
> this as a subtask. See discussion in that #18690 for more details, discussion
>
On Mon, 22 Apr 2024 18:44:33 GMT, Naoto Sato wrote:
> Upgrading the CLDR to version 45.0. We now have versions specified in the
> javadoc (`LocaleServiceProvider`), a corresponding CSR has also been drafted.
This pull request has now been integrated.
Changeset: 1c238d43
Author:Naoto Sato
On Thu, 25 Apr 2024 13:34:50 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote:
> In the hashN usages of readCen from zip_util.c we see a lot of signed integer
> overflows.
> For example in the java/util jtreg tests those are easily reproducable when
> compiling with -ftrapv (clang/gcc toolchains).
> While those
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote:
> In the hashN usages of readCen from zip_util.c we see a lot of signed integer
> overflows.
> For example in the java/util jtreg tests those are easily reproducable when
> compiling with -ftrapv (clang/gcc toolchains).
> While those
> Performance. Before:
>
> Benchmark(algorithm) (dataSize) (keyLength)
> (provider) Mode Cnt ScoreError Units
> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> thrpt3 6443.934 ± 6.491 ops/s
>
On Tue, 16 Apr 2024 19:44:36 GMT, Roger Riggs wrote:
> The method `java.io.ObjectOutputStream.PutField.write` has been deprecated
> since 1.4 and should be deprecated for removal. The Deprecation annotation is
> updated to indicate the intention to remov the method.
This pull request has now
On Sat, 20 Apr 2024 11:49:30 GMT, Korov wrote:
> Fix the description of java.io.Serializable.
LGTM; trivial fix of example javadoc code
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18874#pullrequestreview-2022703632
On Thu, 25 Apr 2024 13:35:59 GMT, Chen Liang wrote:
> Do we have any research on the average length of method descriptor strings? I
> wonder if manual pre-allocation works better (iterating all descriptor
> strings, allocate the sum of their sizes plus 2 (for parentheses), as
> descriptor
> I added `@since` tags for methods/constructors that do not match the `@since`
> of the enclosing class.
>
> The `write` method already existed in `PrintStream` in earlier versions and
> instances of it could always call this method, since it extends
> `FilterOutputStream` [which has the
>
Splitting out the ASM-based version from #18690 to push that first under the
JBS (to help backporting). Keeping #18690 open to rebase and follow-up on this
as a subtask. See discussion in that #18690 for more details, discussion and
motivation for this.
-
Commit messages:
- Adapt
On Wed, 24 Apr 2024 10:05:27 GMT, Aleksey Shipilev wrote:
>>> I really wish this change was not done with ClassFile API, but with a
>>> simple bundled ASM, so it would be easily backportable, if we decide to. It
>>> does not look like CFA buys us a lot here readability/complexity wise:
>>>
On Thu, 25 Apr 2024 13:22:01 GMT, Matthias Baesken wrote:
>> We have already good JLI tracing capabilities. But GetApplicationHome and
>> GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional
On Thu, 25 Apr 2024 13:38:56 GMT, Viktor Klang wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comma-separated
>
> src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java line 208:
>
>> 206:
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now
> **Subject**
> Addition of Predicate-based `indexOf` and `lastIndexOf` methods to
> `java.util.List`
>
> **Motivation**
> The motivation behind this proposal is to enhance the functionality of the
> `List` interface by providing a more flexible way to find the index of an
> element.
On Thu, 25 Apr 2024 13:34:50 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
On Thu, 25 Apr 2024 13:34:50 GMT, Claes Redestad wrote:
>> When analyzing (startup) performance of the Classfile API I found this
>> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>>
>> Performance improves across the board in existing microbenchmarks:
>>
>> Name
> When analyzing (startup) performance of the Classfile API I found this
> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>
> Performance improves across the board in existing microbenchmarks:
>
> Name
>
On Thu, 25 Apr 2024 11:11:48 GMT, Florent Guillaume wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comma-separated
>
> src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java line 210:
>
>> 208:
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
remove /jre path check
On Tue, 23 Apr 2024 14:31:44 GMT, Matthias Baesken wrote:
>> We have already good JLI tracing capabilities. But GetApplicationHome and
>> GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional
> **Subject**
> Addition of Predicate-based `indexOf` and `lastIndexOf` methods to
> `java.util.List`
>
> **Motivation**
> The motivation behind this proposal is to enhance the functionality of the
> `List` interface by providing a more flexible way to find the index of an
> element.
On Tue, 23 Apr 2024 14:29:05 GMT, Matthias Baesken wrote:
>
> `/* Does the app ship a private JRE in /jre directory? */`
>
> part meant? This looks indeed obsolete .
Yes, this is code that doesn't make sense since JDK 9 and should be
removed/cleanup at some point. I suspect we had to leave
On Tue, 23 Apr 2024 14:31:44 GMT, Matthias Baesken wrote:
>> We have already good JLI tracing capabilities. But GetApplicationHome and
>> GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional
On Wed, 24 Apr 2024 15:27:23 GMT, Raffaello Giulietti
wrote:
>> Move all random generators mandated in package `java.util.random` and
>> currently implemented in module `jdk.random` to module `java.base`, and
>> remove module `jdk.random`.
>
> Raffaello Giulietti has updated the pull request
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote:
> In the hashN usages of readCen from zip_util.c we see a lot of signed integer
> overflows.
> For example in the java/util jtreg tests those are easily reproducable when
> compiling with -ftrapv (clang/gcc toolchains).
> While those
On Tue, 19 Mar 2024 19:32:10 GMT, Joe Darcy wrote:
>> I think splitting `CharArraySequence` into two versions is somewhat dubious
>> as more observable types at call sites may mean the performance gain in
>> targeted micros is lost. How much of an improvement did you observe from
>> this?
On Thu, 25 Apr 2024 09:41:11 GMT, Claes Redestad wrote:
> When analyzing (startup) performance of the Classfile API I found this
> opportunity to further improve `MethodTypeDescImpl::descriptorString`.
>
> Performance improves across the board in existing microbenchmarks:
>
> Name
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote:
> In the hashN usages of readCen from zip_util.c we see a lot of signed integer
> overflows.
> For example in the java/util jtreg tests those are easily reproducable when
> compiling with -ftrapv (clang/gcc toolchains).
> While those
When analyzing (startup) performance of the Classfile API I found this
opportunity to further improve `MethodTypeDescImpl::descriptorString`.
Performance improves across the board in existing microbenchmarks:
Name
(descString) Cnt
On Wed, 24 Apr 2024 23:15:45 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
On Thu, 25 Apr 2024 07:56:59 GMT, Adam Sotona wrote:
> Pr/18914 broke tests build.
> This patch fixes
> `test/micro/org/openjdk/bench/jdk/classfile/CodeAttributeTools`
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: ef745a6c
Author:Adam Sotona
On Thu, 25 Apr 2024 07:56:59 GMT, Adam Sotona wrote:
> Pr/18914 broke tests build.
> This patch fixes
> `test/micro/org/openjdk/bench/jdk/classfile/CodeAttributeTools`
>
> Please review.
>
> Thanks,
> Adam
Marked as reviewed by alanb (Reviewer).
-
PR Review:
Pr/18914 broke tests build.
This patch fixes `test/micro/org/openjdk/bench/jdk/classfile/CodeAttributeTools`
Please review.
Thanks,
Adam
-
Commit messages:
- 8331097: Tests build is broken after pr/18914
Changes: https://git.openjdk.org/jdk/pull/18943/files
Webrev:
On Tue, 23 Apr 2024 12:59:18 GMT, Adam Sotona wrote:
> ClassFile API `StackMapGenerator` attaches print or hex dump of the method to
> an error message.
> However there is no such attachment when the stack maps generation is turned
> off.
>
> This patch moves class print/dump to
> ClassFile API `StackMapGenerator` attaches print or hex dump of the method to
> an error message.
> However there is no such attachment when the stack maps generation is turned
> off.
>
> This patch moves class print/dump to `impl.Util::dumpMethod`, so it is shared
> by `StackMapGenerator`
On Wed, 24 Apr 2024 22:48:30 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied suggested changes
>
> src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 229:
>
>> 227:
On Wed, 24 Apr 2024 22:43:21 GMT, Paul Sandoz wrote:
> This looks good, but for completeness it will need a CSR.
CSR created, thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/18913#issuecomment-2076498451
72 matches
Mail list logo
