Re: What methods should go into a java.util.Objects class in JDK 7?

2009-10-13 Thread Alan Bateman
Ulf Zibis wrote: : In java.nio.file.Filesystem b72 I don't find information about sharing attributes. These are provider specific open options so they aren't in the javadoc. If you look at the dosSharingOptionTests in jdk/test/java/nio/Path/SBC.java you will see tests for these options.

Re: j.ul.Objects follow-up: methods for var-argification?

2009-10-13 Thread Rémi Forax
Le 12/10/2009 20:41, Joseph D. Darcy a écrit : Rémi Forax wrote: Le 12/10/2009 19:25, Joseph D. Darcy a écrit : Joshua Bloch wrote: Joe, I'm not sure I like this idea. My one experience with forcing an array method to do double duty as varargs method was a disaster. The method was

Re: j.ul.Objects follow-up: methods for var-argification?

2009-10-13 Thread Bob Lee
On Mon, Oct 12, 2009 at 12:52 PM, Rémi Forax fo...@univ-mlv.fr wrote: It's not a good idea to have a hashCode() that allocate objects, at least until escape analysis is implemented in all VMs. Agree with Joe--these methods don't carry their weight. If the allocation is too much to bear, it's

Re: First round of java.util.Objects for code review (bug 6797535)

2009-10-13 Thread Joshua Bloch
Joe, Thanks very much! Josh On Tue, Oct 13, 2009 at 11:12 AM, Joseph D. Darcy joe.da...@sun.com wrote: Joshua Bloch wrote: Joe, Hi. I've attached a file containing the methods and a JTReg basic test for inclusion in your BasicObjectTests. I adhered to your style, for easy

Re: j.ul.Objects follow-up: methods for var-argification?

2009-10-13 Thread Joseph D. Darcy
Rémi Forax wrote: Le 12/10/2009 19:25, Joseph D. Darcy a écrit : Joshua Bloch wrote: Joe, I'm not sure I like this idea. My one experience with forcing an array method to do double duty as varargs method was a disaster. The method was Arrays.asList, and the result was Puzzler # 7 from

Re: j.u.Objects follow-up: deepEquals(Object, Object)?

2009-10-13 Thread Joseph D. Darcy
Joshua Bloch wrote: I don't think method really pays for itself. If it belongs anywhere, it belongs in java.util.Arrays. Josh I think there is room in the platform for this functionality. Even if this is mostly used in tests, code used in tests is code too :-) I think Objects

Re: First round of java.util.Objects for code review (bug 6797535)

2009-10-13 Thread Joshua Bloch
Joe, Hi. I've attached a file containing the methods and a JTReg basic test for inclusion in your BasicObjectTests. I adhered to your style, for easy integration. If you could take it from here, I'd be ever so grateful. Thanks, Josh On Thu, Oct 8, 2009 at 6:21 PM, Joe Darcy

hg: jdk7/tl/jdk: 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap

2009-10-13 Thread joe . darcy
Changeset: 151baf5e19ca Author:darcy Date: 2009-10-13 17:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/151baf5e19ca 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap Reviewed-by: martin ! src/share/classes/java/lang/Enum.java