Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-04-02 Thread Miloslav Trmač
The other thing that would be nice would be a way to get the real admin group, rather than just guessing that it's wheel. Unfortunately, with JavaScript in the picture, this question does not have a well-defined/stable answer. (It could change from call to call, in pathological

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-04-01 Thread Bastien Nocera
On Tue, 2015-03-31 at 21:35 -0500, Michael Catanzaro wrote: On Tue, 2015-03-31 at 21:50 +0200, Jakub Filak wrote: What about these patches: https://github.com/abrt/abrt/pull/946 That's exactly what I had in mind (though it would be better to remove the mysterious Other column

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-04-01 Thread Michael Catanzaro
On Wed, 2015-04-01 at 15:16 -0400, Miloslav Trmač wrote: _authentication as that user_ is what is requires. Hm, I read that to be satisfied by logging in at gdm (providing authentication), but you read it to require authentication when the action is performed. I think your interpretation is

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-04-01 Thread Miloslav Trmač
Hello, We should chat with Miloslav Trmač (mitr) about this. I've added him to CC, hi Miloslav! The goal here is to use polkit to express the rule local admins can perform the action without entering any password, but non-admin users must enter an admin password. Hum. Doesn’t

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-04-01 Thread Miloslav Trmač
On Wed, 2015-04-01 at 13:37 -0400, Miloslav Trmač wrote: Hello, We should chat with Miloslav Trmač (mitr) about this. I've added him to CC, hi Miloslav! The goal here is to use polkit to express the rule local admins can perform the action without entering any password, but

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-04-01 Thread Michael Catanzaro
On Wed, 2015-04-01 at 13:37 -0400, Miloslav Trmač wrote: Hello, We should chat with Miloslav Trmač (mitr) about this. I've added him to CC, hi Miloslav! The goal here is to use polkit to express the rule local admins can perform the action without entering any password, but non-admin

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-03-31 Thread Jakub Filak
What about these patches: https://github.com/abrt/abrt/pull/946 Regards, Jakub

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-03-02 Thread Jakub Filak
On Monday 02 of March 2015 16:26:56 Bastien Nocera wrote: On Mon, 2015-03-02 at 16:16 +0100, Jakub Filak wrote: On Wednesday 25 of February 2015 17:09:41 Bastien Nocera wrote: This allows gnome-abrt to not query for a password when an administrator opens gnome-abrt. ---

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-03-02 Thread Jakub Filak
On Wednesday 25 of February 2015 17:09:41 Bastien Nocera wrote: This allows gnome-abrt to not query for a password when an administrator opens gnome-abrt. --- src/dbus/abrt_polkit.policy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dbus/abrt_polkit.policy

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-03-02 Thread Bastien Nocera
On Mon, 2015-03-02 at 16:16 +0100, Jakub Filak wrote: On Wednesday 25 of February 2015 17:09:41 Bastien Nocera wrote: This allows gnome-abrt to not query for a password when an administrator opens gnome-abrt. --- src/dbus/abrt_polkit.policy | 2 +- 1 file changed, 1

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-02-26 Thread Michael Catanzaro
On Thu, Feb 26, 2015 at 5:21 AM, Bastien Nocera had...@hadess.net wrote: No, you're completely correct. This only makes sense if I also filter problems in the GetAll() method to only send back problems that are relevant to the user on the other side of the bus. I didn't read your patch, I just

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-02-26 Thread Bastien Nocera
On Wed, 2015-02-25 at 22:03 -0600, Michael Catanzaro wrote: On Wed, Feb 25, 2015 at 10:00 PM, Michael Catanzaro mcatanz...@gnome.org wrote: So I know I REALLY shouldn't comment on patches late at night I probably should have read your other patch, the one that added ACLs, before

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-02-25 Thread Michael Catanzaro
So I know I REALLY shouldn't comment on patches late at night so I hope what I'm about to say isn't stupid... but surely that allows *anyone* to read the reports without a password, no? I don't think polkit has any proper way to do what you want to do. We should really change that, but in the

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-02-25 Thread Michael Catanzaro
On Wed, Feb 25, 2015 at 10:00 PM, Michael Catanzaro mcatanz...@gnome.org wrote: So I know I REALLY shouldn't comment on patches late at night I probably should have read your other patch, the one that added ACLs, before responding. Yawn