Re: [PATCH] applet: Use GSettings to check whether to send uReports

2015-01-19 Thread Bastien Nocera
On Wed, 2015-01-14 at 17:00 +0100, Bastien Nocera wrote: On Wed, 2015-01-14 at 16:50 +0100, Jakub Filak wrote: +PKG_CHECK_MODULES([GSETTINGS_DESKTOP_SCHEMAS], [gsettings-desktop-schemas = 3.15.1]) I am sorry but where can I get gsettings-desktop-schemas = 3.15.1? In git master

Re: [PATCH] applet: Use GSettings to check whether to send uReports

2015-01-14 Thread Bastien Nocera
On Wed, 2015-01-14 at 16:13 +0100, Jakub Filak wrote: On Wednesday 14 of January 2015 14:22:50 Bastien Nocera wrote: On Wed, 2015-01-14 at 13:54 +0100, Jakub Filak wrote: On Wednesday 14 of January 2015 13:43:59 Bastien Nocera wrote: On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote

Re: [PATCH] build: Launch configure after autogen.sh

2015-01-21 Thread Bastien Nocera
On Wed, 2015-01-14 at 12:06 +0100, Bastien Nocera wrote: As is common amongst other autotools-based projects. Any comments on this?

Re: [PATCH] applet: Remove pointless custom signal handling

2015-01-14 Thread Bastien Nocera
On Wed, 2015-01-14 at 14:09 +0100, Jakub Filak wrote: On Wednesday 14 of January 2015 12:06:21 Bastien Nocera wrote: None of the actions we're supposed to be taking after the main loop should be necessary at that point in time. Let GTK+ handle that as it should by exiting if the SIGTERM

Re: [PATCH] applet: Use GSettings to check whether to send uReports

2015-01-14 Thread Bastien Nocera
On Wed, 2015-01-14 at 13:54 +0100, Jakub Filak wrote: On Wednesday 14 of January 2015 13:43:59 Bastien Nocera wrote: On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote: Thank you for the patch! Is there any possibility to detect whether the gsetting has the default value in order

[PATCH] applet: Use GNetworkMonitor instead of NM directly

2015-01-14 Thread Bastien Nocera
GLib 2.44 (and development version 2.43) has support for checking the connectivity level. This nicely replaces all the custom code that talked to NetworkManager directly. --- configure.ac| 2 +- src/applet/applet.c | 146 ++-- 2 files

Re: [PATCH] applet: Use GNetworkMonitor instead of NM directly

2015-01-14 Thread Bastien Nocera
On Wed, 2015-01-14 at 14:26 +0100, Jakub Filak wrote: Cool, I like this patch. Are there any plans for GLib 2.43 in Fedora 21? No, it will be in Fedora 22 along with GNOME 3.16.

[PATCH] applet: Remove pointless custom signal handling

2015-01-14 Thread Bastien Nocera
None of the actions we're supposed to be taking after the main loop should be necessary at that point in time. Let GTK+ handle that as it should by exiting if the SIGTERM signal is sent. --- src/applet/applet.c | 48 1 file changed, 48 deletions(-)

[PATCH] build: Launch configure after autogen.sh

2015-01-14 Thread Bastien Nocera
As is common amongst other autotools-based projects. --- autogen.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/autogen.sh b/autogen.sh index 5468271..acdb621 100755 --- a/autogen.sh +++ b/autogen.sh @@ -68,3 +68,5 @@ case $1 in automake --add-missing --force --copy || exit

Re: [PATCH] applet: Use GSettings to check whether to send uReports

2015-01-14 Thread Bastien Nocera
On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote: Thank you for the patch! Is there any possibility to detect whether the gsetting has the default value in order to be able to fallback to the ABRT configuration files? Why? You expect the Privacy settings in GNOME to read the abrt config

[PATCH] applet: Remove pre-glib 2.32 code

2015-01-14 Thread Bastien Nocera
As we bumped the GLib requirements, there's no need to keep code to support older versions. --- src/applet/applet.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/applet/applet.c b/src/applet/applet.c index 4d2949c..5778263 100644 --- a/src/applet/applet.c +++

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-04-01 Thread Bastien Nocera
On Tue, 2015-03-31 at 21:35 -0500, Michael Catanzaro wrote: On Tue, 2015-03-31 at 21:50 +0200, Jakub Filak wrote: What about these patches: https://github.com/abrt/abrt/pull/946 That's exactly what I had in mind (though it would be better to remove the mysterious Other column

[PATCH] dump_dir: Allow admins to modify and delete reports

2015-03-02 Thread Bastien Nocera
Bastien Nocera had...@hadess.net +Copyright (C) 2011, 2013 Lennart Poettering• +Copyright (C) 2015 RedHat inc. + +This program is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software

Re: [PATCH] dump_dir: Allow admins to modify and delete reports

2015-03-02 Thread Bastien Nocera
On Mon, 2015-03-02 at 12:55 +0100, Bastien Nocera wrote: Administrators should be able to report, modify and delete reports for other users. But we still want users for which the crashes occurred to be able to report them themselves. Never mind, I already sent it.

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-03-02 Thread Bastien Nocera
On Mon, 2015-03-02 at 16:16 +0100, Jakub Filak wrote: On Wednesday 25 of February 2015 17:09:41 Bastien Nocera wrote: This allows gnome-abrt to not query for a password when an administrator opens gnome-abrt. --- src/dbus/abrt_polkit.policy | 2 +- 1 file changed, 1 insertion

Re: [PATCH] spec: Don't allow users to list problems by hand

2015-03-02 Thread Bastien Nocera
On Mon, 2015-03-02 at 16:15 +0100, Jakub Filak wrote: On Wednesday 25 of February 2015 17:29:11 Bastien Nocera wrote: abrt-dbus already allows users to list problems, and will make sure of filtering out problems that the user is not allowed to interact with. To avoid users knowing

[PATCH libreport] dbus: Allow admins to load problems without a password

2015-02-25 Thread Bastien Nocera
This allows gnome-abrt to not query for a password when an administrator opens gnome-abrt. --- src/dbus/abrt_polkit.policy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dbus/abrt_polkit.policy b/src/dbus/abrt_polkit.policy index a3425d9..a127b8f 100644 ---

[PATCH libreport] dump_dir: Allow admins to modify and delete reports

2015-02-25 Thread Bastien Nocera
) +$(SATYR_LIBS) \ +$(ACL_LIBS) libreportconfdir = $(CONF_DIR) dist_libreportconf_DATA = \ diff --git a/src/lib/acl_util.c b/src/lib/acl_util.c new file mode 100644 index 000..fefbe1c --- /dev/null +++ b/src/lib/acl_util.c @@ -0,0 +1,118 @@ +/* +Copyright (C) 2015 Bastien Nocera had

[PATCH] spec: Don't allow users to list problems by hand

2015-02-25 Thread Bastien Nocera
abrt-dbus already allows users to list problems, and will make sure of filtering out problems that the user is not allowed to interact with. To avoid users knowing that particular problems are being created for another user, make sure that /var/tmp/abrt is not listable. --- abrt.spec.in | 2 +- 1

Re: [PATCH libreport] dbus: Allow admins to load problems without a password

2015-02-26 Thread Bastien Nocera
On Wed, 2015-02-25 at 22:03 -0600, Michael Catanzaro wrote: On Wed, Feb 25, 2015 at 10:00 PM, Michael Catanzaro mcatanz...@gnome.org wrote: So I know I REALLY shouldn't comment on patches late at night I probably should have read your other patch, the one that added ACLs, before