The Last occurence column in abrt-gui showed month twice and no day.
---
src/gui-gtk/main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/gui-gtk/main.c b/src/gui-gtk/main.c
index b62e8c0..732eed8 100644
--- a/src/gui-gtk/main.c
+++ b/src/gui-gtk/main.c
@@ -67,7
This should fix bug #300.
---
src/cli/cli.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/cli/cli.c b/src/cli/cli.c
index 49484c3..e356f5e 100644
--- a/src/cli/cli.c
+++ b/src/cli/cli.c
@@ -322,7 +322,7 @@ int main(int argc, char** argv)
{
On Tue, Jul 26, 2011 at 11:43:35 +0200, Nikola Pajkovsky wrote:
+OPT_list_events = 1 0,
+OPT_run_event= 1 1,
+OPT_analyze = 1 2,
+OPT_report = 1 3,
+OPT_version = 1 4,
+OPT_delete = 1 5,
+OPTMASK_op
On Tue, Jul 26, 2011 at 11:43:35 +0200, Nikola Pajkovsky wrote:
+OPT_list_events = 1 0,
+OPT_run_event= 1 1,
+OPT_analyze = 1 2,
+OPT_report = 1 3,
+OPT_version = 1 4,
+OPT_delete = 1 5,
+OPTMASK_op
Fixes #324.
---
src/daemon/abrt-action-save-package-data.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/daemon/abrt-action-save-package-data.c
b/src/daemon/abrt-action-save-package-data.c
index d37a05d..ddcf4ac 100644
---
Not meant to be pushed yet.
---
src/gui-wizard-gtk/wizard.c | 13 +
src/gui-wizard-gtk/wizard.h |1 +
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index aba044e..5f7a203 100644
---
rewritten as such events
and included are also two events that attach vim's configuration files when the
editor crashes.
I'll be grateful for any comments.
Martin Milata (7):
wizard: add new pages for the collect events
wizard: collect events - GUI state updating
wizard: collect events - next
---
src/gui-wizard-gtk/wizard.c | 38 +++
src/gui-wizard-gtk/wizard.glade | 140 +--
2 files changed, 159 insertions(+), 19 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index aba044e..63cc6c6 100644
---
---
src/gui-wizard-gtk/wizard.c | 28
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 5270812..0fc8a30 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@
---
src/gui-wizard-gtk/wizard.c | 32 +---
1 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 40de5ae..5270812 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@
The function run_events() is general enough to run arbitrary list of
events, but it prints some reporting-specific string. This chage makes
the function accept part of these strings as an argument.
---
src/cli/cli-report.c | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
Collect events are run both in report mode (-r) and in standalone
collect mode (-c).
---
src/cli/cli-report.c | 78 ++
src/cli/cli-report.h |1 +
src/cli/cli.c|9 ++
3 files changed, 88 insertions(+), 0 deletions(-)
diff --git
---
abrt.spec.in |2 +-
src/plugins/Makefile.am |4 ++--
src/plugins/analyze_Smolt.xml.in |9 -
src/plugins/collect_Smolt.xml.in |9 +
src/plugins/smolt_event.conf |2 +-
5 files changed, 13 insertions(+), 13 deletions(-)
---
src/cli/report-cli.txt | 27 +++
1 files changed, 7 insertions(+), 20 deletions(-)
diff --git a/src/cli/report-cli.txt b/src/cli/report-cli.txt
index 7ee1170..30bbfa2 100644
--- a/src/cli/report-cli.txt
+++ b/src/cli/report-cli.txt
@@ -7,19 +7,15 @@ report-cli -
Should I also do something to update the .po files?
---8---8---8---8---8---
---
src/gui-wizard-gtk/wizard.glade |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.glade b/src/gui-wizard-gtk/wizard.glade
index 3d84dc8..593d1d7 100644
---
The g_settings_dump_location was freed before it was passed to the free
space check, thus preventing it from working.
---
src/daemon/abrt-server.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/daemon/abrt-server.c b/src/daemon/abrt-server.c
index 983706e..330f85f
The python exception handler used to send data to abrtd, print the
traceback and then exit. If it finished sooner that abrt-server managed
to read its /proc entry, the cmdline item ended up empty.
Fixed it to wait for response from abrtd (and write to syslog if
anything's wrong).
---
This is an attempt to solve #304 (wrong title when reporting from
setroubleshoot). SETroubleshoot does not provide the name of the
application in question (or was setroubleshoot itself meant as the
application name?), so this patch uses the 'reason' item instead of the
dump dir path. This is IMHO
This will solve #303 if my patch to setroubleshoot is accepted.
--88888888--
* The --prgname option was removed, because it did nothing as it was
processed after calling gtk_init().
* Environmental variable LIBREPORT_PRGNAME can be used instead.
* Function
Doesn't really make sense, as it is always path to the python
executable. bz#741255
---
src/include/problem_data.h |3 +++
src/lib/problem_data.c |5 +
src/report-python/problem_data.c |8
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git
-- I overlooked the other use-case and assumed that the python
bindings are only used to report problems which have nothing to do with
current process (as is the case with Sealert).
On 20.10.2011 12:31, Martin Milata wrote:
Doesn't really make sense, as it is always path to the python
executable
Do not call add_basics() in createAlertSignature, which is probably only
used by Sealert. The method detects and adds executable item containing
path to the executable of the current process, which is useless as the
report is not about current process.
---
src/report-python/__init__.py |2 +-
These patches implement what is described at [1] except for items 2.6, 3.4 and
4.* in the 'Scope' section. In other words, almost everything except the
assembly fingerprinting is done and should be able to replace the current
duplicate detection mechanism which compares UUIDs. Some information can
---
src/include/dump_dir.h |2 +-
src/lib/dump_dir.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/include/dump_dir.h b/src/include/dump_dir.h
index 6d77a49..fbd13b6 100644
--- a/src/include/dump_dir.h
+++ b/src/include/dump_dir.h
@@ -54,7 +54,7 @@ struct
So that they can be reused
---
src/include/libabrt.h|4 +
src/lib/hooklib.c| 170 ++
src/plugins/Makefile.am |3 +-
src/plugins/abrt-action-analyze-c.c | 78
Program to allow creation of coredump-level backtraces.
The disassembly support is incomplete and is turned off by default
Enable it by passing '--enable-dupcheck-fingerprint' to ./configure. It
can be enabled only on x86_64 CPU. Note that it adds dependency on
libelf and libdw.
---
abrt.spec.in
Used instead of comparing UUIDs for crashes that have the backtrace.
Note that a check whether a dump dir has a UUID element was removed.
Introduces gdb dependency to abrt-addon-ccpp.
---
abrt.spec.in |1 +
src/daemon/abrt-handle-event.c | 56
Here's another attempt at solving the bug. It adds a flag to
add_basics_to_problem_data indicating whether or not we are interested about
data from current process. Additionally, it adds optional argument to
createAlertSignature, which can be used by sealert to pass the executable
directly.
On Mon, Nov 28, 2011 at 15:38:22 +0100, Denys Vlasenko wrote:
On Wed, 2011-11-23 at 12:42 +0100, Martin Milata wrote:
Used instead of comparing UUIDs for crashes that have the backtrace.
Note that a check whether a dump dir has a UUID element was removed.
Introduces gdb dependency to abrt
Here's another attempt at solving the bug. It adds a flag to
add_basics_to_problem_data indicating whether or not we are interested about
data from current process. Additionally, it adds optional argument to
createAlertSignature, which can be used by sealert to pass the executable
directly.
---
src/include/internal_libreport.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/include/internal_libreport.h b/src/include/internal_libreport.h
index 7b2d2e7..1ab3627 100644
--- a/src/include/internal_libreport.h
+++ b/src/include/internal_libreport.h
@@ -650,6
---
src/plugins/abrt-action-generate-backtrace.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/plugins/abrt-action-generate-backtrace.c
b/src/plugins/abrt-action-generate-backtrace.c
index 2e795b2..6add077 100644
---
---
src/plugins/abrt-action-generate-backtrace.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/plugins/abrt-action-generate-backtrace.c
b/src/plugins/abrt-action-generate-backtrace.c
index 7fafaad..b28a2ba 100644
--- a/src/plugins/abrt-action-generate-backtrace.c
So that they can be reused
---
src/include/libabrt.h|4 +
src/lib/hooklib.c| 170 ++
src/plugins/Makefile.am |3 +-
src/plugins/abrt-action-analyze-c.c | 78
Introduces gdb dependency to abrt-addon-ccpp. It also removes a check
whether a post-create event creates the UUID item.
---
abrt.spec.in |1 +
src/daemon/Makefile.am |4 +-
src/daemon/abrt-handle-event.c | 389 ++--
Here's another attempt at solving the bug. It adds a flag to
add_basics_to_problem_data indicating whether or not we are interested about
data from current process. Additionally, it adds optional argument to
createAlertSignature, which can be used by sealert to pass the executable
directly.
---
src/include/dump_dir.h |2 +-
src/lib/dump_dir.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/include/dump_dir.h b/src/include/dump_dir.h
index 6d77a49..fbd13b6 100644
--- a/src/include/dump_dir.h
+++ b/src/include/dump_dir.h
@@ -54,7 +54,7 @@ struct
Used by the coredump-based backtrace duplicate detection in ABRT.
---
src/include/internal_libreport.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/include/internal_libreport.h b/src/include/internal_libreport.h
index 4c50a26..bf5df8b 100644
---
---
src/include/internal_libreport.h | 16
src/lib/strbuf.c | 24 +---
2 files changed, 33 insertions(+), 7 deletions(-)
diff --git a/src/include/internal_libreport.h b/src/include/internal_libreport.h
index bf5df8b..1b97c30 100644
---
---
src/plugins/abrt-action-generate-backtrace.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/plugins/abrt-action-generate-backtrace.c
b/src/plugins/abrt-action-generate-backtrace.c
index 2e795b2..6add077 100644
---
So that they can be reused. Code of the functions is unchanged.
---
src/include/libabrt.h|4 +
src/lib/hooklib.c| 170 ++
src/plugins/Makefile.am |3 +-
src/plugins/abrt-action-analyze-c.c
---
src/plugins/abrt-action-generate-backtrace.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/plugins/abrt-action-generate-backtrace.c
b/src/plugins/abrt-action-generate-backtrace.c
index 7fafaad..b28a2ba 100644
--- a/src/plugins/abrt-action-generate-backtrace.c
Introduces gdb dependency to abrt-addon-ccpp. It also removes a check
whether a post-create event creates the UUID item.
---
abrt.spec.in |1 +
src/daemon/Makefile.am |4 +-
src/daemon/abrt-handle-event.c | 376 ++--
Every problem data item that is marked as text is now checked for
utf8-validity in load_problem_data_from_dump_dir function. If it is not,
invalid bytes are replaced by their numerical representation.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=750151
---
src/include/internal_libreport.h |
Hi,
I went through your suggestions and modified the patches accordingly.
The ones that were ok are pushed now, except the last libreport patch,
which may change if we decide to use different name than 'canonical
backtraces'.
Note that I also reverted the removal of the needless assignment
scn
Introduces gdb dependency to abrt-addon-ccpp.
Copypasted description of current dup detection algorithm:
This function is run after each post-create event is finished (there may
be multiple such events).
It first checks if there is CANONICAL_BACKTRACE or UUID item in the dump
dir we are
In abrt-handle-event. This also removes the check whether UUID item was
created during post-create events -- it is not loaded when doing
canonical-backtrace-based check and while it's still created, it is in
principle not neccessary for CCpp checks (as it is not used anywhere
else anyway).
---
suggestions.
Thanks,
Martin
[1] http://fedoraproject.org/wiki/Features/MiniDebugInfo
[2] https://github.com/b42/libunwind/tree/minidebuginfo
* * *
Martin Milata (5):
Make coredump test also test unw_get_proc_name
Add liblzma detection to configure script
MiniDebugInfo test: tests/run-coredump
Signed-off-by: Martin Milata mmil...@redhat.com
---
tests/run-coredump-unwind|8 ++--
tests/test-coredump-unwind.c | 20
2 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/tests/run-coredump-unwind b/tests/run-coredump-unwind
index 18060c5..d6dd7e0
Signed-off-by: Martin Milata mmil...@redhat.com
---
configure.in| 16
src/Makefile.am |3 +++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/configure.in b/configure.in
index a1cf650..31bf4bd 100644
--- a/configure.in
+++ b/configure.in
@@ -236,6
Signed-off-by: Martin Milata mmil...@redhat.com
---
src/elfxx.c | 123 --
1 files changed, 85 insertions(+), 38 deletions(-)
diff --git a/src/elfxx.c b/src/elfxx.c
index 2d5aacc..514033d 100644
--- a/src/elfxx.c
+++ b/src/elfxx.c
@@ -29,6
Test that creates MiniDebugInfo-containing binary and then checks if it
can recover the procedure names from its coredump.
Signed-off-by: Martin Milata mmil...@redhat.com
---
tests/Makefile.am |7 ++-
tests/run-coredump-unwind | 39
returns a symbol when it finds one that is closer than indicated by
the parameter.
Signed-off-by: Martin Milata mmil...@redhat.com
---
src/elfxx.c | 158 +++---
1 files changed, 149 insertions(+), 9 deletions(-)
diff --git a/src/elfxx.c b/src
On Sat, Aug 11, 2012 at 21:34:35 -0700, Arun Sharma wrote:
On Fri, Aug 10, 2012 at 7:03 AM, Martin Milata mmil...@redhat.com wrote:
+ /* Closer symbol was found (possibly truncated). */
+ if (ret_mdi == 0 || ret_mdi == -UNW_ENOMEM)
+ {
+ ret = ret_mdi
Here's rehash of an old patch[1] that tries to solve the problem in the
subject[2]. Current sealert will produce reports with no 'executable' item
using this code, and patch to sealert could make it possible to set the correct
executable.
The patch splits detection of information about current
On Wed, Sep 26, 2012 at 10:31:33 +0200, Jiri Moskovcak wrote:
@@ -718,6 +740,11 @@ static int create_pidfile()
if (lockf(fd, F_TLOCK, 0) 0)
{
perror_msg(Can't lock file '%s', VAR_RUN_PIDFILE);
+/* should help with problems like rhbz#859724 */
+
I just briefly tested the patch and found two problems:
- The forbidden words are sometimes highlighted and sometimes not, I
didn't notice what it depends on.
- The arrows for next/prev match do not work as expected sometimes,
steps to reproduce:
1. Write asdf foobar when the wizard
Works as expected now, good work:)
On Thu, Oct 04, 2012 at 10:51:10 +0200, Jakub Filak wrote:
On Thursday 27 of September 2012 12:04:19 Martin Milata wrote:
I just briefly tested the patch and found two problems:
- The forbidden words are sometimes highlighted and sometimes not, I
---
lib/core-backtrace-oops.c | 53 +++
tests/Makefile.am | 2 +-
tests/Makefile.in | 2 +-
tests/atlocal.in | 2 +-
tests/corebt-oops.at | 228 ++
tests/testsuite.at| 1 +
6 files changed, 285
The patch works as expected.
Personally, I would prefer to insert the unwound events back into the
events_list in get_next_processed_event (as you suggested on IRC)
instead of keeping them in new global variable, though.
Martin
On Tue, Oct 09, 2012 at 13:02:22 +0200, Jakub Filak wrote:
- for
---
lib/Makefile.am | 1 +
lib/Makefile.in | 12 -
lib/normalize.h | 7 +
lib/normalize_oops.c | 73
tests/normalize.at | 49 +++
5 files changed, 141 insertions(+), 1 deletion(-)
I think this one's OK, except one thing (see below).
On Wed, Oct 10, 2012 at 15:47:14 +0200, Jakub Filak wrote:
- for a crash of vim the command $ 'report-gtk -e collect_* --
$DUMP_DIR' will execute in the current default configuration the
following list of events:
collect_smolt
These patches look alright to me.
On Mon, Nov 05, 2012 at 17:43:55 +0100, Jakub Filak wrote:
+if (cnt == sz - 1)
+{ /* this should not happen but */
+/* I guess, it's a bit better approach then simple failure */
Is this needed? If I understand the documentation [1] correctly, this is
the default behaviour.
With the default settings of None, no redirection will occur; the
child’s file handles will be inherited from the parent.
[1] http://docs.python.org/2/library/subprocess.html#subprocess.Popen
On Tue,
I run-tested the branch and it seems to be working well. I also reviewed
the code but due to my lack of experience with gtk/dbus/libnotify/NM I
probably missed the major flaws if there are any:) For smaller issues,
see my comments inline.
Side notes:
- How can I trigger unknown problem without
Looks alright to me.
On Tue, Jan 15, 2013 at 12:57:19 +0100, Jiri Moskovcak wrote:
- we don't want to follow symlinks
---
src/dbus/abrt-dbus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/dbus/abrt-dbus.c b/src/dbus/abrt-dbus.c
index c8e0bac..5a58160 100644
Looks alright to me. Except that debugging is spelled with 2 Gs ;)
On Tue, Feb 12, 2013 at 15:21:28 +0100, Jakub Filak wrote:
- closes #606
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/dbus/abrt-dbus.c | 29 ++---
1 file changed, 26 insertions(+), 3
Looks works good, including the ABRT patches. Pushed.
On Tue, Feb 12, 2013 at 18:29:53 +0100, Jakub Filak wrote:
- https://github.com/abrt/abrt/issues/607
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/cli/cli-report.c| 5 ++---
src/gui-wizard-gtk/wizard.c | 13
Ack (+corresponding libreport patch).
On Thu, Feb 14, 2013 at 15:18:26 +0100, Jakub Filak wrote:
- related to https://github.com/abrt/libreport/issues/123
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/applet/applet.c | 12 +---
1 file changed, 1 insertion(+), 11
Ack.
On Thu, Feb 14, 2013 at 18:06:44 +0100, Jakub Filak wrote:
- realted to rhbz#905412
- blocked by https://github.com/abrt/gnome-abrt/issues/10
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/applet/applet.c | 22 --
1 file changed, 16 insertions(+), 6
Reviewed pushed with a few typo corrections.
On Tue, Feb 19, 2013 at 09:37:29 +0100, Jakub Filak wrote:
- closes rhbz#901467
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/gtk-helpers/secrets.c | 132
+-
1 file changed, 118
The patch seems ok and the gui no longer crashes. Pushed.
On Wed, Feb 20, 2013 at 18:02:40 +0100, Jakub Filak wrote:
- closes #134
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/gtk-helpers/secrets.c | 36 +---
1 file changed, 29 insertions(+), 7
the migration to satyr is completed this file can be removed.
Note that the format of core_backtrace problem directory item is
incompatible between these two libraries.
Signed-off-by: Martin Milata mmil...@redhat.com
---
abrt.spec.in | 4 +
configure.ac
Function fingerprints should now have the same format as those produced
by btparser. They are also hashed. Closes #55.
Signed-off-by: Martin Milata mmil...@redhat.com
---
lib/abrt.c | 6 +-
lib/abrt.h | 1 +
lib/core_fingerprint.c | 55
libreport can now be built against satyr instead of btparser using
--with-satyr parameter to the configure script. RPMs are built against
btparser.
Signed-off-by: Martin Milata mmil...@redhat.com
---
configure.ac| 18 -
libreport-web.pc.in | 2
Closes #124.
Signed-off-by: Martin Milata mmil...@redhat.com
---
tests/runtests/aux/lib.sh | 5 +
tests/runtests/aux/test_order | 1 +
tests/runtests/aux/test_order.rhel6 | 1 +
tests/runtests/ureport/PURPOSE | 3 +
tests/runtests/ureport/fakefaf.py
So that we can work with 64-bit stack traces on 32-bit systems.
Fixes #56.
Signed-off-by: Martin Milata mmil...@redhat.com
---
python/py_gdb_frame.c | 9 +
python/py_koops_frame.c | 54 +++--
2 files changed, 35 insertions(+), 28 deletions
Hi,
this is a feedback for the faf design notes currently located at
https://github.com/abrt/faf/wiki
In general I like the idea of having the functionality split into
several types of modules. Some minor suggestions, mostly regarding
the ureport format:
* The next points follow the guideline
The current algorithm cannot handle backtraces with multiple threads
containing the designated crash frame such as [1]. We just pick the
shortest one with the risk that our guess might be wrong. Fixes #3.
[1] https://bugzilla.redhat.com/attachment.cgi?id=703269
Signed-off-by: Martin Milata mmil
list reconstruction from python list
object was consolidated into single function which treats all pointers
as void* in order to work with different (yet structurally similar)
structures.
Signed-off-by: Martin Milata mmil...@redhat.com
---
python/Makefile.am| 2 +
python/py_common.c
On Mon, Mar 25, 2013 at 17:58:57 +0100, Jakub Filak wrote:
Thank you. The patch looks good to me. Please, split it to tow separate
patches. The first for the spec file and the second for the rest. Then I will
test it and push it.
On Thursday, March 07, 2013 04:47:06 PM Martin Milata wrote
the migration to satyr is completed this file can be removed.
Note that the format of core_backtrace problem directory item is
incompatible between these two libraries.
Signed-off-by: Martin Milata mmil...@redhat.com
---
configure.ac | 14 -
src/daemon/Makefile.am
Signed-off-by: Martin Milata mmil...@redhat.com
---
abrt.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/abrt.spec.in b/abrt.spec.in
index 799d0fd..29a829b 100644
--- a/abrt.spec.in
+++ b/abrt.spec.in
@@ -47,6 +47,8 @@ BuildRequires: doxygen
BuildRequires: xmlto
BuildRequires
libreport can now be built against satyr instead of btparser using
--with-satyr parameter to the configure script. RPMs are built against
btparser.
Signed-off-by: Martin Milata mmil...@redhat.com
---
configure.ac| 18 -
libreport-web.pc.in | 2 +-
src/lib
Signed-off-by: Martin Milata mmil...@redhat.com
---
libreport.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libreport.spec.in b/libreport.spec.in
index aedb059..c2cd6a9 100644
--- a/libreport.spec.in
+++ b/libreport.spec.in
@@ -27,7 +27,8 @@ BuildRequires: asciidoc
Signed-off-by: Martin Milata mmil...@redhat.com
---
abrt.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/abrt.spec.in b/abrt.spec.in
index 799d0fd..29a829b 100644
--- a/abrt.spec.in
+++ b/abrt.spec.in
@@ -47,6 +47,8 @@ BuildRequires: doxygen
BuildRequires: xmlto
BuildRequires
the migration to satyr is completed this file can be removed.
Note that the format of core_backtrace problem directory item is
incompatible between these two libraries.
Closes #590. Closes #591. Closes #592. Closes abrt/satyr#47.
Signed-off-by: Martin Milata mmil...@redhat.com
---
configure.ac
-by: Martin Milata mmil...@redhat.com
---
lib/backtrace.c | 65 +++--
1 file changed, 54 insertions(+), 11 deletions(-)
diff --git a/lib/backtrace.c b/lib/backtrace.c
index a871eee..9b4dd6a 100644
--- a/lib/backtrace.c
+++ b/lib/backtrace.c
@@ -117,22
Good catch, looks like the emergency analysis feature paid off quite
soon (we just have to hope it suddenly won't stop working:)).
Tested pushed.
On Wed, Mar 27, 2013 at 11:02:00 +0100, Jakub Filak wrote:
This problem was found in dump directories uploaded by Emergency
analysis
Looks good, pushed (with the subshell creation removed.
On Wed, Mar 27, 2013 at 11:53:38 +0100, Jakub Filak wrote:
Closes #630
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/daemon/abrt_event.conf | 4
1 file changed, 4 insertions(+)
diff --git a/src/daemon/abrt_event.conf
The base_api_url is not free()d anywhere (I understand that using free
in main() is not strictly necessary, but I believe we should be
consistent -- either free everything or nothing).
Other than that, the patch looks good:)
On Tue, Mar 26, 2013 at 11:32:59 +0100, Denys Vlasenko wrote:
We
was rewritten into a macro that can be instantiated for all the
structures on which this operation is performed.
This is part of the effort towards #65.
Signed-off-by: Martin Milata mmil...@redhat.com
---
python/Makefile.am| 1 +
python/py_common.h| 153
Pushed, thanks (test would be nice next time, though ...).
On Thu, Mar 28, 2013 at 12:06:42 +0100, Jakub Filak wrote:
- closes #5
Signed-off-by: Jakub Filak jfi...@redhat.com
---
lib/core-backtrace-oops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Related to rhbz#951432.
Signed-off-by: Martin Milata mmil...@redhat.com
---
lib/cluster.c | 2 +-
lib/strbuf.c | 7 +--
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/lib/cluster.c b/lib/cluster.c
index e5825ee..75c9f61 100644
--- a/lib/cluster.c
+++ b/lib/cluster.c
@@ -76,7
On Tue, Apr 09, 2013 at 17:58:19 +0200, Jakub Filak wrote:
-logging.debug(File icon: {0}.format(dicon.to_string()))
-base_name = os.path.basename(dicon.to_string())
+str_dicon = dicon.to_string()
+if not str_dicon:
+logging.debug(File icon which
Looks good, pushed (with minor debug string adjustment).
The patch does not apply to current master, can you please rebase and
resend it?
Thanks!
Perhaps it is because i didn't apply the patch to gnome-abrt, but this
patch produces some kind of deadlock on my system:) To reproduce:
- run gnome-abrt
WARNING:root:Can't get list of problems from DBus service: Did not
receive a reply. Possible causes include: the remote application did not
This one works fine, pushed (including the other two patches) thanks.
On Fri, Apr 12, 2013 at 22:59:59 +0200, Jakub Filak wrote:
Related to rhbz#947870
Signed-off-by: Jakub Filak jfi...@redhat.com
---
src/daemon/abrtd.c | 35 +++
1 file changed, 35
Signed-off-by: Martin Milata mmil...@redhat.com
---
lib/utils.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/utils.h b/lib/utils.h
index 7c8d6a0..5c9b6a5 100644
--- a/lib/utils.h
+++ b/lib/utils.h
@@ -59,6 +59,12 @@ btp_mallocz(size_t size);
/**
* Never returns NULL
1 - 100 of 301 matches
Mail list logo
