[LIBREPORT PATCH] report-gtk: gtk_scrolled_window_add_with_viewport has been deprecated

2013-02-07 Thread Jakub Filak 
- closing #122

Signed-off-by: Jakub Filak jfi...@redhat.com
---
 src/gui-wizard-gtk/wizard.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 335e1b4..e18c31c 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@ -751,7 +751,15 @@ static void tv_details_row_activated(
 gtk_widget_set_size_request(scrolled, 640, 480);
 gtk_widget_show(scrolled);
 
+#if (GTK_MAJOR_VERSION == 3  GTK_MINOR_VERSION  8)
+/* 
http://developer.gnome.org/gtk3/unstable/GtkScrolledWindow.html#gtk-scrolled-window-add-with-viewport
 */
+/* gtk_scrolled_window_add_with_viewport has been deprecated since 
version 3.8 and should not be used in newly-written code. */
 gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(scrolled), 
textview);
+#else
+/* gtk_container_add() will now automatically add a GtkViewport if the 
child doesn't implement GtkScrollable. */
+gtk_container_add(GTK_CONTAINER(scrolled), textview);
+#endif
+
 gtk_widget_show(textview);
 
 load_text_to_text_view(GTK_TEXT_VIEW(textview), item_name);
-- 
1.8.1

Re: [LIBREPORT PATCH] report-gtk: gtk_scrolled_window_add_with_viewport has been deprecated

2013-02-07 Thread Jiri Moskovcak 

- compiles: ok
- works:

- pushed

On 02/07/2013 11:44 AM, Jakub Filak wrote:

- closing #122

Signed-off-by: Jakub Filak jfi...@redhat.com
---
  src/gui-wizard-gtk/wizard.c | 8 
  1 file changed, 8 insertions(+)

diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 335e1b4..e18c31c 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@ -751,7 +751,15 @@ static void tv_details_row_activated(
  gtk_widget_set_size_request(scrolled, 640, 480);
  gtk_widget_show(scrolled);

+#if (GTK_MAJOR_VERSION == 3  GTK_MINOR_VERSION  8)
+/* 
http://developer.gnome.org/gtk3/unstable/GtkScrolledWindow.html#gtk-scrolled-window-add-with-viewport
 */
+/* gtk_scrolled_window_add_with_viewport has been deprecated since 
version 3.8 and should not be used in newly-written code. */
  gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(scrolled), 
textview);
+#else
+/* gtk_container_add() will now automatically add a GtkViewport if the 
child doesn't implement GtkScrollable. */
+gtk_container_add(GTK_CONTAINER(scrolled), textview);
+#endif
+
  gtk_widget_show(textview);

  load_text_to_text_view(GTK_TEXT_VIEW(textview), item_name);