Re: Cyrus IMAPd 2.4.1 Released

2010-10-19 Thread Greg Banks
Bron Gondwana wrote: On Tue, Oct 19, 2010 at 08:41:51AM +0100, Jeroen van Meeuwen (Kolab Systems) wrote: Since we're on the subject... Please consider allowing me to deploy Hudson Continuous Integration. I heartily endorse this product and/or service. We used Hudson at my

Re: Crash in timsieved's cmd_authenticate() on 2.4.6

2011-01-11 Thread Greg Banks
there. As coincidentally I touched that code yesterday, I'll fix it. -- Greg. commit a19110e73a9df20969d9763e0ceff2e1fb992c32 Author: Greg Banks g...@fastmail.fm Date: Wed Jan 12 13:29:47 2011 +1100 timsieved: fix crash in cmd_authenticate Found and analysed by Florian Pflug

Re: Cyrus Roadmap [Was Re: Cross-compiling Cyrus in Buildroot]

2011-06-27 Thread Greg Banks
On 28/06/11 02:35, Bron Gondwana wrote: On Mon, Jun 27, 2011 at 06:13:25PM +0200, Sébastien Michel wrote: Really! I will read deeper the code of the master branch to learn more on that :) You won't find it there, it's in https://github.com/gnb/cyrus-imapd/tree/annotate Do you add a new

Annotations review please?

2011-07-19 Thread Greg Banks
). The following changes since commit afbf4254d68c9732995ba439560578caccc3e42a: add \HasFoo flags (2011-07-11 23:28:47 +0200) are available in the git repository at: ssh://g...@github.com/gnb/cyrus-imapd.git annotate-rebased2 Greg Banks (77): dlist: fix declarations Handle SORT_UID

Re: Cyrus Imap and Automake

2011-07-29 Thread Greg Banks
Sent from my iPhone On 30/07/2011, at 5:48, Дилян Палаузов dilyan.palau...@aegee.org wrote: I have some experience with Autotools. I have absolutely nothing against CMake or other build systems, except I have no coding experience with them. Me too :( In my experience autotools

Re: Graceful restart also for imapd.conf

2011-08-08 Thread Greg Banks
G'day Olivier, On 08/08/11 19:39, Olivier ROLAND wrote: Hi there, Since version 2.0.9 Cyrus master can re-read /etc/cyrus.conf on SIGHUP. The man say : Master rereads its configuration file when it receives a hangup signal, SIGHUP. Services and events may be added, deleted or

Re: Todo lists, 2.4.11 and 2.5 preview

2011-08-08 Thread Greg Banks
On 08/08/11 19:45, Sébastien Michel wrote: I still have some finishing work : JSON default format, some testing on IMAP7 folder name, provide a new connector to notifyd (stomp?, AMQP?) and may be support more event types. I will push soon the code in our github clone of cyrus master.

Re: Graceful restart also for imapd.conf

2011-08-09 Thread Greg Banks
On 09/08/11 18:50, Olivier ROLAND wrote: 2011/8/9 Greg Banksg...@fastmail.fm: G'day Olivier, On 08/08/11 19:39, Olivier ROLAND wrote: Hi there, Since version 2.0.9 Cyrus master can re-read /etc/cyrus.conf on SIGHUP. The man say : Master rereads its configuration file when it

caldav branch review

2011-08-15 Thread Greg Banks
G'day, I read with interest the code which recently appeared at http://git.cyrusimap.org/cyrus-imapd/log/?h=caldav and here are my comments. Disclaimer: I know next to nothing about CalDAV but I can read Cyrus code. commit Initial CalDAV code, after months of working offline. I really

Re: cvt_cyrusdb utility does not work if /var/lib/cyrus/db is inconsistent

2011-08-17 Thread Greg Banks
On 18/08/11 07:26, Greg Banks wrote: Sent from my iPhone On 18/08/2011, at 3:09, Michael Loftis mlof...@wgops.com wrote: 2011/8/17 Dmitry Katsubo dm...@mail.ru: I believe this behaviour is OK for imapd server, but what about command line utility? In any case having exit() call

Re: cvt_cyrusdb utility does not work if /var/lib/cyrus/db is inconsistent

2011-08-18 Thread Greg Banks
On 19/08/11 05:54, Florian Pflug wrote: On Aug17, 2011, at 20:25 , Greg Banks wrote: On 18/08/11 07:26, Greg Banks wrote: Incidentally, there is a bugzilla for this https://bugzilla.cyrusimap.org/show_bug.cgi?id=2924 with a very old patch from Florian Pflug. Dmitry, if you're able

Re: MESSAGE quota resource implemention

2011-09-01 Thread Greg Banks
Julien Coloos wrote: Hi, As discussed on IRC last week, I worked on implementing MESSAGE quota resource in cyrus (see RFC 2087; STORAGE resource already being handled). I created a branch based on Greg's 'annotate' one on github, since his work on annotation storage management made mine a lot

Re: MESSAGE quota resource implemention

2011-09-02 Thread Greg Banks
On 01/09/11 22:22, Bron Gondwana wrote: On Thu, Sep 01, 2011 at 01:27:00PM +0200, Julien Coloos wrote: Le 01/09/2011 03:03, Greg Banks a écrit : But more generally, the update the quotaroot is atomic-safe, because the mailbox doesn't add/remove things from the quotaroot racily - but quota

Re: MESSAGE quota resource implemention

2011-09-05 Thread Greg Banks
On 02/09/11 20:03, Bron Gondwana wrote: On Fri, Sep 02, 2011 at 07:36:20PM +1000, Greg Banks wrote: How's about this for a strategy? When a quota resource is first enabled, (i.e. the limit is changed from UNLIMITED to some finite value), the usage is stored as some special value which I'll

Re: MESSAGE quota resource implemention

2011-09-05 Thread Greg Banks
On 05/09/11 20:06, Bron Gondwana wrote: On Mon, Sep 05, 2011 at 02:32:40PM +1000, Greg Banks wrote: Ok, I'm now convinced my first attempt at annotation quotas sucked too hard, here's how I want to re-implement it. Let me know what you think. - add a 32b mailbox index header entry to track

Re: MESSAGE quota resource implemention

2011-09-06 Thread Greg Banks
On 05/09/11 20:16, Greg Banks wrote: On 02/09/11 20:03, Bron Gondwana wrote: On Fri, Sep 02, 2011 at 07:36:20PM +1000, Greg Banks wrote: How's about this for a strategy? When a quota resource is first enabled, (i.e. the limit is changed from UNLIMITED to some finite value), the usage

Re: MESSAGE quota resource implemention

2011-09-07 Thread Greg Banks
Sent from my iPhone On 08/09/2011, at 0:45, Julien Coloos julien.col...@atos.net wrote: Le 06/09/2011 10:23, Greg Banks a écrit : a) my commit Make quota -f less racy is going to cause lots of clashes (sorry!) b) Bron and I both think that your commit Compute each quota resource

Re: MESSAGE quota resource implemention

2011-09-15 Thread Greg Banks
On 15/09/11 03:14, Julien Coloos wrote: Le 12/09/2011 23:09, Bron Gondwana a écrit : - for 'old' mailboxes (those created before the annotation storage usage field in the index header), current annotations usage shall be computed (and added to the quota entry) upon upgrading; this way

Re: MESSAGE quota resource implemention

2011-09-18 Thread Greg Banks
On 17/09/11 01:37, Julien Coloos wrote: As discussed here and on IRC, I rebased my commits with all the changes: - the 'utility' methods have been promoted to 'command' ones, which are now generic and may (options hash) concern cyrus binaries - the 'start_command_bg' method is now replaced

Cassandane fixes

2011-10-13 Thread Greg Banks
G'day, Yesterday on IRC (18:47:12) suiryc: gnb1: are you here ? (18:51:28) suiryc: I've got commits that may interest you in the cassandane branch 'extra/misc' on our github repo git://github.com/worldline-messaging/cassandane.git (18:53:14) suiryc: there are three commits in that branch, two

Re: prefork

2011-10-23 Thread Greg Banks
G'day, On 30/09/11 19:38, Zbierski Christophe wrote: Hi, I continued to analyze the problem : In master.c (main() function) masterconf_getsection(START, add_start, NULL); masterconf_getsection(SERVICES, add_service, NULL); masterconf_getsection(EVENTS, add_event, NULL);

Re: Fix for cyrus bug 3269

2011-11-21 Thread Greg Banks
G'day Philip, On 22/11/11 11:14, Philip Prindeville wrote: Hi Greg, Can you please have a look at my fix for bug 3269? https://bugzilla.cyrusimap.org/show_bug.cgi?id=3269#c2 Thanks, -Philip The bug says: Cyrus logs a lot of crap (which is not useful 99% of the time, but must be

Re: Cassandane Troubles

2012-01-08 Thread Greg Banks
On Sun, Jan 8, 2012, at 01:00 PM, Jeroen van Meeuwen (Kolab Systems) wrote: Hello there, I'm trying to run Cassandane on my laptop, because I'm interested in writing tests and automating the execution thereof. Cool, always good to have more feedback. Having followed the instructions in

Re: Cassandane for 2.4

2012-01-18 Thread Greg Banks
On Wed, Jan 18, 2012, at 09:57 PM, Bron Gondwana wrote: So I'm working on patches for the next 2.4 as well, and I find that Cassandane isn't so happy with 2.4! Jan 18 21:55:59 launde 2055591/master[26844]: unable to initialize groups for user cyrus: Operation not permitted Jan 18 21:55:59

Jenkins

2012-01-22 Thread Greg Banks
G'day, I spent the last week at Linux.conf.au in Ballarat, and one thing I noticed is that most open source projects which run a Jenkins instance are running it at ci.theirproject.org. So is there are chance we can get hudson.cyrusimap.org renamed or aliased to ci.cyrusimap.org ? -- Greg.

Re: Cyrus review

2012-01-23 Thread Greg Banks
G'day, Bron said we should have this discussion in public, which is a good idea, so... On Mon, Jan 23, 2012, at 08:22 AM, Bron Gondwana wrote: On Mon, Jan 23, 2012 at 01:52:54PM +1100, Greg Banks wrote: commit dlist: unlink before writing temporary file commit always mkdir actually I

Cyrus reviews

2012-01-23 Thread Greg Banks
G'day, I've been told I should do reviews more openly. Ok, here goes. commit rename: ensure user owns both source and dest for Bug #3586 workaround Ok, but why? commit nntpd: use defaultdomain in conjunction with newspostuser to create Reply-To header addresses Looks good commit nntpd:

Re: Cyrus reviews

2012-01-23 Thread Greg Banks
On Tue, Jan 24, 2012, at 07:25 AM, Bron Gondwana wrote: On Tue, Jan 24, 2012 at 01:49:52PM +1100, Greg Banks wrote: I've been told I should do reviews more openly. Ok, here goes. commit rename: ensure user owns both source and dest for Bug #3586 workaround Ok, but why? CMU

Re: Cyrus reviews

2012-01-24 Thread Greg Banks
On Tue, Jan 24, 2012, at 08:16 AM, Ken Murchison wrote: Greg Banks wrote: This code + newdest = buf_release(buf); will leak the string, as newdest is never free()d (and indeed in some other branches of the logic, cannot be). I thought the same thing when I looked as what

Re: Cyrus reviews

2012-01-24 Thread Greg Banks
On Wed, Jan 25, 2012, at 11:16 AM, Greg Banks wrote: On Tue, Jan 24, 2012, at 08:16 AM, Ken Murchison wrote: While we're here... commit nntpd: better commenting of add_header() Looks good. commit imapoptions: more complete description of newsaddheaders behavior Looks good. -- Greg.

Re: Jenkins emails

2012-01-25 Thread Greg Banks
On 26/01/2012, at 4:57, Dave McMurtrie dav...@andrew.cmu.edu wrote: I added do-not-re...@cyrusimap.org to accept_these_nonmembers for the cyrus-devel list. This should work. If not, please let me know. Thanks, will go test now. Greg.

Re: Jenkins emails

2012-01-25 Thread Greg Banks
On Thu, Jan 26, 2012, at 08:56 AM, Greg Banks wrote: On 26/01/2012, at 4:57, Dave McMurtrie dav...@andrew.cmu.edu wrote: I added do-not-re...@cyrusimap.org to accept_these_nonmembers for the cyrus-devel list. This should work. If not, please let me know. Thanks, will go

Re: Do cyrus devs plan to implement PUSH-IMAP protocol?

2012-01-30 Thread Greg Banks
On 30/01/2012, at 19:59, Georg C. F. Greve gr...@kolabsys.com wrote: On Monday 30 January 2012 12.12:52 crocket wrote: Is there any plan to implement PUSH-IMAP in cyrus IMAP? Generally I'd be very interested in everything that improves performance for mobile devices with IMAP, but in

Re: Do cyrus devs plan to implement PUSH-IMAP protocol?

2012-01-30 Thread Greg Banks
On Mon, Jan 30, 2012, at 10:40 PM, Sébastien Michel wrote: Georg, I notice there's a page about Z-Sync on the Kolab wiki. Do you have any idea of the legal issues with the protocol? Hard to find an answer, but below some useful links : Thanks Sébastien!

Re: Build failed in Jenkins: cyrus-imapd-master #360

2012-01-30 Thread Greg Banks
On Mon, Jan 30, 2012, at 05:05 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/360/changes Changes: [brong] strarray: add _uniq and pass a strcmp to _sort. -- This was a spurious test failure caused by unsolved permission

Re: Do cyrus devs plan to implement PUSH-IMAP protocol?

2012-01-31 Thread Greg Banks
On Tue, Jan 31, 2012, at 09:42 AM, Sébastien Michel wrote: Here's a tip:) it supports IMAP SPECIAL-USE, but *only* in response to the non-extended IMAP LIST command. The workaround is easy to code in Cyrus Cool!  Have you coded it yet?  I don't see a Bugzilla ticket. Yes [...]

Re: FOSDEM Report - Saturday

2012-02-07 Thread Greg Banks
G'day, Sounds like you're having fun at FOSDEM :) On Tue, Feb 7, 2012, at 02:27 PM, Bron Gondwana wrote: (I'm copying this to the cyrus-devel list because it's of interest to Cyrus people too...) I'm replying here on the same principle.

Re: FOSDEM Report - Saturday

2012-02-08 Thread Greg Banks
On Wed, Feb 8, 2012, at 05:32 PM, Jeroen van Meeuwen (Kolab Systems) wrote: On 2012-02-08 5:08, Greg Banks wrote: On Tue, Feb 7, 2012, at 02:27 PM, Bron Gondwana wrote: Have they announced the URL for the videos? I think the links are on every talk page on the FOSDEM schedule

Re: FOSDEM Report - Saturday

2012-02-09 Thread Greg Banks
On Thu, Feb 9, 2012, at 09:58 AM, Jeroen van Meeuwen wrote: I think the important thing is trackability from a user point of view. Let's say I'm a Cyrus sysadmin who has discovered a bug in their installation, which is described in a Bugzilla ticket and already fixed in some

Re: Build failed in Jenkins: cyrus-imapd-master #387

2012-02-13 Thread Greg Banks
Sent from my iPhone On 13/02/2012, at 21:03, Jenkins do-not-re...@cyrusimap.org wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/387/ -- [...truncated 1803 lines...] make[1]: Entering directory ` This was due to my commits to Cassandane

Re: Build failed in Jenkins: cyrus-imapd-master #394

2012-02-15 Thread Greg Banks
G'day On Thu, Feb 16, 2012, at 12:45 AM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/394/ -- [...truncated 1809 lines...] for file in ./imclient.3; \ This seems to be due to the new Cassandane tests for the master program

Re: Build failed in Jenkins: cyrus-imapd-master #402

2012-02-20 Thread Greg Banks
On Sun, Feb 19, 2012, at 05:03 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/402/ -- [...truncated 1246 lines...] for file in ./imtest.1 ./pop3test.1 ./nntptest.1 ./lmtptest.1 ./smtptest.1 ./sivtest.1 ./mupdatetest.1

Re: Build failed in Jenkins: cyrus-imapd-master #402

2012-02-20 Thread Greg Banks
On Mon, Feb 20, 2012, at 04:14 PM, Jeroen van Meeuwen (Kolab Systems) wrote: On 2012-02-20 11:44, Greg Banks wrote: Sent from my iPhone On 20/02/2012, at 19:13, Bron Gondwana br...@fastmail.fm wrote: On Mon, Feb 20, 2012 at 07:00:52PM +1100, Greg Banks wrote: 4) Cassandane sometimes

Re: Build failed in Jenkins: cyrus-imapd-master #402

2012-02-20 Thread Greg Banks
On Mon, Feb 20, 2012, at 07:00 PM, Greg Banks wrote: On Sun, Feb 19, 2012, at 05:03 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/402/ 3) The Master.maxforkrate test has detected that the maxforkrate parameter is not being enforced correctly, which is strange

Re: Build failed in Jenkins: cyrus-imapd-master #410

2012-02-23 Thread Greg Banks
On Thu, Feb 23, 2012, at 05:07 AM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/410/ -- [...] + exitcode=1 + '[' -x jenkins-xml-summary.pl ']' + ./jenkins-xml-summary.pl

Re: Build failed in Jenkins: cyrus-imapd-master #410

2012-02-25 Thread Greg Banks
Sent from my iPhone On 25/02/2012, at 21:33, Jeroen van Meeuwen (Kolab Systems) vanmeeu...@kolabsys.com wrote: On 2012-02-24 3:40, Greg Banks wrote: I logged in earlier this morning and grabbed a copy of that directory before the next build ran (each build removes the leftovers from

Re: Build failed in Jenkins: cyrus-imapd-master #449

2012-03-12 Thread Greg Banks
On Mon, Mar 12, 2012, at 10:10 PM, Bron Gondwana wrote: On Mon, Mar 12, 2012 at 05:03:06PM -0400, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/449/changes No idea what actually went wrong there - I don't know how to read these stack dumps. It's uglier than Java I

Re: Build failed in Jenkins: cyrus-imapd-master #453

2012-03-14 Thread Greg Banks
On Wed, Mar 14, 2012, at 05:07 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/453/ -- [...truncated 2028 lines...] Test failures and errors summary

Re: Build failed in Jenkins: cyrus-imapd-master #505

2012-04-09 Thread Greg Banks
G'day, On Mon, Apr 9, 2012, at 05:03 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/505/ [...] + make [] Can't locate File/chdir.pm in @INC (@INC contains: /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi /usr/lib/perl5/site_perl/5.8.8

Re: Build failed in Jenkins: cyrus-imapd-master #507

2012-04-10 Thread Greg Banks
On Tue, Apr 10, 2012, at 05:09 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/507/ Test failures and errors summary Cassandane::Cyrus::Lsub.lsub_toplevel

Re: Build failed in Jenkins: cyrus-imapd-master #509

2012-04-11 Thread Greg Banks
On Wed, Apr 11, 2012, at 05:08 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/509/ [...] --build-url=http://ci.cyrusimap.org/job/cyrus-imapd-master/509/ Test failures and errors summary Cassandane::Cyrus::Sieve.deliver_fileinto_dot

Re: Build failed in Jenkins: cyrus-imapd-master #514

2012-04-15 Thread Greg Banks
with multi-level folders (2012-04-11 09:15:46 +1000) are available in the git repository at: ssh://git.cyrusimap.org/git/cassandane master Greg Banks (1): Correct Cyrus perl module installation directories Cassandane/Instance.pm | 21 +++-- 1 files changed, 15

Re: Automake Support for cyrus-imapd 2.5

2012-04-15 Thread Greg Banks
On Sun, Apr 15, 2012, at 08:27 PM, Bron Gondwana wrote: On Sun, Apr 15, 2012, at 01:31 AM, Дилян Палаузов wrote: Hello, at git://demo.aegee.org:143/cyrus-imapd.git , branch dpa/automake I have patched cyrus-imapd/master to support Automake . With the exception of perl and

Re: Let's map tickets to milestones

2012-04-15 Thread Greg Banks
On Sun, Apr 15, 2012, at 03:43 PM, Jeroen van Meeuwen (Kolab Systems) wrote: A conversation has been started on when Cyrus IMAP 2.5 would be released. [...] If we were to give people a week or so to do all of this, then I reckon next week we could have a meeting to review everything we

Re: Automake Support for cyrus-imapd 2.5

2012-04-16 Thread Greg Banks
G'day, On Sun, Apr 15, 2012, at 01:31 AM, Дилян Палаузов wrote: Hello, at git://demo.aegee.org:143/cyrus-imapd.git , branch dpa/automake I have patched cyrus-imapd/master to support Automake . Some reviews follow. commit rename configure.in to configure.ac Looks good, but there's

Re: Automake Support for cyrus-imapd 2.5

2012-04-16 Thread Greg Banks
On Mon, Apr 16, 2012, at 04:44 PM, Greg Banks wrote: Have to go now, more later. commit */Makefile.in: add top_builddir Looks good. commit */Makefile.in: insert $(top_builddir) in all DEPLIBS Looks good commit */Makefile.in: add top_(builddir,srcdir) to CPPFLAGS +CPPFLAGS = -I$(top_srcdir

Re: Automake Support for cyrus-imapd 2.5

2012-04-17 Thread Greg Banks
On Tue, Apr 17, 2012, at 03:09 PM, Dilyan Palauzov wrote: commit Prepend the path in #include to .et - .h files [...] I don't see why you would change -#include imap_err.h +#include imap/imap_err.h without changing any of the other #include lines around it.

Re: Automake Support for cyrus-imapd 2.5

2012-04-20 Thread Greg Banks
G'day, On Wed, Apr 18, 2012, at 09:13 AM, Дилян Палаузов wrote: Hello Greg, I've done a bunch more testing on this branch and fixed a few issues which I found. Remaining issues are: * The cunit/ directory is proving resistant to automakification, but successfully builds and runs unit

Re: make dist and cunit

2012-04-25 Thread Greg Banks
On Tue, Apr 24, 2012, at 10:46 AM, Jeroen van Meeuwen wrote: On Monday, April 23, 2012 03:05:24 PM Greg Banks wrote: On Fri, Apr 20, 2012, at 12:15 PM, Дилян Палаузов wrote: Hello, Can SMakefile be deleted? I hope so. Most of what's in there is useless and the rest is wrong

Re: make dist and cunit

2012-04-25 Thread Greg Banks
On Wed, Apr 25, 2012, at 08:56 PM, Carson Gaspar wrote: On 4/25/12 6:07 PM, Greg Banks wrote: * Ditto warning flags - I would love to see at least -Wall -Wextra by default if we're using gcc. 1) Please actually detect gcc properly if you're going to do this. Fair enough. I'm so

Re: Build failed in Jenkins: cyrus-imapd-master #541

2012-04-26 Thread Greg Banks
On Fri, Apr 27, 2012, at 12:23 AM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/541/changes [...] gcc -fPIC --coverage -g -O0 --coverage -L4.8/lib -Wl,-rpath,4.8/lib -o imap/lmtpd imap/lmtpd.o imap/lmtpengine.o imap/lmtpstats.o imap/mutex_fake.o imap/proxy.o

Re: Build failed in Jenkins: cyrus-imapd-master #542

2012-04-27 Thread Greg Banks
On Fri, Apr 27, 2012, at 01:52 AM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/542/ -- [...truncated 1952 lines...] mv -f $depbase.Tpo $depbase.Po depbase=`echo imap/mutex_fake.o | sed 's|[^/]*$|.deps/|;s|\.o$||'`;\

Re: In preparation of Cyrus IMAP 2.5: autoconf and automake

2012-04-30 Thread Greg Banks
G'day, On Sat, Apr 28, 2012, at 11:39 AM, Carson Gaspar wrote: Thanks for the bug report! The below is on Solaris 11 using the studio compiler, using the snapshot from the URL below. On 4/28/12 9:15 AM, Jeroen van Meeuwen (Kolab Systems) wrote:

Re: Build failed in Jenkins: cyrus-imapd-master #553

2012-05-01 Thread Greg Banks
On Tue, May 1, 2012, at 05:02 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/553/changes [...] cd sieve /usr/bin/compile_et .././sieve/sieve_err.et gcc -fPIC --coverage -g -O0 -L4.8/lib -Wl,-rpath,4.8/lib -o sieve/test sieve/test.o imap/mutex_fake.o imap/libimap.a

Re: Build failed in Jenkins: cyrus-imapd-master #557

2012-05-03 Thread Greg Banks
On Thu, May 3, 2012, at 05:07 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/557/ [...] Test failures and errors summary Cassandane::Cyrus::Sieve.badscript_timsieved

Re: [PATCH 1/4] autobuild: Fix directory handling

2012-05-08 Thread Greg Banks
Sent from my iPhone On 08/05/2012, at 18:44, Philipp Hahn h...@univention.de wrote: If ../inst/ or ../cassandane/ don't exists, running autobuild.sh fails because it tries to rename the current working directory containing the source tree. Autobuild.sh isn't for you to use, it's for the

Re: Add VACATION :seconds support

2012-05-08 Thread Greg Banks
On Tue, May 8, 2012, at 01:55 PM, Bron Gondwana wrote: On Tue, May 8, 2012, at 01:52 PM, Philipp Hahn wrote: autobuild had just the right name and did what I was looking for - until it renamed $PWD to $PWD.orig :-( gnb - looks like an attractive nuisance. Yeah - naming is hard :(

Re: [PATCH 0/4] Add VACATION :seconds support

2012-05-08 Thread Greg Banks
On Tue, May 8, 2012, at 01:52 PM, Bron Gondwana wrote: On Tue, May 8, 2012, at 01:50 PM, Philipp Hahn wrote: Hello, Am Dienstag 08 Mai 2012 13:07:04 schrieb Bron Gondwana: On Tue, May 8, 2012, at 11:54 AM, Philipp Hahn wrote: For converting days to seconds and the inverse I

Re: Libtool and Support for Shared Libraries

2012-05-10 Thread Greg Banks
On Thu, May 10, 2012, at 09:42 PM, Jeroen van Meeuwen (Kolab Systems) wrote: I agree. This tidying up is going to majorly invasive - don't forget we want to merge in caldav before this happens as well. I strongly recommend any major really tidying things up is postponed to 2.6. Agreed.

Re: Libtool and Support for Shared Libraries (2)

2012-05-22 Thread Greg Banks
On Thu, May 17, 2012, at 01:21 AM, Дилян Палаузов wrote: Hello, I have integrated the comments about libtool/shared libraries and at the end the changes are: -- in libcyrus_min:libconfig:config_read one parameter is added for config_need_data, so that this variable does not have to

Re: Libtool and Support for Shared Libraries (2)

2012-05-24 Thread Greg Banks
On Tue, May 22, 2012, at 01:47 PM, Дилян Палаузов wrote: Hello, commit Makefile.am: move the defintion of COM_ERR_LIB here I don't think there's any point having COM_ERR_LIB and COM_ERR_LIBS, just one should do, but we can tweak that later. libimap and libsieve have to depend on

Re: Libtool and Support for Shared Libraries (2)

2012-05-28 Thread Greg Banks
On Mon, May 28, 2012, at 09:33 PM, Dilyan Palauzov wrote: On my system managesieve.so and IMAP.so contain Library rpath. Curious. Presumably it's a bug in my libtool or automake. I'm tempted to put in a post-install check for Linux build hosts. [...]probably using make install DESTDIR=

Re: libzephyr and notifications

2012-05-28 Thread Greg Banks
On Mon, May 28, 2012, at 03:22 PM, Jeroen van Meeuwen (Kolab Systems) wrote: On 2012-05-22 9:40, Bron Gondwana wrote: We're having issues building zephyr with the new automake stuff, and before we spend too much time fixing it - there's a question worth asking... Does anyone actually

Re: Libtool and Support for Shared Libraries (3)

2012-05-31 Thread Greg Banks
On Thu, May 31, 2012, at 06:25 PM, Дилян Палаузов wrote: Hello, to sum up the issues with Libtool: - the perl shared objects IMAP.so and managesieve.so do not contain Library rpath on Greg's computer, but have it on mine. I have not checked the details, but I think on my computer

Re: Libtool and Support for Shared Libraries (3)

2012-06-02 Thread Greg Banks
On Fri, Jun 1, 2012, at 11:15 AM, Jeroen van Meeuwen (Kolab Systems) wrote: On 2012-05-31 18:25, Дилян Палаузов wrote: - make install DISTDIR= causes warnings from libtool, that state, that the libraries are not installed on the place they are intended to be installed (as configured)

Re: Libtool and Support for Shared Libraries (3)

2012-06-03 Thread Greg Banks
Sent from my iPhone On 03/06/2012, at 20:50, Дилян Палаузов dilyan.palau...@aegee.org wrote: Hello, concerning the rpath for the perl shared objects IMAP.so and managesieve.so, after all I found that MakeMaker uses as linker by default the value returned by $Config(ld) (visible by

Re: IRC

2012-06-03 Thread Greg Banks
G'day, (00:06:17) aosowski: gnb1, I'm running 3.3.4 and cassandane is complaining E.netstat: no support for `AF INET (sctp)' on this system. can I ignore that or how can I fix it? (no sctp module available, just various nf_*_sctp which are all loaded) Cassandane doesn't care about SCTP pe se.

Re: Libtool and Support for Shared Libraries (3)

2012-06-05 Thread Greg Banks
On Mon, Jun 4, 2012, at 04:22 PM, Дилян Палаузов wrote: Hello, then I suggest to build both static and shared libraries, to link all services and user programmes with the shared libraries, to link the IMAP.so and manageiseve.so files with the static libraries, and resolve by this way

Re: Libtool and Support for Shared Libraries (3)

2012-06-05 Thread Greg Banks
On Tue, Jun 5, 2012, at 12:49 PM, Дилян Палаузов wrote: Hello, now libcyrus and libcyrus_min are compiled once as shared libraries, once under perl/ as non-static convenience libraries, perl/imap/IMAP.so and perl/sieve/managesieve/managesieve.so link statically with the non-static

Re: Build failed in Jenkins: cyrus-imapd-master #623

2012-06-05 Thread Greg Banks
On Tue, Jun 5, 2012, at 05:01 AM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/623/changes ./tools/config2header CC=gcc ./lib/imapopts.c ./lib/imapopts.h ./lib/imapoptions cd imap /usr/bin/compile_et .././imap/imap_err.et cd imap /usr/bin/compile_et

Re: Libtool and Support for Shared Libraries (3)

2012-06-05 Thread Greg Banks
On Tue, Jun 5, 2012, at 12:49 PM, Дилян Палаузов wrote: Hello, now libcyrus and libcyrus_min are compiled once as shared libraries, once under perl/ as non-static convenience libraries, perl/imap/IMAP.so and perl/sieve/managesieve/managesieve.so link statically with the non-static

Re: Libtool and Support for Shared Libraries (3)

2012-06-07 Thread Greg Banks
Sent from my iPhone On 07/06/2012, at 23:24, Bron Gondwana br...@fastmail.fm wrote: On Tue, Jun 5, 2012, at 12:49 PM, Дилян Палаузов wrote: Hello, now libcyrus and libcyrus_min are compiled once as shared libraries, once under perl/ as non-static convenience libraries, perl/imap/IMAP.so

Re: Libtool and Support for Shared Libraries (3)

2012-06-08 Thread Greg Banks
Sent from my iPhone On 09/06/2012, at 7:22, Carson Gaspar car...@taltos.org wrote: [ Much perl tsuris elided ] ;) Folks keep talking about linking a static libfoo.a into a dynamic libbar.so. This MUST NOT HAPPEN. Linking non-PIC code into a shared object will fail in unpredictable

Re: Libtool and Support for Shared Libraries (3)

2012-06-11 Thread Greg Banks
On Sun, Jun 10, 2012, at 08:28 PM, Carson Gaspar wrote: On 6/10/12 7:32 PM, Greg Banks wrote: On Sat, Jun 9, 2012, at 04:42 PM, Carson Gaspar wrote: ./configure --prefix=/Tools/SunOS_5.11_i86pc_amd64/cyrus-imapd-2.5.autofoo --sysconfdir=/etc --with-sasl=/Tools

Re: Build failed in Jenkins: cyrus-imapd-master #652

2012-06-20 Thread Greg Banks
On Tue, Jun 19, 2012, at 11:17 PM, Дилян Палаузов wrote: Hello, I merged today the dev/libtool branch in master. Ok, so the first problem is that you did a merge rather than rebase the devllibtool branch on current master and then push that result. Merging makes the commit graph really

Re: Libtool and Support for Shared Libraries (3)

2012-06-26 Thread Greg Banks
On Wed, Jun 27, 2012, at 12:27 AM, Bron Gondwana wrote: /usr/bin/ld.bfd.real: /usr/lib/libcom_err.a(error_message.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC /usr/lib/libcom_err.a: could not read symbols: Bad value

Re: Libtool and Support for Shared Libraries (3)

2012-06-27 Thread Greg Banks
On Wed, Jun 27, 2012, at 07:58 AM, Bron Gondwana wrote: On Wed, Jun 27, 2012, at 08:54 AM, Greg Banks wrote: On Wed, Jun 27, 2012, at 12:27 AM, Bron Gondwana wrote: /usr/bin/ld.bfd.real: /usr/lib/libcom_err.a(error_message.o): relocation R_X86_64_32 against `.rodata.str1.1

Re: Libtool and Support for Shared Libraries (3)

2012-06-27 Thread Greg Banks
On Wed, Jun 27, 2012, at 04:36 PM, Dilyan Palauzov wrote: Hello, as far as I understand, the systemwide libcom_err.a is non PIC, the libcyrus_imap and libcyrus_sieve are PIC and it is not portable to dymically link non-PIC libcom_err.a with PIC libcyrus_sieve . Yes, but how to proceed

Re: Build failed in Jenkins: cyrus-imapd-master #674

2012-06-27 Thread Greg Banks
On Wed, Jun 27, 2012, at 05:08 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/674/ --build-url=http://ci.cyrusimap.org/job/cyrus-imapd-master/674/ Test failures and errors summary Cassandane::Cyrus::Metadata.specialuse

Re: Libtool and Support for Shared Libraries (3)

2012-06-28 Thread Greg Banks
On Fri, Jun 29, 2012, at 02:20 AM, Florian Pflug wrote: On Jun28, 2012, at 01:53 , Greg Banks wrote: On Wed, Jun 27, 2012, at 04:36 PM, Dilyan Palauzov wrote: Moreover, does it make any difference, if imapd links with libcyrus_sieve and libcyrus_sieve links with libcom_err, or if imapd

Re: minimal required version of (optional) tools

2012-07-02 Thread Greg Banks
On Sun, Jul 1, 2012, at 12:07 AM, Дилян Палаузов wrote: Hello, is it possible to define in doc/install-compile.html the minimum versions of the tools, a developer needs in order to re-generate all source files need for the compilation of cyrus-imapd? The needed tools are autoconf,

Re: minimal required version of (optional) tools

2012-07-02 Thread Greg Banks
On Mon, Jul 2, 2012, at 11:15 AM, Bron Gondwana wrote: And the makefiles we ship with release tarballs better bloody work everywhere or the panda will be sad. Good point. Once we get the dist: target sorted out in the new build system, we should set up a Jenkins job which builds a dist

Re: Build failed in Jenkins: cyrus-imapd-master #689

2012-07-04 Thread Greg Banks
On Wed, Jul 4, 2012, at 05:03 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/689/changes Changes: [git-dpa] update .gitignore to include config.(sub,guess) and install-sh [git-dpa] update .gitignore [git-dpa] config.h: add #define EXPORTED and HIDDEN

Re: Build failed in Jenkins: cyrus-imapd-master #689

2012-07-11 Thread Greg Banks
G'day, Bron, you shouldn't need to specify -fPIC when you override CFLAGS anymore, as automake will add that into AM_CFLAGS which is defined separately and used in addition to CFLAGS. This is why -fPIC appears twice on each compile command in your make log. On Thu, Jul 12, 2012, at 12:48 AM,

Re: Build failed in Jenkins: cyrus-imapd-master #710

2012-07-15 Thread Greg Banks
On Sun, Jul 15, 2012, at 05:03 AM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/710/ [...] /bin/sh ./libtool --tag=CC --mode=link gcc -fPIC --coverage -fvisibility=hidden -g -O0-o ptclient/ptloader ptclient/ptloader.o imap/mutex_fake.o master/service-thread.o

Re: Build failed in Jenkins: cyrus-imapd-master #711

2012-07-15 Thread Greg Banks
G'day Dilyan, On Sun, Jul 15, 2012, at 05:03 PM, Jenkins wrote: See http://ci.cyrusimap.org/job/cyrus-imapd-master/711/changes [...] libtool: link: gcc -fPIC --coverage -fvisibility=hidden -g -O0 --coverage -o cunit/.libs/unit cunit/unit.o cunit/syslog.o cunit/timeout.o cunit/annotate.o

Re: linking with libtool and

2012-07-15 Thread Greg Banks
On Sun, Jul 15, 2012, at 12:26 PM, Дилян Палаузов wrote: Hello, I reverted the changes causing the warnings with static in the header files. The linking problem, Bron mentioned on 12.07., was is caused by (./libtool --config)'s link_all_deplibs=no . Does anybody have an idea, when

Re: static and HIDDEN

2012-07-15 Thread Greg Banks
On Thu, Jul 12, 2012, at 03:05 PM, Дилян Палаузов wrote: Hello, Dilyan, this warning is caused by some of your recent commits, like libcyrus: mark all local symbols declared in .h with static which made some of the function declarations in header files 'static'. That's just never

Re: -fvisibility=hidden

2012-07-18 Thread Greg Banks
On Wed, Jul 18, 2012, at 10:46 PM, Дилян Палаузов wrote: Hello, On 16.07.2012 02:08, Greg Banks wrote: So, remind me again what actual value we're getting from this -fvisibility=hidden stuff again? Initially, libcyrus_sieve had a lot of exported symbols generated by bison

Re: Build failed in Jenkins: cyrus-imapd-master #717

2012-07-18 Thread Greg Banks
On Wed, Jul 18, 2012, at 11:42 PM, Bron Gondwana wrote: On Wed, Jul 18, 2012, at 05:03 PM, Jenkins wrote: Running unit tests ./cunit-to-junit.pl: ran 278 tests, 2 failed make[3]: *** [check-local] Error 1 make[3]: Leaving directory

  1   2   >