Re: [PATCH v2] parser: Add syntax stack for recursive parsing

2018-03-08 Thread Herbert Xu
On Thu, Mar 08, 2018 at 10:05:01AM +, Martijn Dekker wrote: > Op 08-03-18 om 07:52 schreef Herbert Xu: > > This patch should fix this problem as well as the one Harald identified: > > Tested. It works well on my end. > > Note it leaves one bug Harald's patch fixed: > > $ src/dash -c 'IFS=;

[PATCH v2] parser: Add syntax stack for recursive parsing

2018-03-07 Thread Herbert Xu
On Wed, Mar 07, 2018 at 08:25:07PM +, Martijn Dekker wrote: > > This version introduces a parsing bug: > > $ src/dash -c 'x=0; x=$((${x}+1))' > src/dash: 1: Syntax error: Unterminated quoted string > > It is triggered by the ${x} (with braces) within an arithmetic expression. Thanks for