Re: [PATCH 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

On 03/31/2014 07:24 PM, Prabhakar Lad wrote: Hi Hans, On Mon, Mar 31, 2014 at 8:34 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, This looks really nice! Writing a video driver has become really easy with almost 90% of work done by v4l core itself :) That was the idea! I'll

[PATCH v2 02/14] dma: edma: Correct the handling of src/dst_maxburst == 0

When clients asks for maxburst = 0 it is basically the same case as if they were asking for maxburst = 1 since in both case ASYNC need to be used and the eDMA is expected to write/read one word per DMA request. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/edma.c | 4

[PATCH v2 00/14] dma: edma: Fixes for cyclic (audio) operation

Hi, This is basically a resend of the previous series: https://lkml.org/lkml/2014/3/13/119 with removed ASoC patches (most of them are applied already). Changes since v1: - ASoC patches removed - Comments from Andriy Shevchenko addressed - patch added to fix cases when src/dst_maxburst is set to

[PATCH v2 01/14] platform_data: edma: Be precise with the paRAM struct

The edmacc_param struct should follow the layout of the paRAM area in the HW. Be explicit on the size of the fields (u32) and also mark the struct as packed to avoid any padding on non 32bit architectures. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- include/linux/platform_data/edma.h

[PATCH v2 07/14] arm: common: edma: API to request non default queue for a channel

When using eDMA3 via dmaengine all dma channels will use the default queue. Since during request time we do not have means to change this it need to be done later, before the DMA has been started. With the added function it is possible to move the channel to a non default queue if it is possible,

[PATCH v2 04/14] dma: edma: Set DMA_CYCLIC capability flag

Indicate that the edma dmaengine driver has support for cyclic mode. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/common/edma.c | 1 + drivers/dma/edma.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index

[PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

Use the EVENTQ_1 for default and leave the EVENTQ_0 to be used by high priority channels, like audio. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/common/edma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/common/edma.c

[PATCH v2 03/14] dma: edma: Add support for DMA_PAUSE/RESUME operation

Pause/Resume can be used by the audio stack when the stream is paused/resumed The edma platform code has support for this and the legacy audio stack used this. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/edma.c | 28 1 file changed, 28

[PATCH v2 06/14] arm: common: edma: Save the number of event queues/TCs

For later use save the number of queues available for the CC. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/common/edma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 19520e2519d9..be267b2080be 100644 ---

[PATCH v2 09/14] dma: edma: Implement device_slave_caps callback

With the callback implemented omap-dma can provide information to client drivers regarding to supported address widths, directions, residue granularity, etc. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/edma.c | 18 ++ 1 file changed, 18 insertions(+) diff

[PATCH v2 12/14] dma: edma: Prefix debug prints where the text were identical in prep callbacks

prep_slave_sg and prep_dma_cyclic callbacks have mostly same failure cases with the same texts printed in case we hit them. It helps when debugging if we know exactly which callback generated the errors. At the same time change the debug level for descriptor allocation failure from dbg to err

[PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the check for the direction has been already done in the function calling edma_config_pset(). The error reporting is redundant and also the else if () can be removed. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

[PATCH v2 08/14] DMA: edma: Use different eventq for cyclic channels

To improve latency with cyclic DMA operation it is preferred to use different eventq/tc than the default which is used by all other drivers (mmc, spi, i2c, etc). When preparing the cyclic dma ask for non default queue for the channel which is going to be used with cyclic mode. Signed-off-by:

[PATCH v2 11/14] dma: edma: Reduce debug print verbosity for non verbose debugging

Do not print the paRAM information when verbose debugging is not asked and also reduce the number of lines printed in edma_prep_dma_cyclic() Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/edma.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH v2 13/14] dma: edma: Add channel number to debug prints

It helps to identify issues if we have some information regarding to the channel which the event is associated. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/edma.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/dma/edma.c

[PATCH v2 14/14] dma: edma: Print the direction value as well when it is not supported

In case of not supported direction it is better to print the direction also. It is unlikely, but in such an event it helps with the debugging. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/edma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git