Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-04 Thread Daniel Mack
On 02.10.2012 18:50, Daniel Mack wrote: On 02.10.2012 18:41, Matt Porter wrote: On Tue, Oct 02, 2012 at 03:42:47PM +0200, Daniel Mack wrote: On 02.10.2012 13:06, Sekhar Nori wrote: On 10/2/2012 4:03 PM, Daniel Mack wrote: On 02.10.2012 11:37, Mark Brown wrote: On Tue, Oct 02, 2012 at

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-04 Thread Porter, Matt
On Oct 4, 2012, at 5:21 AM, Daniel Mack wrote: On 02.10.2012 18:50, Daniel Mack wrote: On 02.10.2012 18:41, Matt Porter wrote: On Tue, Oct 02, 2012 at 03:42:47PM +0200, Daniel Mack wrote: On 02.10.2012 13:06, Sekhar Nori wrote: On 10/2/2012 4:03 PM, Daniel Mack wrote: On 02.10.2012

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-04 Thread Daniel Mack
On 04.10.2012 11:38, Porter, Matt wrote: On Oct 4, 2012, at 5:21 AM, Daniel Mack wrote: On 02.10.2012 18:50, Daniel Mack wrote: On 02.10.2012 18:41, Matt Porter wrote: On Tue, Oct 02, 2012 at 03:42:47PM +0200, Daniel Mack wrote: On 02.10.2012 13:06, Sekhar Nori wrote: On 10/2/2012 4:03

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-04 Thread Matt Porter
On Thu, Oct 04, 2012 at 11:57:30AM +0200, Daniel Mack wrote: On 04.10.2012 11:38, Porter, Matt wrote: On Oct 4, 2012, at 5:21 AM, Daniel Mack wrote: On 02.10.2012 18:50, Daniel Mack wrote: On 02.10.2012 18:41, Matt Porter wrote: On Tue, Oct 02, 2012 at 03:42:47PM +0200, Daniel

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-04 Thread Daniel Mack
On 04.10.2012 12:28, Matt Porter wrote: On Thu, Oct 04, 2012 at 11:57:30AM +0200, Daniel Mack wrote: On 04.10.2012 11:38, Porter, Matt wrote: On Oct 4, 2012, at 5:21 AM, Daniel Mack wrote: On 02.10.2012 18:50, Daniel Mack wrote: On 02.10.2012 18:41, Matt Porter wrote: On Tue, Oct 02,

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Peter Ujfalusi
On 09/22/2012 06:33 PM, Mark Brown wrote: On Fri, Aug 31, 2012 at 06:20:58PM +0530, Hebbar, Gururaja wrote: +config SND_DAVINCI_HAVE_SRAM +bool +default y if ARCH_DAVINCI=y +default n if ARCH_OMAP=y + I've been sitting on this mostly since it seems like a step back from

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Mark Brown
On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: I also agree that ifdef is not a good solution. It is better to have this information passed as device_data and via DT it can be decided based on the compatible property for the device. That's not really the problem here - the

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Daniel Mack
On 02.10.2012 11:37, Mark Brown wrote: On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: I also agree that ifdef is not a good solution. It is better to have this information passed as device_data and via DT it can be decided based on the compatible property for the device.

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Sekhar Nori
On 10/2/2012 4:03 PM, Daniel Mack wrote: On 02.10.2012 11:37, Mark Brown wrote: On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: I also agree that ifdef is not a good solution. It is better to have this information passed as device_data and via DT it can be decided based on

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Daniel Mack
On 02.10.2012 13:06, Sekhar Nori wrote: On 10/2/2012 4:03 PM, Daniel Mack wrote: On 02.10.2012 11:37, Mark Brown wrote: On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: I also agree that ifdef is not a good solution. It is better to have this information passed as device_data

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Matt Porter
On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: On 09/22/2012 06:33 PM, Mark Brown wrote: On Fri, Aug 31, 2012 at 06:20:58PM +0530, Hebbar, Gururaja wrote: +config SND_DAVINCI_HAVE_SRAM + bool + default y if ARCH_DAVINCI=y + default n if ARCH_OMAP=y + I've

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Matt Porter
On Tue, Oct 02, 2012 at 12:33:39PM +0200, Daniel Mack wrote: On 02.10.2012 11:37, Mark Brown wrote: On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: I also agree that ifdef is not a good solution. It is better to have this information passed as device_data and via DT it

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Matt Porter
On Tue, Oct 02, 2012 at 03:42:47PM +0200, Daniel Mack wrote: On 02.10.2012 13:06, Sekhar Nori wrote: On 10/2/2012 4:03 PM, Daniel Mack wrote: On 02.10.2012 11:37, Mark Brown wrote: On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: I also agree that ifdef is not a good

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Daniel Mack
On 02.10.2012 18:41, Matt Porter wrote: On Tue, Oct 02, 2012 at 03:42:47PM +0200, Daniel Mack wrote: On 02.10.2012 13:06, Sekhar Nori wrote: On 10/2/2012 4:03 PM, Daniel Mack wrote: On 02.10.2012 11:37, Mark Brown wrote: On Tue, Oct 02, 2012 at 10:48:53AM +0300, Peter Ujfalusi wrote: I also

Re: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms

2012-10-02 Thread Matt Porter
On Tue, Oct 02, 2012 at 06:50:14PM +0200, Daniel Mack wrote: On 02.10.2012 18:41, Matt Porter wrote: On Tue, Oct 02, 2012 at 03:42:47PM +0200, Daniel Mack wrote: On 02.10.2012 13:06, Sekhar Nori wrote: On 10/2/2012 4:03 PM, Daniel Mack wrote: On 02.10.2012 11:37, Mark Brown wrote: On