Re: problems building DBD::Oracle 1.16 - help - please

2005-02-03 Thread Tim Bunce
On Wed, Feb 02, 2005 at 10:20:32PM -0500, Adam Stoller wrote: PREAMBLE: This may be the wrong address to send this to, if so I appologize and hope some kind soul will help direct me to whom/where I can get some assistance. And yes, I did read the README files - and I either

Re: AutoCommit and connect_cached()

2005-02-03 Thread Tim Bunce
On Wed, Feb 02, 2005 at 10:50:20AM -0800, David Wheeler wrote: On Feb 2, 2005, at 2:59 AM, Tim Bunce wrote: Ah, I see. But loking at DBI::_::dr::connect_cached, it looks as though connect() isn't called if it finds an active, pingable driver in the cache. That's right. I must still be

Re: AutoCommit and connect_cached()

2005-02-03 Thread David Wheeler
On Feb 3, 2005, at 7:45 AM, Tim Bunce wrote: I must still be missing something... Er, why? Sorry, I kept forgetting that DBI::connect_cached() calls DBI::connect(), which calls DBI::_::dr::connect_cached(), which calls (if it finds no dbh in the cache) connect(). The part I kept missing was

Re: AutoCommit and connect_cached()

2005-02-03 Thread Tim Bunce
On Thu, Feb 03, 2005 at 08:40:48AM -0800, David Wheeler wrote: On Feb 3, 2005, at 7:45 AM, Tim Bunce wrote: + my $no_reset = delete $attr-{NoReset}; + %$attr = () if $no_reset; If this looks good to you, I can add a test for it and update the docs and send that patch. Any

DBI v2 - or not

2005-02-03 Thread Tim Bunce
On Thu, Feb 03, 2005 at 08:40:48AM -0800, David Wheeler wrote: That's planned for DBI v2, but it seems DBI v2 isn't going to happen anytime soon so I'm wondering if it's something I should squeeze into DBI v1. What's happened on the DBI v2 front? Nothing much. The call for funding wasn't a

Re: AutoCommit and connect_cached()

2005-02-03 Thread David Wheeler
On Feb 3, 2005, at 3:30 PM, Tim Bunce wrote: Any thoughts on this, then? Same as before - not very keen. It'd be faster than a callback, though. ;-) Yes. The current attribute setting post-connect would be done pre-connect so if the cached handle is okay it's returned unaltered. Gotcha. I like it!