Re: Changes to make DBIS more efficient

2012-04-18 Thread Dave Mitchell
On Fri, Mar 02, 2012 at 05:04:29PM +, Dave Mitchell wrote: On Fri, Mar 02, 2012 at 03:23:30PM +, Dave Mitchell wrote: I'd be happy in principle, although some guidance would be welcome Also in particular, what needs to continue happening across an API change? Is it just that a

Re: why is imp_xxh stored in an SV?

2012-04-18 Thread Dave Mitchell
On Mon, Apr 16, 2012 at 03:12:07PM +0100, Tim Bunce wrote: On Fri, Feb 24, 2012 at 05:18:14PM +, Dave Mitchell wrote: (I confess I haven't looked closely at this yet, but...) [And I confess I forgot about this message - sorry for the delay.] I seems that the imp_xxh_t structure is

Re: Changes to make DBIS more efficient

2012-04-18 Thread Tim Bunce
Perfect! Applied. Many thanks Dave. Tim. On Wed, Apr 18, 2012 at 11:48:31AM +0100, Dave Mitchell wrote: On Fri, Mar 02, 2012 at 05:04:29PM +, Dave Mitchell wrote: On Fri, Mar 02, 2012 at 03:23:30PM +, Dave Mitchell wrote: I'd be happy in principle, although some guidance would be

Re: why is imp_xxh stored in an SV?

2012-04-18 Thread Tim Bunce
On Wed, Apr 18, 2012 at 11:55:45AM +0100, Dave Mitchell wrote: To keep things as simple as possible, I've left mg_obj pointing to the SV containing the struct, but added using mg_ptr (with mg_len == 0) that caches a direct pointer to the structure, skipping the need to indirect via the SV

Re: why is imp_xxh stored in an SV?

2012-04-18 Thread Martin J. Evans
Thanks Dave. I believe your work was sponsored but all the same I'd like you to know I very much appreciate your work on these changes. Martin -- Martin J. Evans Easysoft Limited http://www.easysoft.com

Re: why is imp_xxh stored in an SV?

2012-04-18 Thread H.Merijn Brand
On Wed, 18 Apr 2012 12:59:25 +0100, Tim Bunce tim.bu...@pobox.com wrote: On Wed, Apr 18, 2012 at 11:55:45AM +0100, Dave Mitchell wrote: To keep things as simple as possible, I've left mg_obj pointing to the SV containing the struct, but added using mg_ptr (with mg_len == 0) that caches

Status of DBI RT tickets

2012-04-18 Thread Tim Bunce
The DBI currently has 16 tickets in RT: https://rt.cpan.org/Public/Dist/Display.html?Name=DBI Martin is going to apply the patches in two most recent tickets 76520, 76572. I'd appreciate it if someone could review the other non-wishlist non-stalled tickets to see if they should be closed or

Re: why is imp_xxh stored in an SV?

2012-04-18 Thread Dave Mitchell
Note that this and the just-submitted DBIS patch represent the end of my work on improving performance on DBI, (not counting any remedial work that may be required). PS - here are some final timings, comparing my 'while ($sth-fetch()) {$c++}' test loop (with unchanged DBD-mysql-4.020),

Re: why is imp_xxh stored in an SV?

2012-04-18 Thread Tim Bunce
On Wed, Apr 18, 2012 at 04:35:07PM +0100, Dave Mitchell wrote: Note that this and the just-submitted DBIS patch represent the end of my work on improving performance on DBI, (not counting any remedial work that may be required). PS - here are some final timings, comparing my 'while