RE: [dbi] Unicode-Patch for DBD::ODBC

2006-04-14 Thread Jeff Urlwin
Please let me know what you come up with for a final patch and I will try to incorporate this weekend... -Original Message- From: Alexander Foken [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 21, 2006 2:56 AM To: Martin J. Evans Cc: dbi-users@perl.org Subject: Re: [dbi] Unicode

Re: [dbi] Unicode-Patch for DBD::ODBC

2006-03-20 Thread Alexander Foken
Hello Martin, just a quick reply, I'm in a hurry, so please let me verify this later. Yes, this really looks wrong. But if I remember right, there was a reason for the +. I think I (ab)used phs-sv to store Unicode in a char[], so I just made sure there was enough room for the trailing

RE: [dbi] Unicode-Patch for DBD::ODBC

2006-03-15 Thread Martin J. Evans
Alexander, Thanks for this. I've not had a chance to try it but a quick scan showed: - SvGROW(phs-sv, (phs-maxlen 28) ? 28 : phs-maxlen+1); + SvGROW(phs-sv, (phs-maxlen+sizeof(WCHAR) 28) ? 28 : phs-maxlen+sizeof(WCHAR)); Only because I was looking at this very line the other day it