This is the revised and tested patch for supporting passive-close. Testing
was impaired by a nasty bug (patch #1) which lead to the final Reset not
being sent. Once that had been fixed, things worked out very smoothly.
Other than that I think that the patch set has much benefited from the
[DCCP]: Use AF-independent rebuild_header routine
This fixes a nasty bug: dccp_send_reset() is called by both DCCPv4 and DCCPv6,
but uses
inet_sk_rebuild_header() in each case. This leads to unpredictable and weird
behaviour:
under some conditions, DCCPv6 Resets were sent, in other not.
The
[DCCP]: Remove duplicate test for CloseReq
This removes a redundant test for unexpected packet types. In
dccp_rcv_state_process
it is tested twice whether a DCCP-server has received a CloseReq (Step 7):
* first in the combined if-statement,
* then in the call to dccp_rcv_closereq().
The
[DCCP]: Dedicated auxiliary states to support passive-close
This adds two auxiliary states to deal with passive closes:
* PASSIVE_CLOSE(reached from OPEN via reception of Close)and
* PASSIVE_CLOSEREQ (reached from OPEN via reception of CloseReq)
as internal intermediate states.
[DCCP]: Integrate state transitions for passive-close
This adds the necessary state transitions for the two forms of passive-close
* PASSIVE_CLOSE- which is entered when a host receives a Close;
* PASSIVE_CLOSEREQ - which is entered when a client receives a CloseReq.
Here is a detailed
Em Wed, Nov 28, 2007 at 08:35:08AM +, Gerrit Renker escreveu:
[DCCP]: Use AF-independent rebuild_header routine
This fixes a nasty bug: dccp_send_reset() is called by both DCCPv4 and
DCCPv6, but uses
inet_sk_rebuild_header() in each case. This leads to unpredictable and weird
Em Wed, Nov 28, 2007 at 08:35:11AM +, Gerrit Renker escreveu:
[DCCP]: Remove duplicate test for CloseReq
This removes a redundant test for unexpected packet types. In
dccp_rcv_state_process
it is tested twice whether a DCCP-server has received a CloseReq (Step 7):
* first in the
Em Wed, Nov 28, 2007 at 08:35:10AM +, Gerrit Renker escreveu:
[DCCP]: Integrate state transitions for passive-close
This adds the necessary state transitions for the two forms of passive-close
* PASSIVE_CLOSE- which is entered when a host receives a Close;
* PASSIVE_CLOSEREQ -
Em Wed, Nov 28, 2007 at 08:35:09AM +, Gerrit Renker escreveu:
[DCCP]: Dedicated auxiliary states to support passive-close
This adds two auxiliary states to deal with passive closes:
* PASSIVE_CLOSE(reached from OPEN via reception of Close)and
* PASSIVE_CLOSEREQ (reached from
This patch was based on another made by Gerrit Renker, his changelog was:
--
The patch set migrates TFRC TX history to a singly-linked list.
The details are:
* use of a consistent naming scheme (all TFRC functions now begin with
`tfrc_');
From: Gerrit Renker [EMAIL PROTECTED]
This adds the necessary state transitions for the two forms of passive-close
* PASSIVE_CLOSE- which is entered when a host receives a Close;
* PASSIVE_CLOSEREQ - which is entered when a client receives a CloseReq.
Here is a detailed account of what
From: Gerrit Renker [EMAIL PROTECTED]
This adds two auxiliary states to deal with passive closes:
* PASSIVE_CLOSE(reached from OPEN via reception of Close)and
* PASSIVE_CLOSEREQ (reached from OPEN via reception of CloseReq)
as internal intermediate states.
These states are used to
From: Gerrit Renker [EMAIL PROTECTED]
[DCCP]: Use AF-independent rebuild_header routine
This fixes a nasty bug: dccp_send_reset() is called by both DCCPv4 and DCCPv6,
but uses
inet_sk_rebuild_header() in each case. This leads to unpredictable and weird
behaviour:
under some conditions, DCCPv6
Hi Herbert,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
b/include/linux/dccp.h| 56 +
b/net/dccp/ccids/ccid3.c | 57 --
b/net/dccp/ccids/ccid3.h
From: Gerrit Renker [EMAIL PROTECTED]
This removes a redundant test for unexpected packet types. In
dccp_rcv_state_process
it is tested twice whether a DCCP-server has received a CloseReq (Step 7):
* first in the combined if-statement,
* then in the call to dccp_rcv_closereq().
The latter is
15 matches
Mail list logo