Re: Help on memchr() EGLIBC assembly code

2009-07-31 Thread Richard Henderson
On 07/30/2009 09:29 AM, Aurelien Jarno wrote: Thanks for this patch I have tried it, and it does not have the original problem I have reported. Unfortunately it does not pass the glibc testsuite. I'll try to debug the problem later (I don't own an alpha machine, and need to have internet access

Re: Help on memchr() EGLIBC assembly code

2009-07-30 Thread Aurelien Jarno
On Wed, Jul 29, 2009 at 05:24:59PM -0700, Richard Henderson wrote: On 07/26/2009 04:45 PM, Aurelien Jarno wrote: Knowing that $31 could be used for prefetch, I have modified the assembly code from memchr.S to use it. It passes all the testsuite. This isn't intended to be a prefetch

Re: Help on memchr() EGLIBC assembly code

2009-07-29 Thread Richard Henderson
On 07/26/2009 04:45 PM, Aurelien Jarno wrote: Knowing that $31 could be used for prefetch, I have modified the assembly code from memchr.S to use it. It passes all the testsuite. This isn't intended to be a prefetch instruction, it's meant to be fetching the data for the next word. I.e.

Re: Help on memchr() EGLIBC assembly code

2009-07-27 Thread Aurelien Jarno
On Mon, Jul 27, 2009 at 01:45:06AM +0200, Aurelien Jarno wrote: On Sun, Jul 19, 2009 at 04:29:33PM +0200, Aurelien Jarno wrote: On Wed, Jul 15, 2009 at 12:48:02PM -0700, Richard Henderson wrote: On 07/13/2009 03:16 PM, Matt Turner forwarded: The problem is that the memchr() function on

Re: Help on memchr() EGLIBC assembly code

2009-07-26 Thread Aurelien Jarno
On Sun, Jul 19, 2009 at 04:29:33PM +0200, Aurelien Jarno wrote: On Wed, Jul 15, 2009 at 12:48:02PM -0700, Richard Henderson wrote: On 07/13/2009 03:16 PM, Matt Turner forwarded: The problem is that the memchr() function on alpha uses prefetch, which can cause a page boundary to be crossed,

Re: Help on memchr() EGLIBC assembly code

2009-07-15 Thread Richard Henderson
On 07/13/2009 03:16 PM, Matt Turner forwarded: The problem is that the memchr() function on alpha uses prefetch, which can cause a page boundary to be crossed, while the standards (POSIX and C99) says it should stop when a match is found. That's not supposed to matter -- faults from prefetch

Help on memchr() EGLIBC assembly code

2009-07-13 Thread Aurelien Jarno
Hi all, With a lot of patches (E)GLIBC 2.10 builds on alpha, but it fails on the testsuite for the memchr() function, which is an optimized assembly code on alpha. Unfortunately I don't speak alpha assembly very well, so help is needed. The problem is that the memchr() function on alpha uses

Re: Help on memchr() EGLIBC assembly code

2009-07-13 Thread Carlos O'Donell
On Mon, Jul 13, 2009 at 1:31 PM, Aurelien Jarnoaurel...@aurel32.net wrote: With a lot of patches (E)GLIBC 2.10 builds on alpha, but it fails on the testsuite for the memchr() function, which is an optimized assembly code on alpha. Unfortunately I don't speak alpha assembly very well, so help

Re: Help on memchr() EGLIBC assembly code

2009-07-13 Thread Aurelien Jarno
On Mon, Jul 13, 2009 at 02:24:00PM -0400, Carlos O'Donell wrote: On Mon, Jul 13, 2009 at 1:31 PM, Aurelien Jarnoaurel...@aurel32.net wrote: With a lot of patches (E)GLIBC 2.10 builds on alpha, but it fails on the testsuite for the memchr() function, which is an optimized assembly code on

Re: Help on memchr() EGLIBC assembly code

2009-07-13 Thread Matt Turner
On Mon, Jul 13, 2009 at 6:17 PM, Aurelien Jarnoaurel...@aurel32.net wrote: On Mon, Jul 13, 2009 at 02:24:00PM -0400, Carlos O'Donell wrote: On Mon, Jul 13, 2009 at 1:31 PM, Aurelien Jarnoaurel...@aurel32.net wrote: With a lot of patches (E)GLIBC 2.10 builds on alpha, but it fails on the

Re: Help on memchr() EGLIBC assembly code

2009-07-13 Thread Aurelien Jarno
On Mon, Jul 13, 2009 at 07:16:16PM -0300, Matt Turner wrote: On Mon, Jul 13, 2009 at 6:17 PM, Aurelien Jarnoaurel...@aurel32.net wrote: On Mon, Jul 13, 2009 at 02:24:00PM -0400, Carlos O'Donell wrote: On Mon, Jul 13, 2009 at 1:31 PM, Aurelien Jarnoaurel...@aurel32.net wrote: With a lot