Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-10 Thread Nilesh Patra
On Sat, Nov 11, 2023 at 12:57:38PM +0800, Maytham Alsudany wrote: > Upstream uses sphinx to generate both the HTML docs and the manpages, > so perhaps we should update sphinx's man_pages[4] option in > docs/conf.py[5] in a PR and/or patch, adding a kitten manpage that > points to an existing/new

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-10 Thread Maytham Alsudany
Hi Nilesh, On Sat, 2023-11-11 at 09:44 +0530, Nilesh Patra wrote: > On 11 November 2023 8:31:25 am IST, Maytham Alsudany > wrote: > > On Sat, 2023-11-11 at 02:31 +0530, Nilesh Patra wrote: > > > My personal experience is that maintainer maintained manpages are > > > seldom well-maintained and

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-10 Thread Nilesh Patra
On 11 November 2023 8:31:25 am IST, Maytham Alsudany wrote: >On Sat, 2023-11-11 at 02:31 +0530, Nilesh Patra wrote: >> My personal experience is that maintainer maintained manpages are >> seldom well-maintained and tend to get outdated with new versions >> if the maintainer forgets to update

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-10 Thread Maytham Alsudany
On Sat, 2023-11-11 at 02:31 +0530, Nilesh Patra wrote: > > If would be good to get a second pair of eyes on my commits, since I've made > > some decisive patches. > > I have removed all commits adding manpage. Furthermore you added a > compress command to dh_auto_test this would lead to

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-10 Thread Nilesh Patra
Hi Maytham, On Fri, Nov 10, 2023 at 05:15:22PM +0800, Maytham Alsudany wrote: > On Thu, 2023-11-09 at 00:32 +0530, Nilesh Patra wrote: > > * Can you please clean up some of the lintian stuff? And then we could > > upload the new release. > > Letting you know that I've fixed the majority of

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-10 Thread Nilesh Patra
Hi Maytham, On Fri, Nov 10, 2023 at 01:38:05PM +0800, Maytham Alsudany wrote: > On Thu, 2023-11-09 at 22:53 +0530, Nilesh Patra wrote: > > > Regarding commit 7020dd5d: > > > Are the ldflags necessary, since the binary builds fine without them set? > > > Especially the kitty.VCSRevision option,

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-10 Thread Maytham Alsudany
Hi Nilesh, On Thu, 2023-11-09 at 00:32 +0530, Nilesh Patra wrote: > * Can you please clean up some of the lintian stuff? And then we could > upload the new release. Letting you know that I've fixed the majority of lintian's errors/warnings, and the latest report now looks like this[1]. If

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-09 Thread Maytham Alsudany
Hi Nilesh, Here's what I thought of the discussion. On Thu, 2023-11-09 at 22:53 +0530, Nilesh Patra wrote: > > It would probably be beneficial if we could setup the gbp workflow by hand, > > ensuring the upstream branch is up to date > > Not sure what you mean here. `gbp import-orig` takes care

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-09 Thread Nilesh Patra
On Fri, Nov 10, 2023 at 12:05:20AM +0800, Maytham Alsudany wrote: > On Thu, 2023-11-09 at 00:32 +0530, Nilesh Patra wrote: > > > On the contrary, avoiding the use of dh-golang as done in this repo[3] > > > causes > > > all the tests to pass without problem, and I'm unsure to why that is. > > > >

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-09 Thread Maytham Alsudany
On Thu, 2023-11-09 at 00:32 +0530, Nilesh Patra wrote: > > On the contrary, avoiding the use of dh-golang as done in this repo[3] > > causes > > all the tests to pass without problem, and I'm unsure to why that is. > > This was due to some caveats with the build system and also how > dh_golang

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-08 Thread Nilesh Patra
On Wed, Nov 08, 2023 at 05:52:05PM +0800, Maytham Alsudany wrote: > On the contrary, avoiding the use of dh-golang as done in this repo[3] causes > all the tests to pass without problem, and I'm unsure to why that is. This was due to some caveats with the build system and also how dh_golang

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-08 Thread Maytham Alsudany
On Tue, 2023-11-07 at 22:57 +0530, Nilesh Patra wrote: > I tried avoiding: > > > mkdir -p $(BUILDDIR)/src > > ln -s /usr/share/gocode/src/* $(BUILDDIR)/src > > ln -s $(CURDIR) $(BUILDDIR)/src/kitty > > With the call to go-specific dh_auto_configure. I did some other changes of > similar sort on

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-07 Thread James McCoy
On Tue, Nov 07, 2023 at 10:35:56PM +0530, Nilesh Patra wrote: > There's a patch in[1] that gets things moving. > > @James: Since you agreed to maintain this package as I offer my help for > the go stuff, do you think it makes sense to convert this into an RFH > instead of RFA/ITA? That offer was

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-07 Thread Nilesh Patra
On Tue, 07 Nov 2023 16:33:42 +0800 Maytham Alsudany wrote: > I'd like to adopt the kitty package if that's ok. > > I've been able to upgrade the package to the latest version and get the > Go part of the package to build successfully (the new 'kittens' > feature). My efforts can be found at >

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-07 Thread Nilesh Patra
On Tue, 07 Nov 2023 16:45:18 +0800 Maytham Alsudany wrote: > Hi, > > Firstly, I'd like to apologise for the duplicate mail, which was an > accident on my part. > >OTOH, I did take a look at the errors and I see two ways. Either > >patch out all the go build related code and use

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-07 Thread Maytham Alsudany
Hi, Firstly, I'd like to apologise for the duplicate mail, which was an accident on my part. OTOH, I did take a look at the errors and I see two ways. Either > patch out all the go build related code and use debian's go build toolchain (which takes care of a bunch of things) or hack

Bug#1055347: ITA: kitty -- fast, featureful, GPU based terminal

2023-11-07 Thread Maytham Alsudany
Hi, I'd like to adopt the kitty package if that's ok. I've been able to upgrade the package to the latest version and get the Go part of the package to build successfully (the new 'kittens' feature). My efforts can be found at https://salsa.debian.org/Maytha8/kitty Kind regards, Maytham