Bug#466138: Is this LVM message actually useful?

2009-07-08 Thread Andras Korn
Hi, as far as I can tell, the File descriptor x left open message is just telling the user about open file descriptors the lvm utility inherited and successfully closed. The --quiet option doesn't appear to suppress the message. Does printing the message serve any useful purpose? I'd expect

Bug#466138: Is this LVM message actually useful?

2009-07-08 Thread Alasdair G Kergon
On Wed, Jul 08, 2009 at 01:32:08PM +0200, Andras Korn wrote: as far as I can tell, the File descriptor x left open message is just telling the user about open file descriptors the lvm utility inherited and successfully closed. It's often an indication of a careless programming and can lead to

Bug#466138: Is this LVM message actually useful?

2009-07-08 Thread Andras Korn
On Wed, Jul 08, 2009 at 02:21:05PM +0100, Alasdair G Kergon wrote: Hi, It's often an indication of a careless programming and can lead to security problems if a child process inherits access to a rogue file descriptor and can interfere with it. The messages were added during a bug

Bug#466138: Is this LVM message actually useful?

2009-07-08 Thread Alasdair G Kergon
On Wed, Jul 08, 2009 at 04:37:09PM +0200, Andras Korn wrote: I don't agree; surely, following the above argumentation, each and every program should go out of its way to close any inherited file descriptor it didn't expect, and warn the user about them. Not every program, but ones that are

Bug#466138: Is this LVM message actually useful?

2009-07-08 Thread Andras Korn
On Wed, Jul 08, 2009 at 06:21:27PM +0100, Alasdair G Kergon wrote: ill effects and certainly doesn't warrant an obnoxious warning I can only turn off by relying on an undocumented feature. What stops you closing the fd just before the execve()? Nothing, I suppose, other than that it adds

Bug#466138: Is this LVM message actually useful?

2009-07-08 Thread Alasdair G Kergon
On Thu, Jul 09, 2009 at 12:19:21AM +0200, Andras Korn wrote: I'm still not sure I understand why this is such a big deal that it's unacceptable to just close them silently, Because the cause needs investigating in case it's a security hole (or other program bug). I believe every program has a