Package: mozilla-mplayer
Version: 3.55-1.1
Severity: normal
Tags: patch

mplayerplug-in crashes iceweasel when trying to watch .mov files
at the apple.com/trailers website.

The problem has been reported upstream [1] and fixed in CVS [2]. 
I've attached a patch against the current source package, based on
the upstream fix.

Cheers,
Avi.

[1] 
http://sourceforge.net/mailarchive/forum.php?thread_name=49FC8B49.3030708%40gmail.com&forum_name=mplayerplug-in-devel
[2] 
http://mplayerplug-in.cvs.sourceforge.net/viewvc/mplayerplug-in/mplayerplug-in/Source/plugin-list.cpp?r1=1.79&r2=1.80&view=patch

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages mozilla-mplayer depends on:
ii  epiphany-browse 2.22.3-9                 Intuitive web browser - dummy pack
ii  iceweasel       3.0.9-1                  lightweight web browser based on M
ii  libc6           2.9-4                    GNU C Library: Shared libraries
ii  libgcc1         1:4.3.3-3                GCC support library
ii  libglib2.0-0    2.20.0-2                 The GLib library of C routines
ii  libgtk2.0-0     2.16.1-2                 The GTK+ graphical user interface 
ii  libstdc++6      4.3.3-3                  The GNU Standard C++ Library v3
ii  libx11-6        2:1.2.1-1                X11 client-side library
ii  libxext6        2:1.0.4-1                X11 miscellaneous extension librar
ii  mplayer         1:1.0.rc2svn20090412-0.0 The Ultimate Movie Player For Linu

mozilla-mplayer recommends no packages.

mozilla-mplayer suggests no packages.

-- no debconf information
Index: mplayerplug-in-3.55/Source/plugin-list.cpp
===================================================================
--- mplayerplug-in-3.55.orig/Source/plugin-list.cpp	2009-05-06 18:16:33.000000000 +0300
+++ mplayerplug-in-3.55/Source/plugin-list.cpp	2009-05-06 18:17:37.000000000 +0300
@@ -408,16 +408,17 @@
 			    code = 0;
 			}
 		    }
-		    if ((nextrmda - size) == p)
-			break;
 		    p = nextrmda + 4;
-		    nextrmda =
-			(char *) memmem(p,
-					size - ((long) p - (long) buffer),
-					"rmda", 4);
-		    if (nextrmda == NULL)
-			nextrmda = buffer + size;
-
+		    if (p > (buffer + size)) {
+			p = NULL;
+		    } else {
+  		        nextrmda =
+			    (char *) memmem(p,
+				   	    size - ((long) p - (long) buffer),
+					    "rmda", 4);
+		        if (nextrmda == NULL)
+			    nextrmda = buffer + size;
+		    }
 		}
 
 		break;		// End QT Reference file

Reply via email to