Package: ltris
Version: 1.0.12-1
Tags: upstream, patch

I tried rebuilding this package from source on Ubuntu Jaunty and ran
into this error:

main.c: In function ‘main’:
main.c:41: error: ‘LC_ALL’ undeclared (first use in this function)
main.c:41: error: (Each undeclared identifier is reported only once
main.c:41: error: for each function it appears in.)

main() uses 'setlocale (LC_ALL, "")', but neither it nor any of the
local headers include <locale.h>.

I think this might happen to work in some build environments; at least
on my system, the <libintl.h> they do include looks like it includes
<locale.h> for some but not all optimisation levels.

Nevertheless, it's fragile. The attached patch adds an explicit
dependency.

I think the latest upstream version (2.0.13) is affected as well.
--- src/gettext.h.orig	2005-10-04 19:20:09.000000000 +0100
+++ src/gettext.h	2009-12-09 22:57:24.000000000 +0000
@@ -24,6 +24,8 @@
 
 /* Get declarations of GNU message catalog functions.  */
 # include <libintl.h>
+/* Get declarations of setlocale() and LC_ALL.  */
+# include <locale.h>
 
 #else
 

Reply via email to