Bug#579273: git-core: FTBS on lenny

2010-05-02 Thread Gerrit Pape
On Fri, Apr 30, 2010 at 04:07:52AM -0500, Jonathan Nieder wrote: I disagree with the conclusion. Why not make it a little easier to build git however a person is used to building packages, especially “debuild binary” is implemented as shorthand for “fakeroot debian/rules binary”. I think

Bug#579273: git-core: FTBS on lenny

2010-05-01 Thread Faheem Mitha
Applied all three patches, still seeing a failure (below). Regards, Faheem. On Fri, 30 Apr 2010, Jonathan Nieder wrote: Faheem Mitha wrote: Ok, will retest and let you know. Much appreciated, thanks. Removing docs/ Removing foo/ Removing

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Faheem Mitha
On Mon, 26 Apr 2010, Jonathan Nieder wrote: Faheem Mitha wrote: Um, to be clear, i ran 'debuild binary' as normal user, as I always do, to get the error you saw. 'debuild binary' uses fakeroot. Not sure what you mean by 'run tests as root'. My understanding of the thread you pointed me to

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Gerrit Pape
On Mon, Apr 26, 2010 at 01:43:00PM -0500, Jonathan Nieder wrote: retitle 579273 Test suite fails when run as root Faheem Mitha wrote: * FAIL 24: init notices EPERM If you follow the link above, you can find a patch for this. Alternatively, as a workaround, make sure you are not root

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Faheem Mitha
Hi Gerrit, On Fri, 30 Apr 2010, Gerrit Pape wrote: On Mon, Apr 26, 2010 at 01:43:00PM -0500, Jonathan Nieder wrote: retitle 579273 Test suite fails when run as root Faheem Mitha wrote: * FAIL 24: init notices EPERM If you follow the link above, you can find a patch for this.

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Gerrit Pape
On Fri, Apr 30, 2010 at 01:50:43PM +0530, Faheem Mitha wrote: On Fri, 30 Apr 2010, Gerrit Pape wrote: I personally don't think running the selftests as non-root is a workaround, but strongly recommended. For every software project, 'make' should run with as less permissions as possible

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Jonathan Nieder
Hi Faheem, Faheem Mitha wrote: I applied the patch you pointed me to, namely diff -r cce2e3ed57a1 -r b6a12d78e4e6 t/test-lib.sh --- a/t/test-lib.sh Fri Apr 30 12:00:32 2010 +0530 +++ b/t/test-lib.sh Fri Apr 30 12:20:30 2010 +0530 @@ -775,7 +775,10 @@ # exec does not

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Faheem Mitha
On Fri, 30 Apr 2010, Jonathan Nieder wrote: Hi Faheem, Faheem Mitha wrote: I applied the patch you pointed me to, namely diff -r cce2e3ed57a1 -r b6a12d78e4e6 t/test-lib.sh --- a/t/test-lib.sh Fri Apr 30 12:00:32 2010 +0530 +++ b/t/test-lib.sh Fri Apr 30 12:20:30 2010 +0530 @@

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Jonathan Nieder
Hi Gerrit and Faheem, Gerrit Pape wrote: Faheem Mitha wrote: On Fri, 30 Apr 2010, Gerrit Pape wrote: For every software project, 'make' should run with as less permissions as possible (ideally in a sandbox ;), and root permissions should only be used where really required (usually 'make

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Jonathan Nieder
Faheem Mitha wrote: On Fri, 30 Apr 2010, Jonathan Nieder wrote: Faheem Mitha wrote: I applied the patch you pointed me to, namely diff -r cce2e3ed57a1 -r b6a12d78e4e6 t/test-lib.sh --- a/t/test-lib.sh Fri Apr 30 12:00:32 2010 +0530 +++ b/t/test-lib.sh Fri Apr 30 12:20:30 2010 +0530

Bug#579273: git-core: FTBS on lenny

2010-04-30 Thread Faheem Mitha
On Fri, 30 Apr 2010, Jonathan Nieder wrote: Faheem Mitha wrote: On Fri, 30 Apr 2010, Jonathan Nieder wrote: Faheem Mitha wrote: I applied the patch you pointed me to, namely diff -r cce2e3ed57a1 -r b6a12d78e4e6 t/test-lib.sh --- a/t/test-lib.sh Fri Apr 30 12:00:32 2010 +0530 +++

Bug#579273: git-core: FTBS on lenny

2010-04-26 Thread Faheem Mitha
Package: git-core Version: 1.7.0.4-1 Severity: normal This version of git failed to build on lenny, though build dependencies were satisfied. Errors appear below. Regards, Faheem ** fatal: cannot mkdir

Bug#579273: git-core: FTBS on lenny

2010-04-26 Thread Jonathan Nieder
retitle 579273 Test suite fails when run as root reassign 579273 src:git git/1:1.7.0.4-1 reassign 524309 src:git git/1:1.6.2.3-1 severity 524309 normal merge 524309 579273 tags 524309 + patch forwarded 524309 http://thread.gmane.org/gmane.comp.version-control.git/145427 thanks Hi Faheem, Faheem

Bug#579273: git-core: FTBS on lenny

2010-04-26 Thread Faheem Mitha
On Mon, 26 Apr 2010, Jonathan Nieder wrote: Hi Faheem, Faheem Mitha wrote: * FAIL 24: init notices EPERM If you follow the link above, you can find a patch for this. Alternatively, as a workaround, make sure you are not root when running tests. Thanks for writing, Jonathan Hi

Bug#579273: git-core: FTBS on lenny

2010-04-26 Thread Jonathan Nieder
Hi Faheem, Faheem Mitha wrote: Thanks for the quick response. Is the patch going to be applied to the Debian package? If I understand the thread and your response correctly, this patch would make the package build when using fakeroot. Usage of fakeroot is standard in Debian, afaik. At least,

Bug#579273: git-core: FTBS on lenny

2010-04-26 Thread Faheem Mitha
On Mon, 26 Apr 2010, Jonathan Nieder wrote: Hi Faheem, Faheem Mitha wrote: Thanks for the quick response. Is the patch going to be applied to the Debian package? If I understand the thread and your response correctly, this patch would make the package build when using fakeroot. Usage of

Bug#579273: git-core: FTBS on lenny

2010-04-26 Thread Jonathan Nieder
Faheem Mitha wrote: Um, to be clear, i ran 'debuild binary' as normal user, as I always do, to get the error you saw. 'debuild binary' uses fakeroot. Not sure what you mean by 'run tests as root'. My understanding of the thread you pointed me to was fakeroot was 'root-like' enough to upset