Hello,
Thank you for your patches and report. I changed the patch a bit to
remove duplicate logic and pushed them for both buildbot and
buildbot-slave packages to upstream [1].
I would gladly provide a patch that switches the ENABLED value to 1,
since 0 is a very weird integer value for TRUE)
Package: buildbot-slave
Version: 0.8.3-1
Severity: normal
Hi,
1) having 0=enabled is very very weird
2) disabling a slave does not work:
# invoke-rc.d buildslave start
Starting buildslave disabled.
Another twistd server is running, PID 31564
This could either be a previously started instance
tags 62 + patch
thanks
Looking a bit further into this made me recognize this:
* integer comparison is used on ${SLAVE_ENABLED[$i]}, but since the user
may enter any value in /etc/default/buildslave the assumption that this
is an integer is wrong and the comment 0-enabled, other-disabled
3 matches
Mail list logo