Bug#733489: Remaining patches for bug #733489

Friendly ping to Julian...

Bug#733489: Remaining patches for bug #733489

On Fri, Sep 11, 2015 at 11:47:22AM +0200, Michael Schaller wrote: > Friendly ping to Julian... > Merged into debian/sid in commit da965cc17daec4dfb25b6d05e435a0bfc8f1e33f Thank you for your contribution. -- Julian Andres Klode - Debian Developer, Ubuntu Member See

Bug#733489: Remaining patches for bug #733489

Awesome. Thanks a million, Julian! About the missing 'doc/source/whatsnew/1.0' update. I think these commits could be relevant: https://anonscm.debian.org/cgit/apt/python-apt.git/commit/?id=8ad17a7fbc01935eb5f7cb252631e6d7d2ebedf7

Bug#733489: Remaining patches for bug #733489

Julian, I've went ahead and implemented the changes you've requested and updated my development branch: https://github.com/michael-schaller/python-apt/commits/dev

Bug#733489: Remaining patches for bug #733489

On 09/06/2015 11:48 AM, Julian Andres Klode wrote: On Sun, Sep 06, 2015 at 11:14:28AM +0200, Michael Schaller wrote: * You don't need to assign "tvers = self.target_versions" before the list comprehension, that just reduces readability. Better split the comprehension over two lines if

Bug#733489: Remaining patches for bug #733489

On Sun, Sep 06, 2015 at 11:14:28AM +0200, Michael Schaller wrote: > Julian, I've went ahead and implemented the changes you've requested and > updated my development branch: > https://github.com/michael-schaller/python-apt/commits/dev Thanks, we're almost done. I was about to merge this, but

Bug#733489: Remaining patches for bug #733489

Friendly ping to Julian. Julian, do you think we can finish this before your University courses start again?

Bug#733489: Remaining patches for bug #733489

On Wed, Sep 2, 2015 at 10:34 AM, Michael Schaller wrote: > Friendly ping to Julian. Julian, do you think we can finish this before > your University courses start again? > Sure. I'm sorry I forgot to send this out, but here we go: There are some things I don't like

Bug#733489: Remaining patches for bug #733489

On 09/02/2015 11:28 AM, Julian Andres Klode wrote: On Wed, Sep 2, 2015 at 10:34 AM, Michael Schaller wrote: Friendly ping to Julian. Julian, do you think we can finish this before your University courses start again? Sure. I'm sorry I forgot to send this out, but here

Bug#733489: Remaining patches for bug #733489

Done. Please take another look on the last two patches on this branch: https://github.com/michael-schaller/python-apt/commits/dev Node: With the removal of TargetVersionList I had to duplicate the code for the installed_target_versions properties.

Bug#733489: Remaining patches for bug #733489

Fair points. I'll update the commit and ping you once it is ready for review.

Bug#733489: Remaining patches for bug #733489

On Fri, Aug 21, 2015 at 11:43:41AM +0200, Michael Schaller wrote: On 08/20/2015 10:07 PM, Julian Andres Klode wrote: On Thu, Aug 20, 2015 at 09:58:11PM +0200, Michael Schaller wrote: Hi Michael, I think it looks OK, but let me suggest some changes: - Drop the parent_version property and

Bug#733489: Remaining patches for bug #733489

On 08/20/2015 10:07 PM, Julian Andres Klode wrote: On Thu, Aug 20, 2015 at 09:58:11PM +0200, Michael Schaller wrote: Hi Michael, I think it looks OK, but let me suggest some changes: - Drop the parent_version property and use _version directly - Drop the cache property and use _cache directly

Bug#733489: Remaining patches for bug #733489

Friendly ping to Julian. I hope your exams went well...

Bug#733489: Remaining patches for bug #733489

On Thu, Aug 20, 2015 at 09:58:11PM +0200, Michael Schaller wrote: Friendly ping to Julian. I hope your exams went well... Hi Michael, I think it looks OK, but let me suggest some changes: - Drop the parent_version property and use _version directly - Drop the cache property and use _cache

Bug#733489: Remaining patches for bug #733489

On 07/07/2015 09:00 PM, Julian Andres Klode wrote: On Sat, Jul 04, 2015 at 03:45:48PM +0200, Michael Schaller wrote: I merged all except for the last 2 commits, as they seem to introduce a reference cycle from deps to versions. And we can't have that, as that leads to enormous issues (#745487).

Bug#733489: Remaining patches for bug #733489

On Sat, Jul 04, 2015 at 03:45:48PM +0200, Michael Schaller wrote: Hi Julian, I've reviewed and reworked all the remaining patches I have for bug #733489. From my point of view 6 reasonably sized patches are remaining. If you prefer single patches then I'll keep them coming. Alternatively

Bug#733489: Remaining patches for bug #733489

Hi Julian, I've reviewed and reworked all the remaining patches I have for bug #733489. From my point of view 6 reasonably sized patches are remaining. If you prefer single patches then I'll keep them coming. Alternatively here is my dev branch with all the remaining patches: https