Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-27 Thread Alexandre Detiste
Le samedi 26 décembre 2015, 22:46:05 Markus Koschany a écrit : > The package looks good to me. Please add the missing license of tinyxml > to debian/copyright. Done > After that I will upload the package. Thanks, that would be nice to finally close this ITP from 2011. signature.asc

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-27 Thread Markus Koschany
Am 27.12.2015 um 09:35 schrieb Alexandre Detiste: > Le samedi 26 décembre 2015, 22:46:05 Markus Koschany a écrit : >> The package looks good to me. Please add the missing license of tinyxml >> to debian/copyright. > > Done Uploaded. Thanks for your contribution. Markus signature.asc

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-26 Thread Alexandre Detiste
Hi, I spent some time merging your advices & Simon's ones [1] in a way that don't trigger new lintian false positives. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807099#74 > Am 11.12.2015 um 12:35 schrieb Alexandre Detiste: > I would add the following paragraph to debian/copyright to

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-26 Thread Markus Koschany
Am 26.12.2015 um 10:30 schrieb Alexandre Detiste: > Hi, > > I spent some time merging your advices & Simon's ones [1] > in a way that don't trigger new lintian false positives. The package looks good to me. Please add the missing license of tinyxml to debian/copyright. After that I will upload

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-11 Thread Alexandre Detiste
Le dimanche 6 décembre 2015, 20:34:42 Markus Koschany a écrit : > Several Expat copyright holder are missing in > CorsixTH/Lua/languages > CorsixTH/Src/jit_opt.h > SpriteEncoder/* > LevelEdit/* > > GPL-3+ > SpriteEncoder/parser.cpp > SpriteEncoder/tokens.h This license has this special

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-11 Thread Markus Koschany
Am 11.12.2015 um 12:35 schrieb Alexandre Detiste: > Le dimanche 6 décembre 2015, 20:34:42 Markus Koschany a écrit : >> Several Expat copyright holder are missing in >> CorsixTH/Lua/languages >> CorsixTH/Src/jit_opt.h >> SpriteEncoder/* >> LevelEdit/* >> >> GPL-3+ >> SpriteEncoder/parser.cpp >>

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-07 Thread Alexandre Detiste
Le mardi 8 décembre 2015, 12:32:33 Paul Wise a écrit : > On Mon, Dec 7, 2015 at 8:36 PM, Alexandre Detiste wrote: > > > There's one library missing: "lua-socket", which is solely used > > for a call-home / breach of privacy anti-feature. > > > > I would disable it at build-time with sed. > >

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-07 Thread Alexandre Detiste
Hi, Thanks for having a look at this. > so are you saying that the package is doing some dlopen-hack to use the > libraries? > > because otherwise the package needs to link the libraries, and then shlibs > should > do the subst work. > > (note: I didn't clone the repository, but in my

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-07 Thread Gianfranco Costamagna
Hi again! >The context is that this is game is mainly written in Lua + >some C++ glue code and I've no idea how Lua libraries work. > >So I'll spend some time to learn that properly. oh well, lua might not link libraries to binaries :) >This lua-lpeg depedency is there because I was until

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-07 Thread Alexandre Detiste
Le lundi 7 décembre 2015, 12:06:55 Gianfranco Costamagna a écrit : > > I guess the libraries are somewhat opened in the lines below > "local lfs = require "lfs"" <<- lua-filesystem > "local lpeg = require "lpeg"" <<- lua-lpeg > > but I don't think you are actually opening the sofiles but the .lua

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-07 Thread Paul Wise
On Mon, Dec 7, 2015 at 8:36 PM, Alexandre Detiste wrote: > There's one library missing: "lua-socket", which is solely used > for a call-home / breach of privacy anti-feature. > > I would disable it at build-time with sed. > (beacause lua-socket might have been pulled > by an other package) ... >

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-06 Thread Markus Koschany
Am 06.12.2015 um 21:13 schrieb Alexandre Detiste: > Le dimanche 6 décembre 2015, 20:34:42 Markus Koschany a écrit : [...] >> You build-depend on wx2.8-headers but this package is obsolete and will >> be removed soon. Please either use wx3.0-headers instead or remove the >> build-dependency because

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-06 Thread Alexandre Detiste
Le dimanche 6 décembre 2015 21:28:35, vous avez écrit : > I saw that they provided a desktop file within the DebianPackager > directory. desktop files should definitely be provided with the upstream > sources because they are not Debian specific. Other distributions would > also benefit from this

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-06 Thread Markus Koschany
Control: owner -1 ! Am 05.12.2015 um 11:55 schrieb Alexandre Detiste: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "corsix-th": Hi Alexandre, here is my initial review. I am working with the pkg-games Git repository

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-06 Thread Alexandre Detiste
Le dimanche 6 décembre 2015, 20:34:42 Markus Koschany a écrit : > Hi Alexandre, > > here is my initial review. I am working with the pkg-games Git > repository of corsix-th and I suggest we continue to use it instead of > the mentors.debian.net packages. Ok > debian/control: > > You

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-06 Thread Gianfranco Costamagna
Hi, quick question: >> Why do you depend on lua-filesystem and lua-lpeg explicitly? If those >> dependencies are really required, the ${shlibs:Depends} substvar should >> include them already. Otherwise the build system should be updated to >> require and incorporate those libraries. > >Because

Bug#807099: RFS: corsix-th/0.50-1 ITP 610087 - A Theme Hospital engine reimplementation.

2015-12-05 Thread Alexandre Detiste
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "corsix-th": * Package name: corsix-th Version : 0.50-1 Upstream Author : Peter "Corsix" Cawley * URL : https://github.com/CorsixTH/CorsixTH/ * License