Package: src:python-jack-client
Version: 0.4.2-1
Severity: normal
Tags: patch
Hi,
This package uses one of the in-line cffi modes [0]. This means it needs
to depend on python-cffi, not just the backend. The binaries currently
in the archive do this, but they wouldn't if they'd been built in the
presence of python-cffi (because it has a pydist override that generates
a dependency on the backend package).
Also, they build-depend on the backend which is a bit weird, and not
doing anything useful.
[0]:
https://cffi.readthedocs.io/en/latest/overview.html#simple-example-abi-level-in-line
So, here's a patch series to tidy this all up. And fix the broken clean rule.
SR
From 3a7092cac7ee34b651140cd0e5f7238bb71cdcc0 Mon Sep 17 00:00:00 2001
From: Stefano Rivera <stefa...@debian.org>
Date: Fri, 30 Dec 2016 12:30:28 +0100
Subject: [PATCH 1/3] Drop python{3,}-cffi-backend Build-Deps - there is no
test suite
---
debian/control | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/debian/control b/debian/control
index 271bcf2..40ca5cf 100644
--- a/debian/control
+++ b/debian/control
@@ -7,9 +7,7 @@ Build-Depends: debhelper (>=9),
python-all (>= 2.6.6-3~),
python-setuptools,
python3-all,
- python-cffi-backend (>= 1.6.0),
- python3-setuptools,
- python3-cffi-backend (>= 1.6.0)
+ python3-setuptools
Standards-Version: 3.9.8
Homepage: http://jackclient-python.rtfd.org
X-Python-Version: >= 2.7
--
2.11.0
From 7b2c1ca6a3e2aee95b1834bc2a569141b34ebfac Mon Sep 17 00:00:00 2001
From: Stefano Rivera <stefa...@debian.org>
Date: Fri, 30 Dec 2016 12:31:53 +0100
Subject: [PATCH 2/3] This package uses inline cffi mode
So explicitly depend on python{3,}-cffi. The backend alone is not
sufficient.
---
JACK_Client.egg-info/SOURCES.txt | 1 +
debian/control | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/JACK_Client.egg-info/SOURCES.txt b/JACK_Client.egg-info/SOURCES.txt
index de9ad60..6387d3b 100644
--- a/JACK_Client.egg-info/SOURCES.txt
+++ b/JACK_Client.egg-info/SOURCES.txt
@@ -4,6 +4,7 @@ MANIFEST.in
NEWS.rst
README.rst
jack.py
+setup.cfg
setup.py
JACK_Client.egg-info/PKG-INFO
JACK_Client.egg-info/SOURCES.txt
diff --git a/debian/control b/debian/control
index 40ca5cf..e47d46d 100644
--- a/debian/control
+++ b/debian/control
@@ -18,8 +18,8 @@ Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/python-jack-client.git
Package: python-jack-client
Architecture: all
Depends: ${python:Depends},
- python-cffi-backend (>= 1.6.0),
${misc:Depends},
+ python-cffi,
libjack-jackd2-0 (>= 1.9.10+20150825) | libjack-0.125
Suggests: python-numpy
Description: JACK Audio Connection Kit (JACK) Client for Python
@@ -33,7 +33,7 @@ Package: python3-jack-client
Architecture: all
Depends: ${python3:Depends},
${misc:Depends},
- python3-cffi-backend (>= 1.6.0),
+ python3-cffi,
libjack-jackd2-0 (>= 1.9.10+20150825) | libjack-0.125
Suggests: python3-numpy
Description: JACK Audio Connection Kit (JACK) Client for Python 3
--
2.11.0
From 3fcab5fdd5655940471c52e83d2c45d06f9f8421 Mon Sep 17 00:00:00 2001
From: Stefano Rivera <stefa...@debian.org>
Date: Fri, 30 Dec 2016 12:35:08 +0100
Subject: [PATCH 3/3] Clean up egg-info
---
debian/clean | 1 +
1 file changed, 1 insertion(+)
create mode 100644 debian/clean
diff --git a/debian/clean b/debian/clean
new file mode 100644
index 0000000..45149aa
--- /dev/null
+++ b/debian/clean
@@ -0,0 +1 @@
+*.egg-info/*
--
2.11.0
