On Friday 21 April 2017 05:11 PM, Niels Thykier wrote:
> Apparently "[ -d ${foo} ]" returns 0 even if foo is unset. Fortunately,
> there are no "standard" directories in the list of dirs being removed,
> but I would prefer if the next upload had an explicit check for
> "${gitlab_data_dir}" being
Pirate Praveen:
> Control: tags -1 -moreinfo
>
> On Saturday 15 April 2017 01:24 AM, Niels Thykier wrote:
>> Sorry for the delay in getting back to you.
>
> Thanks for the detailed review.
>
Hi,
Thanks for working on improving Debian. :)
I noticed the following in the postrm
Control: retitle unblock: gitlab/8.13.11+dfsg1-2
On Friday 21 April 2017 01:13 PM, Ansgar Burchardt wrote:
> I believe maintainer scripts (and various other parts) should use
> `runuser` instead of `su`. It does not open PAM sessions which seems
> to sometimes cause problems.
>
>
Hi,
> You probably want something like:
>
> """
> if su ${gitlab_user} -c 'psql gitlab_production -c ""'; then
> su postgres -c "dropdb gitlab_production"
> fi
> """
I believe maintainer scripts (and various other parts) should use
`runuser` instead of `su`. It does not open PAM
Control: tags -1 -moreinfo
On Saturday 15 April 2017 01:24 AM, Niels Thykier wrote:
> Sorry for the delay in getting back to you.
Thanks for the detailed review.
>
> * In the postrm (RC bug):
>
> """
> su ${gitlab_user} -c 'psql gitlab_production -c ""' && \
>su postgres -c "dropdb
Control: tags -1 moreinfo
Pirate Praveen:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
>
> Please unblock package gitlab
>
> This fixes RC bug #857967. Also sine the version in stretch is currently
> not installable, please
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package gitlab
This fixes RC bug #857967. Also sine the version in stretch is currently
not installable, please reduce the age.
debdiff with 8.13.11+dfsg-5 attached
7 matches
Mail list logo
