Bug#890594: salsa script ready to review

2018-11-27 Thread Xavier
Le 27/11/2018 à 15:13, Raphael Hertzog a écrit : > On Tue, 27 Nov 2018, Xavier wrote: >> It seems that $_ is modified sometimes somewhere else. I fixed that in >> last upload (.deb updated also) > > Now it works fine. At least, I used it to ensure consistency across all > 223 repositories of the

Bug#890594: salsa script ready to review

2018-11-27 Thread Raphael Hertzog
On Tue, 27 Nov 2018, Xavier wrote: > It seems that $_ is modified sometimes somewhere else. I fixed that in > last upload (.deb updated also) Now it works fine. At least, I used it to ensure consistency across all 223 repositories of the pkg-security team. Thank you for your work on this! --

Bug#890594: salsa script ready to review

2018-11-27 Thread Xavier
Le 27/11/2018 à 14:23, Raphael Hertzog a écrit : > Hi, > > On Mon, 26 Nov 2018, Xavier wrote: >> Done: I added a "rename_branch" command: >> - rename_head: >>* tries to create new branch and ignores failures >>* move default_branch to new value >>* deletes old branch only if creation

Bug#890594: salsa script ready to review

2018-11-27 Thread Raphael Hertzog
Hi, On Mon, 26 Nov 2018, Xavier wrote: > Done: I added a "rename_branch" command: > - rename_head: >* tries to create new branch and ignores failures >* move default_branch to new value >* deletes old branch only if creation succeeds > - rename_branch: >* creates new_branch and

Bug#890594: salsa script ready to review

2018-11-26 Thread Xavier
Le 26/11/2018 à 07:04, Xavier a écrit : > Le 25/11/2018 à 23:25, Raphael Hertzog a écrit : >> On Sun, 25 Nov 2018, Xavier wrote: >>> My last change produces this bug. Fixed now, I pushed a new .deb in the >>> same place. >> >> Next try with a package whose HEAD points to the wrong branch

Bug#890594: salsa script ready to review

2018-11-25 Thread Xavier
Le 25/11/2018 à 23:25, Raphael Hertzog a écrit : > On Sun, 25 Nov 2018, Xavier wrote: >> My last change produces this bug. Fixed now, I pushed a new .deb in the >> same place. > > Next try with a package whose HEAD points to the wrong branch (upstream) > but that already has the desired target

Bug#890594: salsa script ready to review

2018-11-25 Thread Raphael Hertzog
On Sun, 25 Nov 2018, Xavier wrote: > My last change produces this bug. Fixed now, I pushed a new .deb in the > same place. Next try with a package whose HEAD points to the wrong branch (upstream) but that already has the desired target branch (debian/master) $ salsa --conf-file

Bug#890594: salsa script ready to review

2018-11-25 Thread Xavier
Le 25/11/2018 à 22:39, Xavier a écrit : > On Sun, 25 Nov 2018, Raphael Hertzog wrote: >> On Thu, 22 Nov 2018, Xavier wrote: >>> Last .deb contains the SALSA_RENAME_HEAD. Could you test it ? >> >> I wanted to do some test but something else broke: >> >> $ salsa --conf-file

Bug#890594: salsa script ready to review

2018-11-25 Thread Xavier
Le 25/11/2018 à 22:37, Raphael Hertzog a écrit : > On Sun, 25 Nov 2018, Raphael Hertzog wrote: >> On Thu, 22 Nov 2018, Xavier wrote: >>> Last .deb contains the SALSA_RENAME_HEAD. Could you test it ? >> >> I wanted to do some test but something else broke: >> >> $ salsa --conf-file

Bug#890594: salsa script ready to review

2018-11-25 Thread Raphael Hertzog
On Sun, 25 Nov 2018, Raphael Hertzog wrote: > On Thu, 22 Nov 2018, Xavier wrote: > > Last .deb contains the SALSA_RENAME_HEAD. Could you test it ? > > I wanted to do some test but something else broke: > > $ salsa --conf-file +./salsa-pkg-security.conf update_safe sandsifter > --verbose --debug

Bug#890594: salsa script ready to review

2018-11-25 Thread Raphael Hertzog
On Thu, 22 Nov 2018, Xavier wrote: > Last .deb contains the SALSA_RENAME_HEAD. Could you test it ? I wanted to do some test but something else broke: $ salsa --conf-file +./salsa-pkg-security.conf update_safe sandsifter --verbose --debug salsa info: Project sandsifter =>

Bug#890594: salsa script ready to review

2018-11-22 Thread Xavier
Le 22/11/2018 à 22:45, Xavier a écrit : > Le 22/11/2018 à 21:06, Xavier a écrit : >> Le 22/11/2018 à 10:19, Xavier a écrit : >>> Le 22/11/2018 à 08:46, Raphael Hertzog a écrit : Hi, On Wed, 21 Nov 2018, Xavier wrote: > Sorry, I found a SALSA_TEAM in your conf file. For clarity,

Bug#890594: salsa script ready to review

2018-11-22 Thread Xavier
Le 22/11/2018 à 21:06, Xavier a écrit : > Le 22/11/2018 à 10:19, Xavier a écrit : >> Le 22/11/2018 à 08:46, Raphael Hertzog a écrit : >>> Hi, >>> >>> On Wed, 21 Nov 2018, Xavier wrote: Sorry, I found a SALSA_TEAM in your conf file. For clarity, SALSA_TEAM has been replaced by SALSA_GROUP

Bug#890594: salsa script ready to review

2018-11-22 Thread Xavier
Le 22/11/2018 à 10:19, Xavier a écrit : > Le 22/11/2018 à 08:46, Raphael Hertzog a écrit : >> Hi, >> >> On Wed, 21 Nov 2018, Xavier wrote: >>> Sorry, I found a SALSA_TEAM in your conf file. For clarity, SALSA_TEAM >>> has been replaced by SALSA_GROUP (same for all team commands/options >>>

Bug#890594: salsa script ready to review

2018-11-22 Thread Raphael Hertzog
On Thu, 22 Nov 2018, Xavier wrote: > -IRC channel for KGB or Irker. > +IRC channel for KGB or Irker. Can me used more than one time only with > +B<--irker>. s/me/be/ > -C<.devscript> value: B > +B: channel must not include the first "#". If salsa find a channel s/find/finds/ > +starting with

Bug#890594: salsa script ready to review

2018-11-22 Thread Raphael Hertzog
On Thu, 22 Nov 2018, Raphael Hertzog wrote: > wapiti: > bad irc channel: #debian-pkg-security Even after changing the setting, I still had the message for a few packages where the exact value was "#debian-pkg-security " (trailing space). I don't know if you want to strip the spaces before

Bug#890594: salsa script ready to review

2018-11-22 Thread Xavier
Le 22/11/2018 à 08:46, Raphael Hertzog a écrit : > Hi, > > On Wed, 21 Nov 2018, Xavier wrote: >> Sorry, I found a SALSA_TEAM in your conf file. For clarity, SALSA_TEAM >> has been replaced by SALSA_GROUP (same for all team commands/options >> replaced by *group*). > > Working much better with

Bug#890594: salsa script ready to review

2018-11-21 Thread Raphael Hertzog
Hi, On Wed, 21 Nov 2018, Xavier wrote: > Sorry, I found a SALSA_TEAM in your conf file. For clarity, SALSA_TEAM > has been replaced by SALSA_GROUP (same for all team commands/options > replaced by *group*). Working much better with SALSA_GROUP ;) But then I got this: wapiti: bad irc

Bug#890594: salsa script ready to review

2018-11-21 Thread Xavier
Le 21/11/2018 à 23:04, Xavier a écrit : > > Le 21/11/2018 à 23:00, Xavier a écrit : >> Le 21/11/2018 à 22:57, Xavier a écrit : >>> Le 21/11/2018 à 22:51, Raphael Hertzog a écrit : On Tue, 20 Nov 2018, Xavier wrote: >> Unable to reproduce now, this bug seems fixed now. I'm going to

Bug#890594: salsa script ready to review

2018-11-21 Thread Xavier
Le 21/11/2018 à 23:08, Xavier a écrit : > Le 21/11/2018 à 23:04, Xavier a écrit : >> >> Le 21/11/2018 à 23:00, Xavier a écrit : >>> Le 21/11/2018 à 22:57, Xavier a écrit : Le 21/11/2018 à 22:51, Raphael Hertzog a écrit : > On Tue, 20 Nov 2018, Xavier wrote: >>> Unable to reproduce

Bug#890594: salsa script ready to review

2018-11-21 Thread Xavier
Le 21/11/2018 à 23:04, Xavier a écrit : > > Le 21/11/2018 à 23:00, Xavier a écrit : >> Le 21/11/2018 à 22:57, Xavier a écrit : >>> Le 21/11/2018 à 22:51, Raphael Hertzog a écrit : On Tue, 20 Nov 2018, Xavier wrote: >> Unable to reproduce now, this bug seems fixed now. I'm going to

Bug#890594: salsa script ready to review

2018-11-21 Thread Xavier
Le 21/11/2018 à 23:00, Xavier a écrit : > Le 21/11/2018 à 22:57, Xavier a écrit : >> Le 21/11/2018 à 22:51, Raphael Hertzog a écrit : >>> On Tue, 20 Nov 2018, Xavier wrote: > Unable to reproduce now, this bug seems fixed now. I'm going to provide > a new .deb after adding other

Bug#890594: salsa script ready to review

2018-11-21 Thread Xavier
Le 21/11/2018 à 22:57, Xavier a écrit : > Le 21/11/2018 à 22:51, Raphael Hertzog a écrit : >> On Tue, 20 Nov 2018, Xavier wrote: Unable to reproduce now, this bug seems fixed now. I'm going to provide a new .deb after adding other requests. >>> >>> I built a new .deb: >>>

Bug#890594: salsa script ready to review

2018-11-21 Thread Xavier
Le 21/11/2018 à 22:51, Raphael Hertzog a écrit : > On Tue, 20 Nov 2018, Xavier wrote: >>> Unable to reproduce now, this bug seems fixed now. I'm going to provide >>> a new .deb after adding other requests. >> >> I built a new .deb: >> http://people.debian.org/~yadd/devscripts_2.18.10_amd64.deb >

Bug#890594: salsa script ready to review

2018-11-21 Thread Raphael Hertzog
On Tue, 20 Nov 2018, Xavier wrote: > > Unable to reproduce now, this bug seems fixed now. I'm going to provide > > a new .deb after adding other requests. > > I built a new .deb: > http://people.debian.org/~yadd/devscripts_2.18.10_amd64.deb It's actually worse. I'm attaching my pkg-security.conf

Bug#890594: salsa script ready to review

2018-11-20 Thread Xavier
Le 20/11/2018 à 16:36, Xavier a écrit : > Le 20/11/2018 à 15:53, Xavier a écrit : >> Le 20/11/2018 à 15:10, Raphael Hertzog a écrit : >>> Hi Xavier, >> >> Hi Raphaël, thanks for your report! >> >>> On Wed, 07 Nov 2018, Xavier wrote: I think teams should publish their own salsa.conf files. If

Bug#890594: salsa script ready to review

2018-11-20 Thread Xavier
Le 20/11/2018 à 15:53, Xavier a écrit : > Le 20/11/2018 à 15:10, Raphael Hertzog a écrit : >> Hi Xavier, > > Hi Raphaël, thanks for your report! > >> On Wed, 07 Nov 2018, Xavier wrote: >>> I think teams should publish their own salsa.conf files. If you agree, I >>> propose to stop adding feature

Bug#890594: salsa script ready to review

2018-11-20 Thread Xavier
Le 20/11/2018 à 15:10, Raphael Hertzog a écrit : > Hi Xavier, Hi Raphaël, thanks for your report! > On Wed, 07 Nov 2018, Xavier wrote: >> I think teams should publish their own salsa.conf files. If you agree, I >> propose to stop adding feature to let Martin review the actual code and >> add it

Bug#890594: salsa script ready to review

2018-11-20 Thread Raphael Hertzog
Hi Xavier, On Wed, 07 Nov 2018, Xavier wrote: > I think teams should publish their own salsa.conf filesIf you agree, I > propose to stop adding feature to let Martin review the actual code and > add it to devscripts. Then after some tests in real life, we will be > able to continue adding new

Bug#890594: salsa script ready to review

2018-11-07 Thread Xavier
Le Mercredi, Novembre 07, 2018 00:04 CET, Xavier a écrit:Le 06/11/2018 à 14:04, Raphael Hertzog a écrit :> On Tue, 06 Nov 2018, Xavier wrote: >>> While reading the discussion on -devel, it also occured to me that we >>> might want to be able to enable/disable the possibility to file issues >>>

Bug#890594: salsa script ready to review

2018-11-06 Thread Xavier
Le 06/11/2018 à 14:04, Raphael Hertzog a écrit : > On Tue, 06 Nov 2018, Xavier wrote: >>> While reading the discussion on -devel, it also occured to me that we >>> might want to be able to enable/disable the possibility to file issues >>> and open merge request. >> >> MR is done. Example: > > You

Bug#890594: salsa script ready to review

2018-11-06 Thread Raphael Hertzog
On Tue, 06 Nov 2018, Xavier wrote: > > While reading the discussion on -devel, it also occured to me that we > > might want to be able to enable/disable the possibility to file issues > > and open merge request. > > MR is done. Example: You misunderstood my request. I'm speaking of setting the

Bug#890594: salsa script ready to review

2018-11-06 Thread Xavier
Le 06/11/2018 à 12:11, Raphael Hertzog a écrit : > On Mon, 29 Oct 2018, Xavier wrote: >> I also added an "update_safe" command that starts "check_repo", then >> reports and asks before launching "update_repo" (unless --yes). I think >> that's what you want, isn't it? > > Yes, that's the idea. >

Bug#890594: salsa script ready to review

2018-11-06 Thread Xavier
Le 06/11/2018 à 12:13, Raphael Hertzog a écrit : > Hi, > > On Mon, 29 Oct 2018, Xavier wrote: >> I also added an "update_safe" command that starts "check_repo", then >> reports and asks before launching "update_repo" (unless --yes). I think >> that's what you want, isn't it? > > Last point, I

Bug#890594: salsa script ready to review

2018-11-06 Thread Raphael Hertzog
Hi, On Mon, 29 Oct 2018, Xavier wrote: > I also added an "update_safe" command that starts "check_repo", then > reports and asks before launching "update_repo" (unless --yes). I think > that's what you want, isn't it? Last point, I would like to test your tool. Since the script is not

Bug#890594: salsa script ready to review

2018-11-06 Thread Raphael Hertzog
On Mon, 29 Oct 2018, Xavier wrote: > I also added an "update_safe" command that starts "check_repo", then > reports and asks before launching "update_repo" (unless --yes). I think > that's what you want, isn't it? Yes, that's the idea. While reading the discussion on -devel, it also occured to

Bug#890594: salsa script ready to review

2018-10-29 Thread Xavier
Le 29/10/2018 à 21:50, Xavier a écrit : > Le 29/10/2018 à 21:35, Xavier a écrit : >> Le 29/10/2018 à 12:27, Raphael Hertzog a écrit : >>> On Sun, 28 Oct 2018, Xavier wrote: Mattia explained me dep14. I found a way to do it: create branch from master, update project to set default_branch

Bug#890594: salsa script ready to review

2018-10-29 Thread Xavier
Le 29/10/2018 à 21:35, Xavier a écrit : > Le 29/10/2018 à 12:27, Raphael Hertzog a écrit : >> On Sun, 28 Oct 2018, Xavier wrote: >>> Mattia explained me dep14. I found a way to do it: create branch from >>> master, update project to set default_branch to debian/master then >>> remove master. It

Bug#890594: salsa script ready to review

2018-10-29 Thread Xavier
Le 29/10/2018 à 12:27, Raphael Hertzog a écrit : > On Sun, 28 Oct 2018, Xavier wrote: >> Mattia explained me dep14. I found a way to do it: create branch from >> master, update project to set default_branch to debian/master then >> remove master. It works as expected. >> >> $ salsa update_repo

Bug#890594: salsa script ready to review

2018-10-29 Thread Raphael Hertzog
On Sun, 28 Oct 2018, Xavier wrote: > Mattia explained me dep14. I found a way to do it: create branch from > master, update project to set default_branch to debian/master then > remove master. It works as expected. > > $ salsa update_repo node-mongodb --group js-team --rename-head > > $ salsa

Bug#890594: salsa script ready to review

2018-10-28 Thread Xavier
Le 28/10/2018 à 09:47, Xavier a écrit : > Le 28/10/2018 à 08:43, Xavier a écrit : >> Le 27/10/2018 à 14:24, Xavier a écrit : >>> Le 25/10/2018 à 11:33, Raphael Hertzog a écrit : Hi, >>> >>> Hello, >>> On Fri, 19 Oct 2018, Xavier wrote: > first version of salsa script is ready to

Bug#890594: salsa script ready to review

2018-10-28 Thread Xavier
Le 28/10/2018 à 08:43, Xavier a écrit : > Le 27/10/2018 à 14:24, Xavier a écrit : >> Le 25/10/2018 à 11:33, Raphael Hertzog a écrit : >>> Hi, >> >> Hello, >> >>> On Fri, 19 Oct 2018, Xavier wrote: first version of salsa script is ready to review. Documentation is here:

Bug#890594: salsa script ready to review

2018-10-28 Thread Xavier
Le 27/10/2018 à 14:24, Xavier a écrit : > Le 25/10/2018 à 11:33, Raphael Hertzog a écrit : >> Hi, > > Hello, > >> On Fri, 19 Oct 2018, Xavier wrote: >>> first version of salsa script is ready to review. Documentation is here: >>>

Bug#890594: salsa script ready to review

2018-10-27 Thread Xavier
Le 25/10/2018 à 11:33, Raphael Hertzog a écrit : > Hi, Hello, > On Fri, 19 Oct 2018, Xavier wrote: >> first version of salsa script is ready to review. Documentation is here: >> https://salsa.debian.org/yadd/devscripts/blob/devscripts-salsa-890594/scripts/salsa.pl > > Thanks for working on

Bug#890594: salsa script ready to review

2018-10-25 Thread Raphael Hertzog
Hi, On Fri, 19 Oct 2018, Xavier wrote: > first version of salsa script is ready to review. Documentation is here: > https://salsa.debian.org/yadd/devscripts/blob/devscripts-salsa-890594/scripts/salsa.pl Thanks for working on this! My first comment is that we should not have to work with

Bug#890594: salsa script ready to review

2018-10-21 Thread Xavier
Le 21/10/2018 à 16:26, gregor herrmann a écrit : > On Fri, 19 Oct 2018 11:07:02 +0200, Xavier wrote: > >> QUESTION 1: is "salsa" a good name? > > Not sure … one one hand it's a bit generic, on the other hand it's > nice and short and clear, and "bts" for example is similar. > (I don't have a

Bug#890594: salsa script ready to review

2018-10-21 Thread gregor herrmann
On Fri, 19 Oct 2018 11:07:02 +0200, Xavier wrote: > QUESTION 1: is "salsa" a good name? Not sure … one one hand it's a bit generic, on the other hand it's nice and short and clear, and "bts" for example is similar. (I don't have a better idea …) > QUESTION 2: I think --all should fail unless

Bug#890594: salsa script ready to review

2018-10-19 Thread Xavier
Hello, first version of salsa script is ready to review. Documentation is here: https://salsa.debian.org/yadd/devscripts/blob/devscripts-salsa-890594/scripts/salsa.pl Resume: - usage salsa - manage users in group: salsa --team-id=1234 add_user maintainer foobar salsa