Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

fowarded 904685 https://salsa.debian.org/reproducible-builds/diffoscope/merge_requests/10 thanks Hi Ricardo, > We can move this discussion over to the MR if that suits better. Just let > me know. Have responded on the merge request & let's move over there. Regards, -- ,''`. : :'

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

Hi Chris, Thanks for the swift feedback, and for sharing. I have issued a merge request which can be found here . Have addressed your comments, including narrower exception, accompanied by a comment, and one test case

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

tags 904685 + patch thanks Dear Ricardo, > Based on this bug, please find attached a proposed patch for handling > this error gracefully [..] Wow, thank you so much for this :) > Additionally, I see that I could have also just submitted a merge request > via salsa.debian.org. What is the usual

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

Hi Chris, Based on this bug, please find attached a proposed patch for handling this error gracefully by catching any exceptions caused by trying to open an encrypted file in an archive. and forwarding it on as a *ContainerExtractionError*. I would gladly appreciate some feedback. I tried to

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

Perfect! thanks for the clarification. Will look into it so ;) P.S. I love diffoscope! On Fri, Jul 27, 2018 at 5:26 PM Chris Lamb wrote: > Hi Ricardo, > > > By the way, if this is a lower priority bug than others. I will gladly > have > > a look into the issue and try and resolve it, provided

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

By the way, if this is a lower priority bug than others. I will gladly have a look into the issue and try and resolve it, provided that we agree on the expected behaviour of the tool under such a scenario. Ricardo On Fri, Jul 27, 2018 at 5:14 PM Ricardo Gaviria wrote: > Hi Chris, > > Thanks

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

Hi Ricardo, > By the way, if this is a lower priority bug than others. I will gladly have > a look into the issue and try and resolve it, provided that we agree on the > expected behaviour of the tool under such a scenario. AIUI the *ideal* behaviour would be that encrypted files would: a)

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

retitle 904685 diffoscope: RuntimeError when trying to extract an encrypted file within .zip tags 904685 + moreinfo thanks Hi Ricardo, > Is this expected behaviour or is there a cmd line parameter which I > could use to prevent this? Oh, not at all the expected behaviour. diffoscope should

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

Package: diffoscope Version: 51 Severity: normal Dear Maintainer, I was trying to diff two versions of a windows installer directory, and encountered a RuntimeError due to diffoscope not being able to extract an encrypted file. I would have expected for the system to maybe report that such