Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-19 Thread Salvatore Bonaccorso
Hi Utkarsh, On Fri, Feb 19, 2021 at 10:44:08PM +0530, Utkarsh Gupta wrote: > Hi Axel, Salvatore, > > On Fri, Feb 19, 2021 at 2:44 PM Axel Beckert wrote: > > No issue popped up so far during production use on Stretch and Buster. > > I'd say, we can publish these in good conscience. > > Perfect,

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-19 Thread Utkarsh Gupta
Hi Axel, Salvatore, On Fri, Feb 19, 2021 at 2:44 PM Axel Beckert wrote: > No issue popped up so far during production use on Stretch and Buster. > I'd say, we can publish these in good conscience. Perfect, thanks for all your work on this! \o/ I've uploaded to stretch-security (& pushed the

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-19 Thread Utkarsh Gupta
Hi Axel, Sorry for the late reply, I was a bit occupied with my school homework. On Wed, Feb 17, 2021 at 8:59 AM Axel Beckert wrote: > > So I created one with the latest dsc (4.2.1-3+deb8u1) and added 2 > > commits on top of it. > > Thanks for the effort, but this seems to have a separate git

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-19 Thread Axel Beckert
Hi Utkarsh, Utkarsh Gupta wrote: > On Tue, Feb 16, 2021 at 11:12 PM Axel Beckert wrote: > > I'm running these patches (as in git) now for about 1.5 days on > > Stretch and Buster in production. I'd say if I don't find any > > regression until Wednesday evening (i.e. in 1 day), feel free to > >

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-16 Thread Axel Beckert
Dear Utkarsh, Utkarsh Gupta wrote: > Sure thing, once you give a go-ahead, I'll edit the changelog entry > and shall push that to the salsa repository. Ok, thanks! > > existing jessie branch in git. (It has no commit besides those being > > part of the master branch. Not sure why I or someone

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-16 Thread Utkarsh Gupta
Hi Axel, On Tue, Feb 16, 2021 at 11:12 PM Axel Beckert wrote: > I'm running these patches (as in git) now for about 1.5 days on > Stretch and Buster in production. I'd say if I don't find any > regression until Wednesday evening (i.e. in 1 day), feel free to > finalise the packages as needed

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-16 Thread Axel Beckert
Hi Utkarsh, Utkarsh Gupta wrote: > > What so far was in git in the stretch and buster branches was > > incomplete and did FTBFS for multiple reasons. (Just pushed a bunch of > > fixes. It at least builds now on both releases.) > > > > And in Stretch the patch didn't even apply properly and needed

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-16 Thread Utkarsh Gupta
Hi Axel, On Mon, Feb 15, 2021 at 12:13 PM Axel Beckert wrote: > Please slow down! > > What so far was in git in the stretch and buster branches was > incomplete and did FTBFS for multiple reasons. (Just pushed a bunch of > fixes. It at least builds now on both releases.) > > And in Stretch the

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-14 Thread Axel Beckert
Hi Utkarsh, Utkarsh Gupta wrote: > On Sun, Feb 14, 2021 at 9:03 PM Axel Beckert wrote: > > > Since it's been ~3 days, do you think now would be the time to prepare > > > and upload to buster and stretch? > > > > While I prepared the uploads in git, I haven't yet tested them on > > Stretch and

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-14 Thread Utkarsh Gupta
Hi, On Sun, Feb 14, 2021 at 9:03 PM Axel Beckert wrote: > > Since it's been ~3 days, do you think now would be the time to prepare > > and upload to buster and stretch? > > While I prepared the uploads in git, I haven't yet tested them on > Stretch and Buster. Currently still running the patch

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-14 Thread Axel Beckert
Hi Utkarsh, Utkarsh Gupta wrote: > On Fri, Feb 12, 2021 at 11:07 AM Salvatore Bonaccorso > wrote: > > Thanks for all your coordinaton, investigation, work on this! > > Seconded! Thanks for all your awesome and super fast work, really! \o/ Your welcome! > > Sounds good. I propose to have the

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-14 Thread Utkarsh Gupta
Hi Axel, On Fri, Feb 12, 2021 at 11:07 AM Salvatore Bonaccorso wrote: > Thanks for all your coordinaton, investigation, work on this! Seconded! Thanks for all your awesome and super fast work, really! \o/ > Sounds good. I propose to have the potential final patch as well first > slightly

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-12 Thread Michael Schroeder
On Thu, Feb 11, 2021 at 11:39:09PM +0100, Axel Beckert wrote: > The only thing it didn't fix so far is > https://savannah.gnu.org/bugs/?31336 aka > https://bugs.debian.org/600246 although I really had some hope that > this might be fixed as a side-effect of your patch. :-) Oh, that happens

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-11 Thread Salvatore Bonaccorso
Hi Axel, [dropping upstream lists and other people, + team@s.d.o] On Thu, Feb 11, 2021 at 11:39:09PM +0100, Axel Beckert wrote: [...] > Salvatore, Utkarsh: Will also prepare and test at least patches in Git > for Buster and Stretch. (Hey, I don't want my mutt screen sessions to > be killed

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-11 Thread Axel Beckert
Hi Michael, Michael Schroeder schrieb am Thu, Feb 11, 2021 at 04:54:46PM +: > I've dug a bit more into this, and the root cause of all the evil we > see seems to be that utf8_isdouble() does not return true for the > 0xdf00-0xdfff character range. This seems to be a mistake done > in commit

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-11 Thread Axel Beckert
Hi again, On Wed, Feb 10, 2021 at 11:01:58PM -, Tavis Ormandy wrote: > On 2021-02-10, Axel Beckert wrote: > > + else if (i < sizeof combchars / sizeof *combchars) { > > This doesn't seem right, I think it should be compared against the > calloc param at the top of utf8_handle_comb(), but I

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-10 Thread Axel Beckert
Hi Tavis, thanks for having a look into this! Tavis Ormandy wrote: > On 2021-02-10, Axel Beckert wrote: > > + else if (i < sizeof combchars / sizeof *combchars) { > > This doesn't seem right, I think it should be compared against the > calloc param at the top of utf8_handle_comb(), Good

Bug#982435: [screen-devel] [bug #60030] Screen segfaults by displaying some UTF-8 character combination

2021-02-10 Thread Axel Beckert
Hi again, Axel Beckert wrote: > On Wed, Feb 10, 2021 at 08:59:15AM -0500, Michael Schröder wrote: > > diff --git a/src/encoding.c b/src/encoding.c > > index 11c3c41..e1ea364 100644 > > --- a/src/encoding.c > > +++ b/src/encoding.c > > @@ -1164,7 +1164,9 @@ void utf8_handle_comb(unsigned int c,