On Wed, 02 Jun 2021 18:07:09 +0200 Tobias Frost <t...@debian.org> wrote:
- On a new package, the _only_ changelog entry is that one that closes the ITP.
(in your case delete the new upstream version line and *all* older entries.
You still have two changelog entries in 1.6.3~test1-1
- There are lots of versioned Build-Depends which are already fulfilled in
oldstable. drop those.
- There is no cmake3 package in Debian, drop that alternative to cmake.
- It should be sufficient for the boost B-D to just specify the version
agnostic one. Or do I miss the point what you want to archive here?
(beside, oldstable has already 1.62, so no need to say >1.58)
First subtask is fixed, 2nd is still open.
- The examples should be installed using dh_installexamples (not using
*.install)
Also, manpages should not be installed via *.install but via *.manpages.
- I think the user/group handling in postinst is wrong in several ways.
- hardcoded id of 888.
- names should be "invalid names" so that it cannot cause collisions.
- setting the hoemdirectory to /tmp/ is certainly a bad idea and I
guess insecure. Especially when setting /bin/bash as shell…
- IOW, Read the Debian Policy on this topic.
Package needs work; therefore tagging moreinfo. Please remove for the next
iteration. I did not do a copyright review.
Also, drop the empty d/tests/control and d/changelog.dist files.
