Bug#430706: savelog: COMPRESS options are being passed to which

[Carlo Wood]

Package: debianutils
Version: 2.21
Severity: normal
Tags: patch

I started to get email from crond about:
which: invalid option -- 9
which: invalid option -- f
The reason is that you are passing options meant for bzip to which.

Here is a patch:

--- /usr/bin/savelog.orig       2007-06-26 19:55:43.000000000 +0200
+++ /usr/bin/savelog    2007-06-26 20:11:19.000000000 +0200
@@ -77,7 +77,8 @@
 
 # common location
 export PATH=$PATH:/sbin:/bin:/usr/sbin:/usr/bin
-COMPRESS="gzip -9f"
+COMPRESS="gzip"
+COMPRESS_OPTS="-9f"
 DOT_Z=".gz"
 DATUM=`date +%Y%m%d%H%M%S`
 
@@ -141,7 +142,7 @@
        C) forceclean=1 ;;
        d) datum=1 ;;
        t) touch=1 ;;
-       j) COMPRESS="bzip2 -9f" ; DOT_Z=".bz2" ;;
+       j) COMPRESS="bzip2"; COMPRESS_OPTS="-9f"; DOT_Z=".bz2" ;;
        l) COMPRESS="" ;;
        p) preserve=1 ;;
        n) rotateifempty="no" ;;
@@ -244,9 +245,9 @@
                        mv -- "$newname.0" "$newfile"
                else
                        newfile="$newname.1$DOT_Z"
-#                      $COMPRESS < $newname.0 > $newfile
+#                      $COMPRESS $COMPRESS_OPTS < $newname.0 > $newfile
 #                      rm -f $newname.0
-                       $COMPRESS "$newname.0"
+                       $COMPRESS $COMPRESS_OPTS "$newname.0"
                        mv -- "$newname.0$DOT_Z" "$newfile"
                fi
                fixfile "$newfile"
@@ -254,7 +255,7 @@
 
        # compress the old uncompressed log if needed
        if test -n "$datum" && test -n "$COMPRESS"; then
-               $COMPRESS -- 
"$newname".[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]
+               $COMPRESS $COMPRESS_OPTS -- 
"$newname".[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]
        fi
 
        # remove old files if so desired

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.22-rc5-agp1-188e1f81ba31af1b65a2f3611df4c670b092bbac-amd64 
(SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages debianutils depends on:
ii  libc6                         2.5-9      GNU C Library: Shared libraries

debianutils recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]